From: Kishon Vijay Abraham I <kishon@ti.com>
To: Rolf Evers-Fischer <embedded24@evers-fischer.de>
Cc: <lorenzo.pieralisi@arm.com>, <bhelgaas@google.com>,
<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<andy.shevchenko@gmail.com>,
Rolf Evers-Fischer <rolf.evers.fischer@aptiv.com>
Subject: Re: [PATCH v3 2/2] pci: endpoint: Fix kernel panic after put_device()
Date: Tue, 27 Feb 2018 16:13:41 +0530 [thread overview]
Message-ID: <ab1fb0a5-f1b0-f53d-d986-b5ee62ca6f75@ti.com> (raw)
In-Reply-To: <20180227100231.22561-3-embedded24@evers-fischer.de>
On Tuesday 27 February 2018 03:32 PM, Rolf Evers-Fischer wrote:
> From: Rolf Evers-Fischer <rolf.evers.fischer@aptiv.com>
>
> 'put_device()' calls the relase function 'pci_epf_dev_release()',
> which already frees 'epf->name' and 'epf'.
>
> Therefore we must not free them again after 'put_device()'.
>
> Fixes: 5e8cb4033807 ("PCI: endpoint: Add EP core layer to enable EP controller and EP functions")
>
> Signed-off-by: Rolf Evers-Fischer <rolf.evers.fischer@aptiv.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/pci/endpoint/pci-epf-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c
> index 1f2506f32bb9..1878a6776519 100644
> --- a/drivers/pci/endpoint/pci-epf-core.c
> +++ b/drivers/pci/endpoint/pci-epf-core.c
> @@ -232,7 +232,7 @@ struct pci_epf *pci_epf_create(const char *name)
>
> put_dev:
> put_device(dev);
> - kfree(epf->name);
> + return ERR_PTR(ret);
>
> free_epf:
> kfree(epf);
>
next prev parent reply other threads:[~2018-02-27 10:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 10:02 [PATCH v3 0/2] pci: endpoint: Fix double free in pci_epf_create() Rolf Evers-Fischer
2018-02-27 10:02 ` [PATCH v3 1/2] pci: endpoint: Simplify name allocation for epf device Rolf Evers-Fischer
2018-02-27 10:09 ` Kishon Vijay Abraham I
2018-02-27 10:15 ` Rolf Evers-Fischer
2018-02-27 10:43 ` Kishon Vijay Abraham I
2018-02-27 10:02 ` [PATCH v3 2/2] pci: endpoint: Fix kernel panic after put_device() Rolf Evers-Fischer
2018-02-27 10:43 ` Kishon Vijay Abraham I [this message]
2018-02-27 17:57 ` Lorenzo Pieralisi
2018-02-28 10:29 ` Rolf Evers-Fischer
2018-02-27 10:20 ` [PATCH v3 0/2] pci: endpoint: Fix double free in pci_epf_create() Lorenzo Pieralisi
2018-02-27 12:11 ` Rolf Evers-Fischer
2018-02-27 14:52 ` Bjorn Helgaas
2018-02-28 10:35 ` Rolf Evers-Fischer
2018-02-27 16:13 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab1fb0a5-f1b0-f53d-d986-b5ee62ca6f75@ti.com \
--to=kishon@ti.com \
--cc=andy.shevchenko@gmail.com \
--cc=bhelgaas@google.com \
--cc=embedded24@evers-fischer.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rolf.evers.fischer@aptiv.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).