public inbox for linux-pci@vger.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Thierry Reding <thierry.reding@kernel.org>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Karthikeyan Mitran" <m.karthikeyan@mobiveil.co.in>,
	"Hou Zhiqiang" <Zhiqiang.Hou@nxp.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Pali Rohár" <pali@kernel.org>,
	"Michal Simek" <michal.simek@amd.com>,
	"Kevin Xie" <kevin.xie@starfivetech.com>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: Use standard wait times for PCIe link monitoring
Date: Fri, 20 Mar 2026 23:47:31 +0100	[thread overview]
Message-ID: <ab3N-sNecpOV0WGi@orome> (raw)
In-Reply-To: <20260320224044.2569907-1-thierry.reding@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]

On Fri, Mar 20, 2026 at 11:40:44PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> Instead of defining the wait values for each driver, use common values
> defined in the core pci.h header file. Note that most drivers don't use
> the millisecond waits, but rather usleep_range(), so add these commonly
> used values to the header so that all drivers can use them.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  .../pci/controller/cadence/pcie-cadence-host-common.c    | 4 ++--
>  drivers/pci/controller/cadence/pcie-cadence-lga-regs.h   | 5 -----
>  drivers/pci/controller/mobiveil/pcie-mobiveil.c          | 4 ++--
>  drivers/pci/controller/mobiveil/pcie-mobiveil.h          | 5 -----
>  drivers/pci/controller/pci-aardvark.c                    | 7 ++-----
>  drivers/pci/controller/pcie-xilinx-nwl.c                 | 9 ++-------
>  drivers/pci/controller/plda/pcie-starfive.c              | 9 ++-------
>  drivers/pci/pci.h                                        | 2 ++
>  8 files changed, 12 insertions(+), 33 deletions(-)

Ugh... sent this out and then noticed I hadn't committed the change
which adds the pci.h include for the Cadence driver I made after build
testing this.

I'll send out v2. Sorry for the noise.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2026-03-20 22:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-20 22:40 [PATCH] PCI: Use standard wait times for PCIe link monitoring Thierry Reding
2026-03-20 22:47 ` Thierry Reding [this message]
2026-03-21  9:44 ` kernel test robot
2026-03-21 10:17 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab3N-sNecpOV0WGi@orome \
    --to=thierry.reding@gmail.com \
    --cc=Zhiqiang.Hou@nxp.com \
    --cc=bhelgaas@google.com \
    --cc=kevin.xie@starfivetech.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=m.karthikeyan@mobiveil.co.in \
    --cc=mani@kernel.org \
    --cc=michal.simek@amd.com \
    --cc=pali@kernel.org \
    --cc=robh@kernel.org \
    --cc=thierry.reding@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox