From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org ([63.228.1.57]:36178 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725926AbeHTFgl (ORCPT ); Mon, 20 Aug 2018 01:36:41 -0400 Message-ID: Subject: Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed From: Benjamin Herrenschmidt To: Sinan Kaya , Bjorn Helgaas Cc: poza@codeaurora.org, Thomas Tai , bhelgaas@google.com, keith.busch@intel.com, linux-pci@vger.kernel.org, linux-pci-owner@vger.kernel.org, Sam Bobroff Date: Mon, 20 Aug 2018 12:03:24 +1000 In-Reply-To: References: <1534179088-44219-1-git-send-email-thomas.tai@oracle.com> <1534179088-44219-2-git-send-email-thomas.tai@oracle.com> <51f4b387d9bd96a42d526a6a029fc43b@codeaurora.org> <903394c04d6ad468ed06dc0a779200e7555345a7.camel@kernel.crashing.org> <6cb069038530757f31f3dd60328c7e30@codeaurora.org> <20180819021922.GE128050@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org List-ID: On Sun, 2018-08-19 at 17:41 -0400, Sinan Kaya wrote: > On 8/18/2018 10:19 PM, Bjorn Helgaas wrote: > > > Bjorn, please revert all of those changes. > > > > Please send the appropriate patches and we'll go from there. > > > > I'm also catching up on this thread. > > I don't think revert is the way to go. There is certainly value in Oza's > code to make error handling common. The revert of the Documentation change must happen though. It's completely wrong. The documentation documents what EEH implements so by making it match what I argue is a broken implementation in AER, you are in fact breaking us. > We started by following the existing error handling scheme and then > moved onto the stop/remove behavior based on Bjorn's feedback. Whish is utterly wrong. > The right thing is for Oza to rework the code to go back to original > error handling callback mechanism. That should be a trivial change. At this stage I'm only asking to revert the documentation updatgae. I'll send a patch to that effect. As for figuring out where to go from there, I agree we should discuss this further, I would love to be able to make more of the code common with EEH as well. Cheers, Ben.