From: Sinan Kaya <okaya@kernel.org>
To: Alex Williamson <alex.williamson@redhat.com>, linux-pci@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2 2/2] PCI: NVMe device specific reset quirk
Date: Mon, 23 Jul 2018 17:40:02 -0700 [thread overview]
Message-ID: <abc86e6b-7df5-a84c-7e98-107c605812c6@kernel.org> (raw)
In-Reply-To: <20180724001310.7671.41243.stgit@gimli.home>
On 7/23/2018 5:13 PM, Alex Williamson wrote:
> + * The NVMe specification requires that controllers support PCIe FLR, but
> + * but some Samsung SM961/PM961 controllers fail to recover after FLR (-1
> + * config space) unless the device is quiesced prior to FLR.
Does disabling the memory bit in PCI config space as part of the FLR
reset function help? (like the very first thing)
Can we do that in the pcie_flr() function to cover other endpoint types
that might be pushing traffic while code is trying to do a reset?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2018-07-24 0:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 0:12 [PATCH v2 0/2] PCI: NVMe reset quirk Alex Williamson
2018-07-24 0:13 ` [PATCH v2 1/2] PCI: Export pcie_has_flr() Alex Williamson
2018-07-24 0:13 ` [PATCH v2 2/2] PCI: NVMe device specific reset quirk Alex Williamson
2018-07-24 0:40 ` Sinan Kaya [this message]
2018-07-24 1:57 ` Alex Williamson
2018-07-24 2:20 ` Sinan Kaya
2018-07-24 3:16 ` Alex Williamson
2018-07-24 6:54 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abc86e6b-7df5-a84c-7e98-107c605812c6@kernel.org \
--to=okaya@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).