From: Florian Fainelli <f.fainelli@gmail.com>
To: Christoph Hellwig <hch@infradead.org>,
Jim Quinlan <jim2101024@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-mips@linux-mips.org,
Florian Fainelli <f.fainelli@gmail.com>,
devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
Kevin Cernekee <cernekee@gmail.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
Rob Herring <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
Gregory Fong <gregory.0xf0@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Brian Norris <computersforpeace@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/9] SOC: brcmstb: add memory API
Date: Tue, 17 Oct 2017 09:12:22 -0700 [thread overview]
Message-ID: <abdb1e9d-f8c9-8066-48c5-37b4e2474952@gmail.com> (raw)
In-Reply-To: <20171017082413.GA10574@infradead.org>
On 10/17/2017 01:24 AM, Christoph Hellwig wrote:
>> +/* Macros to help extract property data */
>> +#define U8TOU32(b, offs) \
>> + ((((u32)b[0 + offs] << 0) & 0x000000ff) | \
>> + (((u32)b[1 + offs] << 8) & 0x0000ff00) | \
>> + (((u32)b[2 + offs] << 16) & 0x00ff0000) | \
>> + (((u32)b[3 + offs] << 24) & 0xff000000))
>
> Please us helpers like get_unaligned_le32 instead opencoding them.
>
>> +#define DT_PROP_DATA_TO_U32(b, offs) (fdt32_to_cpu(U8TOU32(b, offs)))
>
> And together with this it looks really whacky. So you're converting
> from le to native first and then do another conversion from be to cpu?
>
> Something doesn't work out here.
>
>> +/* -------------------- Functions -------------------- */
>
> Please remove pointless comments like this one.
>
>> +
>> +/*
>> + * If the DT nodes are handy, determine which MEMC holds the specified
>> + * physical address.
>> + */
>> +#ifdef CONFIG_ARCH_BRCMSTB
>> +int __brcmstb_memory_phys_addr_to_memc(phys_addr_t pa, void __iomem *base)
>
> Please move this into the arm arch code.
No, this needs to work on both ARM and ARM64, hence the reason why this
is in a reasonably architecture neutral place.
>
>> +#elif defined(CONFIG_MIPS)
>
> And this into the mips arch code.
Same reason as above.
>
>> +EXPORT_SYMBOL(brcmstb_memory_phys_addr_to_memc);
>
>> +EXPORT_SYMBOL(brcmstb_memory_memc_size);
>
> Why is this exported?
Because the PCIE RC driver can be built as a module.
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-10-17 16:12 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 22:34 PCI: brcmstb: Add Broadcom Settopbox PCIe support Jim Quinlan
2017-10-11 22:34 ` [PATCH 1/9] SOC: brcmstb: add memory API Jim Quinlan
2017-10-12 14:41 ` Julien Thierry
2017-10-12 16:53 ` Florian Fainelli
2017-10-17 8:24 ` Christoph Hellwig
2017-10-17 16:12 ` Florian Fainelli [this message]
2017-10-18 6:46 ` Christoph Hellwig
2017-10-18 16:47 ` Florian Fainelli
2017-10-11 22:34 ` [PATCH 2/9] PCI: host: brcmstb: add DT docs for Brcmstb PCIe device Jim Quinlan
2017-10-12 0:55 ` Brian Norris
2017-10-12 17:52 ` Jim Quinlan
2017-10-17 20:24 ` Rob Herring
2017-10-17 22:42 ` Jim Quinlan
2017-10-19 21:49 ` Rob Herring
2017-10-19 21:58 ` Florian Fainelli
2017-10-20 17:27 ` Brian Norris
2017-10-20 21:39 ` Rob Herring
2017-10-19 23:04 ` Jim Quinlan
2017-10-11 22:34 ` [PATCH 3/9] PCI: host: brcmstb: Broadcom PCIe Host Controller Jim Quinlan
2017-10-11 22:34 ` [PATCH 4/9] arm64: dma-mapping: export symbol arch_setup_dma_ops Jim Quinlan
2017-10-12 17:06 ` Robin Murphy
2017-10-12 18:15 ` Jim Quinlan
2017-10-11 22:34 ` [PATCH 5/9] PCI: host: brcmstb: add dma-ranges for inbound traffic Jim Quinlan
2017-10-12 18:04 ` Robin Murphy
2017-10-12 21:43 ` Jim Quinlan
2017-10-17 8:14 ` Christoph Hellwig
2017-10-17 16:11 ` Jim Quinlan
2017-10-18 6:53 ` Christoph Hellwig
2017-10-18 14:41 ` Jim Quinlan
2017-10-19 9:16 ` Christoph Hellwig
2017-10-19 22:47 ` Jim Quinlan
2017-10-20 7:37 ` Christoph Hellwig
2017-10-20 14:41 ` Jim Quinlan
2017-10-20 14:57 ` Christoph Hellwig
2017-10-20 15:27 ` Jim Quinlan
2017-10-20 16:17 ` Christoph Hellwig
2017-10-23 9:06 ` David Laight
2017-10-24 18:08 ` Jim Quinlan
2017-10-25 9:36 ` David Laight
2017-10-11 22:34 ` [PATCH 6/9] PCI/MSI: Enable PCI_MSI_IRQ_DOMAIN support for MIPS Jim Quinlan
2017-10-11 22:34 ` [PATCH 7/9] PCI: host: brcmstb: add MSI capability Jim Quinlan
2017-10-11 22:34 ` [PATCH 8/9] MIPS: BMIPS: add PCI bindings for 7425, 7435 Jim Quinlan
2017-10-11 22:34 ` [PATCH 9/9] MIPS: BMIPS: enable PCI Jim Quinlan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abdb1e9d-f8c9-8066-48c5-37b4e2474952@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=cernekee@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregory.0xf0@gmail.com \
--cc=hch@infradead.org \
--cc=jim2101024@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).