From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9C01C4338F for ; Wed, 11 Aug 2021 22:29:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 933B660FD9 for ; Wed, 11 Aug 2021 22:29:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232599AbhHKW3d (ORCPT ); Wed, 11 Aug 2021 18:29:33 -0400 Received: from mga18.intel.com ([134.134.136.126]:21342 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232538AbhHKW3d (ORCPT ); Wed, 11 Aug 2021 18:29:33 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10073"; a="202400426" X-IronPort-AV: E=Sophos;i="5.84,314,1620716400"; d="scan'208";a="202400426" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 15:29:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,314,1620716400"; d="scan'208";a="517014040" Received: from linux.intel.com ([10.54.29.200]) by FMSMGA003.fm.intel.com with ESMTP; 11 Aug 2021 15:29:08 -0700 Received: from debox1-desk1.jf.intel.com (debox1-desk1.jf.intel.com [10.54.75.53]) by linux.intel.com (Postfix) with ESMTP id 0AE415808D9; Wed, 11 Aug 2021 15:29:08 -0700 (PDT) Message-ID: Subject: Re: [PATCH] pci: ptm: remove error message at boot From: "David E. Box" Reply-To: david.e.box@linux.intel.com To: Jakub Kicinski , bhelgaas@google.com Cc: linux-pci@vger.kernel.org, rafael.j.wysocki@intel.com Date: Wed, 11 Aug 2021 15:29:07 -0700 In-Reply-To: <20210811185955.3112534-1-kuba@kernel.org> References: <20210811185955.3112534-1-kuba@kernel.org> Organization: David E. Box Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, 2021-08-11 at 11:59 -0700, Jakub Kicinski wrote: > Since commit 39850ed51062 ("PCI/PTM: Save/restore Precision > Time Measurement Capability for suspend/resume") devices > which have PTM capability but don't enable it see this > message on calls to pci_save_state(): > >   "no suspend buffer for PTM" > > Drop the message, it's perfectly fine not to use a capability. Ack. Thanks. > > Fixes: 39850ed51062 ("PCI/PTM: Save/restore Precision Time > Measurement Capability for suspend/resume") > Signed-off-by: Jakub Kicinski > --- >  drivers/pci/pcie/ptm.c | 4 +--- >  1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pci/pcie/ptm.c b/drivers/pci/pcie/ptm.c > index 95d4eef2c9e8..4810faa67f52 100644 > --- a/drivers/pci/pcie/ptm.c > +++ b/drivers/pci/pcie/ptm.c > @@ -60,10 +60,8 @@ void pci_save_ptm_state(struct pci_dev *dev) >                 return; >   >         save_state = pci_find_saved_ext_cap(dev, PCI_EXT_CAP_ID_PTM); > -       if (!save_state) { > -               pci_err(dev, "no suspend buffer for PTM\n"); > +       if (!save_state) >                 return; > -       } >   >         cap = (u16 *)&save_state->cap.data[0]; >         pci_read_config_word(dev, ptm + PCI_PTM_CTRL, cap);