Re: [PATCH 0/8] drm/i915/pciids: PCI ID macro cleanups

Bjorn Helgaas
2024-05-15T15:45:07Z

On Fri, May 10, 2024 at 04:55:07PM +0300, Jani Nikula wrote:
> On Fri, 10 May 2024, Jani Nikula <jani.nikula@intel.com> wrote:
> > This is a spin-off from [1], including just the PCI ID macro cleanups,
> > as well as adding a bunch more cleanups.
> >
> > BR,
> > Jani.
> >
> > [1] https://lore.kernel.org/all/cover.1715086509.git.jani.nikula@intel.com/
> >
> >
> > Jani Nikula (8):
> > drm/i915/pciids: add INTEL_PNV_IDS(), use acronym
> > drm/i915/pciids: add INTEL_ILK_IDS(), use acronym
> > drm/i915/pciids: add INTEL_SNB_IDS()
> > drm/i915/pciids: add INTEL_IVB_IDS()
> > drm/i915/pciids: don't include WHL/CML PCI IDs in CFL
> > drm/i915/pciids: remove 11 from INTEL_ICL_IDS()
> > drm/i915/pciids: remove 12 from INTEL_TGL_IDS()
> > drm/i915/pciids: don't include RPL-U PCI IDs in RPL-P
> >
> > arch/x86/kernel/early-quirks.c | 19 +++---
>
> Bjorn, ack for merging this via drm-intel-next?

Sorry, I had ignored this because I didn't think it affected any PCI
stuff. This is fine with me:

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

But since you asked :), I'll gripe again about the fact that this
intel_early_ids[] list needs continual maintenance, which is not the
way things are supposed to work. Long thread about it here:

https://lore.kernel.org/linux-pci/20201104120506.172447-1-tejaskumarx.surendrakumar.upadhyay@intel.com/t/#u

> > .../drm/i915/display/intel_display_device.c | 20 +++---
> > drivers/gpu/drm/i915/i915_pci.c | 13 ++--
> > drivers/gpu/drm/i915/intel_device_info.c | 3 +-
> > include/drm/i915_pciids.h | 67 ++++++++++++-------
> > 5 files changed, 71 insertions(+), 51 deletions(-)
>
> --
> Jani Nikula, Intel