Re: [PATCH 0/8] drm/i915/pciids: PCI ID macro cleanups

Jani Nikula
2024-05-15T16:32:09Z

On Wed, 15 May 2024, Bjorn Helgaas <helgaas@kernel.org> wrote:
> Sorry, I had ignored this because I didn't think it affected any PCI
> stuff. This is fine with me:
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>

Thanks, pushed to drm-intel-next.

> But since you asked :), I'll gripe again about the fact that this
> intel_early_ids[] list needs continual maintenance, which is not the
> way things are supposed to work. Long thread about it here:
>
> https://lore.kernel.org/linux-pci/20201104120506.172447-1-tejaskumarx.surendrakumar.upadhyay@intel.com/t/#u

Right. I was under the impression we'd cease doing this for new
platforms, and see if we can get away with it. For example, we don't
have Meteorlake or Lunarlake there. Fingers crossed. But we probably
don't want to touch the old stuff.

Except now that I'm doing some non-functional refactoring to be able to
better reuse the macros for something else. There's a bit more coming,
please bear with me. :) I just tend to err on the side of getting the
acks than pushing away.

BR,
Jani.

--
Jani Nikula, Intel