From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D18AE3F1673; Wed, 22 Apr 2026 19:27:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776886041; cv=none; b=IBGX0o0E21tMdSDnEgRxaQnLjCthtbF3SwkRnLXFbzJLJFulNQxgv00v+1iZGLHit5FLLQTsnb5kAH7l+27Wp52JLyQf67bJrIuXqNJ+HuTYMJLTe1ynXa+uBx36PowlkJh/Mc/9WHY7K5Zo4uZD4u3nWxcii2HhU67+txQPpSM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776886041; c=relaxed/simple; bh=7zoZylwcEWMOqjuLY/70Dj7lzapBUSO1pXugxRyGOck=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TShsBIToUUMRbWy2QjEzXiQOJkk+i3Az+g8DACLPGrfx6LDGz/PHX9SGdcUKPnTW42zsPlSh+UW8lZ2Rr/j6jFYAanwwHpJChhWRPLBJ/T7onI+vzgwbiNGvFSOsxn+q2VHCZbqb0C694TBD3U1fT0liPbm+SDrb+WQR7Pc9Xkk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=eRlRX4xd; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="eRlRX4xd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776886037; x=1808422037; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=7zoZylwcEWMOqjuLY/70Dj7lzapBUSO1pXugxRyGOck=; b=eRlRX4xdocypzJwayloF71tsCbkNlepTrrk/XZTMW6AAzKXI+rLozBqa MH+0vA9fPK7dWpOei4ofzx1TaLDJ90zT5NlBvTOUqKY3qaaip3XSRhRxZ tk2sKOgNMx/23MQPr+Supll5A//Z/cT01D/V7kMnkFXLHr7fScWFlOzZA DIZGl09Pi9D6/wDndOatNho2xncXam+FE4g3JDtOmwDqeG/0DT6ODDn07 kPLjqa+ZhnsdAUvLrpLK1Fw/v4ZYlOHxXrhhlCG6n+CzZI8M71+LZZwp4 17W8jNxEEit0xG6JXLGClhuAO1m110ZZrrV/ei++lZyEyj7DOJW2yeb9T Q==; X-CSE-ConnectionGUID: g2vzcLvFTmy+2/wD9GhF/w== X-CSE-MsgGUID: 3UYQRoReTM6K/1zei7T0Kw== X-IronPort-AV: E=McAfee;i="6800,10657,11764"; a="77552847" X-IronPort-AV: E=Sophos;i="6.23,193,1770624000"; d="scan'208";a="77552847" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2026 12:27:08 -0700 X-CSE-ConnectionGUID: LWMQUImBSCWyFacSt3JrOg== X-CSE-MsgGUID: +r77+a0DSuqfO8QfU12sJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,193,1770624000"; d="scan'208";a="231402882" Received: from smoticic-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.201]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2026 12:26:55 -0700 Date: Wed, 22 Apr 2026 22:26:52 +0300 From: Andy Shevchenko To: Doug Anderson Cc: Geert Uytterhoeven , Herve Codina , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kalle Niemi , Matti Vaittinen , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Michael Turquette , Stephen Boyd , Andi Shyti , Wolfram Sang , Peter Rosin , Arnd Bergmann , Saravana Kannan , Bjorn Helgaas , Charles Keepax , Richard Fitzgerald , David Rhodes , Linus Walleij , Ulf Hansson , Mark Brown , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Shawn Guo , Wolfram Sang , linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, Allan Nielsen , Horatiu Vultur , Steen Hegelund , Luca Ceresoli , Thomas Petazzoni , Saravana Kannan Subject: Re: [PATCH v6 02/27] of: dynamic: Fix overlayed devices not probing because of fw_devlink Message-ID: References: <20260325143555.451852-1-herve.codina@bootlin.com> <20260325143555.451852-3-herve.codina@bootlin.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Apr 22, 2026 at 11:51:36AM -0700, Doug Anderson wrote: > On Wed, Apr 22, 2026 at 10:44 AM Geert Uytterhoeven > wrote: > > On Wed, 25 Mar 2026 at 15:36, Herve Codina wrote: ... > > > + if (fwnode->flags & FWNODE_FLAG_NOT_DEVICE) > > > > After commit f72e77c33e4b5657 ("device property: Make modifications > > of fwnode "flags" thread safe"), this must be changed to: > > > > if (fwnode_test_flag(fwnode, FWNODE_FLAG_NOT_DEVICE)) > > > > With this change my DT overlays are working again. > > > > I guess keeping the FWNODE_FLAG_* names, but changing their values > > from bit masks to bit numbers was probably not such a good idea, > > as it fails to catch missing conversions... > > Crud, I should have thought about that. :( Do you think it's worth it > to do a rename at this point to catch future problems? You can try locally with allyesconfig / allmodconfig and see the outcome. If there are missed cases, and their amount reasonably low, I won't bother in this case. But for the future it's kinda rule of thumb to rename when semantics changed. -- With Best Regards, Andy Shevchenko