Re: [PATCH] pci: Workaround Stratus broken PCIE hierarchy

["Rolf Eike Beer" <eike-kernel@sf-tec.de>]

> Trying [v2]....
>
>
> pci: Workaround Stratus broken PCIE hierarchy
>
> Stratus systems have a hierarchy that includes a PCIE Downstream bridge
> connected to a PCIE Upstream bridge and a PCI Downstream bridge.  The
> system
> boots with this wrong hierarchy into a crippled mode (USB doesn't work,
> network doesn't work ...).  Avoiding the Downstream bridge check in
> only_one_child() causes all the bridges to be enumerated and the system
> to function properly.
>
> Unfortunately this hardware is currently available so we should at least
> keep it functional.
>
> [v2]
> - ddutile@redhat.com requested drivers/pci/quirks.c code
> - matthew@will.cx requested that dmi_name_in_vendors() be called only once
> with a static var check
> - added a kernel parameter to enable scanning of all PCIE devices.
>
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 6f45a73..f478bd5 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -3589,6 +3589,9 @@ static int __init pci_setup(char *str)
>  				pcie_bus_config = PCIE_BUS_PERFORMANCE;
>  			} else if (!strncmp(str, "pcie_bus_peer2peer", 18)) {
>  				pcie_bus_config = PCIE_BUS_PEER2PEER;
> +			} else if (!strncmp(str, "pcie_scan_all", 13)) {
> +				printk(KERN_ERR HW_ERR "PCIE: Scanning all devices.\n");
> +				pcie_scan_all = 1;
>  			} else {
>  				printk(KERN_ERR "PCI: Unknown option `%s'\n",
>  						str);

To scan all devices isn't an error, is it? The user has requested this, so
KERN_INFO should be enough.

Eike