From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D5073AEF22 for ; Thu, 30 Apr 2026 20:49:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777582170; cv=none; b=EqhipQ2YaWG1VGoHTI66C0AB0kEinl8ZNkiYd00v9ursH2fGgLTwUBlCcJqqhW7/SU6ciFnkA/GxgdeIRU/YdI8nIPIYxKzirlEoZwXOxs5n6TdvYeWPUn0BvRqV2bWFzqYdK2FPLMCaLQ6gPKpbyepI6UojssVLYkATTd1IaI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777582170; c=relaxed/simple; bh=TriwdijzsiVRf02t1V40GPDZHZ41X/f0QJSAPNy0VeE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qK0s0k/VJxFGQoSQCPIitTfruwOniA86qXzbRkmSXI3NeTsxjBxsovJahC0j6coGXcn/a3makXL+OB7K9h16GwuR9wTxrybWip6/usjvVSKVDUj7zKgDVTv99akrgHlqVk2HbjlxUZSKbU5SESOSfoU+Oc+OF4K4hMPVInHPids= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=KwOmxEvy; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KwOmxEvy" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-35dac556bb2so1107304a91.1 for ; Thu, 30 Apr 2026 13:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777582168; x=1778186968; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Hkx4tLK7DpveuSLFftKdSSEC4NdhOfO2fjr8Ook6ULw=; b=KwOmxEvyte+LfcgxCDtgju2fh4pEy7DpIrfWtiOGatxhi1TtjaAt3XTnoyphzTEBqA dCXvIzynMUlUtkclGVZLEH5epWtYMOsJUk2eNyxt1/clLRt3m5u+KppV/2dOA7QAFmRL Fo6nhKlogVZ6EBwaeu5A/dencdStoutFY9vdRbgKUKu4WHs8oPcfR0s73ZKXdLE93LTn YSK7mMVJI6sSu0J20d1HPZ06QlkjkdvjYosbxSqHcGE2b9VxBYhxc4fV3sAMvzjVOHqA yQjlamIpe1yreuVx33K9TopCBJ2E9L/42tN7vnnuv92Pe2k5GLTsNLEfyaaN0GbHGMKR N/Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777582168; x=1778186968; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hkx4tLK7DpveuSLFftKdSSEC4NdhOfO2fjr8Ook6ULw=; b=Lh0p9ckphR8FMPyxtFNK5hYGltIlwR9fMrzgL149eo68hGV5Reu6GXPyrrDhB5fRmc f2Do7KD1GGq38nwGVhvqMzm0y/WLpfRJ0e/AGkEz6FOwN3YY/AA72yhpnLWTw9tsgePP 9KcJfEzQ02xpNFK7qvQhCP3x7RTyZwnxLrxSWoEBlCKVMlIOLxQk8jNYzlMh+U+BDE7w 0Yc6qLw3Kcj4uCXthHFOEcIkNX3Q46QecwehJWwBgugvxrh0ypZik+NcH7PJSgSFW7XY 0R6IEprxjGQJQ8JDz0ECoZmaulaZjZe/oBClsxk51/1WVS5UawVdZa+lu6nCn7rt3UyT fg2w== X-Forwarded-Encrypted: i=1; AFNElJ9BTMsDJ5SfS3EDQghvk8uifmBlO2+Kw1qZSkB05YjbN69yVy3ysUicP70BylBiwYD/0aceFv55UpA=@vger.kernel.org X-Gm-Message-State: AOJu0YxpicL8y6lLQrD0g0ZCu+2/ksqceMSWtofD5Q/g853B8BEC0daY bpfzdq1SDE2K/L7t8NsbEEODi6kPCqCRRPJrrc+D05cYg4xv+y3bUvrIdZT4VxombQ== X-Gm-Gg: AeBDievYs0qU2FhtjadE/xmtItODQQkxS8jXwAIbnWAzZfix6iW3dIIZR2SMn+wYk0B Km79nUxgrNySoONKgUIisDaV+ZbtxdaaTrm73gaPLugozgPpXtnq9HMmEQjvdruiHjr9dfKcoI3 3+8LxlUizmaUL9UsMuqs/ou+KFtBAQBCYJp0DwPpvNuCLOMWumM2l+/YOA/S3nHqPEisuUa+uPV i7zDAe6rseCjMkbn3jM1lRQW7koNcj5csAW47KQAbTSYM3i+ov9yRP6zY5RUXAYqMXOllPwHYdU cZE4g4hxsx8Cqq5W6LcB5SVMRG40X6JLAGhAxmGVV9qT57r8XrgrvH61AOahItN/lVcvK0qwjg8 08IjQikO9HC14HuHEF/XkFTIlPB8HtQKOjb+NS+7pD31I9nHh/q43JPqlXtFyUT6Teimu5FwHyJ edTYQaaKAjSq0UO550sxbn+ZFfctuY02xEtWwtYtZYHCyI2etJjfn+YhcKIi6qKsn1mqbXZCQaj uKTxA== X-Received: by 2002:a17:90b:3e4f:b0:35f:b288:8e4c with SMTP id 98e67ed59e1d1-364c30cb4f7mr4328476a91.15.1777582167388; Thu, 30 Apr 2026 13:49:27 -0700 (PDT) Received: from google.com (76.9.127.34.bc.googleusercontent.com. [34.127.9.76]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364ec00b094sm307888a91.9.2026.04.30.13.49.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 13:49:26 -0700 (PDT) Date: Thu, 30 Apr 2026 20:49:22 +0000 From: David Matlack To: Jacob Pan Cc: iommu@lists.linux.dev, kexec@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, Adithya Jayachandran , Alexander Graf , Alex Williamson , Bjorn Helgaas , Chris Li , David Rientjes , Jason Gunthorpe , Joerg Roedel , Jonathan Corbet , Josh Hilke , Leon Romanovsky , Lukas Wunner , Mike Rapoport , Parav Pandit , Pasha Tatashin , Pranjal Shrivastava , Pratyush Yadav , Robin Murphy , Saeed Mahameed , Samiullah Khawaja , Shuah Khan , Will Deacon , William Tu , Yi Liu Subject: Re: [PATCH v4 08/11] PCI: liveupdate: Require preserved devices are in immutable singleton IOMMU groups Message-ID: References: <20260423212316.3431746-1-dmatlack@google.com> <20260423212316.3431746-9-dmatlack@google.com> <20260427135625.0000413e@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260427135625.0000413e@linux.microsoft.com> On 2026-04-27 01:56 PM, Jacob Pan wrote: > On Thu, 23 Apr 2026 21:23:12 +0000 > David Matlack wrote: > > +bool pci_device_group_immutable_singleton(struct pci_dev *dev) > > +{ > > + struct iommu_group *group; > > + struct group_device *d; > > + struct pci_bus *bus; > > + int nr_devices = 0; > > + > > + group = iommu_group_get(&dev->dev); > > + if (!group) > > + return false; > This may not work for noiommu mode where we could have a null group. > Maybe I can add special case later? Yeah depending which series goes in first. But based on the other thread I am going to drop this patch from v5.