From: Frank Li <Frank.li@nxp.com>
To: Hans Zhang <18255117159@163.com>
Cc: bhelgaas@google.com, lpieralisi@kernel.org,
kwilczynski@kernel.org, mani@kernel.org, jingoohan1@gmail.com,
robh@kernel.org, s32@nxp.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 11/16] PCI: s32g: Use FIELD_MODIFY()
Date: Mon, 4 May 2026 15:12:04 -0400 [thread overview]
Message-ID: <afjvhLycxNcNFcqa@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260430162420.42839-12-18255117159@163.com>
On Fri, May 01, 2026 at 12:24:15AM +0800, Hans Zhang wrote:
> Use FIELD_MODIFY() to remove open-coded bit manipulation.
> No functional change intended.
>
> Signed-off-by: Hans Zhang <18255117159@163.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/pci/controller/dwc/pcie-nxp-s32g.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-nxp-s32g.c b/drivers/pci/controller/dwc/pcie-nxp-s32g.c
> index b3ec38099fa3..31e1169b8ab6 100644
> --- a/drivers/pci/controller/dwc/pcie-nxp-s32g.c
> +++ b/drivers/pci/controller/dwc/pcie-nxp-s32g.c
> @@ -139,8 +139,7 @@ static int s32g_init_pcie_controller(struct dw_pcie_rp *pp)
>
> /* Set RP mode */
> val = s32g_pcie_readl_ctrl(s32g_pp, PCIE_S32G_PE0_GEN_CTRL_1);
> - val &= ~DEVICE_TYPE_MASK;
> - val |= FIELD_PREP(DEVICE_TYPE_MASK, PCI_EXP_TYPE_ROOT_PORT);
> + FIELD_MODIFY(DEVICE_TYPE_MASK, &val, PCI_EXP_TYPE_ROOT_PORT);
>
> /* Use default CRNS */
> val &= ~SRIS_MODE;
> --
> 2.34.1
>
next prev parent reply other threads:[~2026-05-04 19:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 16:24 [RESEND PATCH 00/16] PCI: Use FIELD_MODIFY() to simplify bitfield operations Hans Zhang
2026-04-30 16:24 ` [RESEND PATCH 01/16] PCI: Use FIELD_MODIFY() Hans Zhang
2026-04-30 16:24 ` [RESEND PATCH 02/16] PCI/PTM: " Hans Zhang
2026-04-30 16:24 ` [RESEND PATCH 03/16] PCI/IDE: " Hans Zhang
2026-04-30 16:24 ` [RESEND PATCH 04/16] PCI/IOV: " Hans Zhang
2026-04-30 16:24 ` [RESEND PATCH 05/16] PCI/TPH: " Hans Zhang
2026-04-30 16:24 ` [RESEND PATCH 06/16] PCI/MSI: " Hans Zhang
2026-04-30 16:24 ` [RESEND PATCH 07/16] PCI/REBAR: " Hans Zhang
2026-04-30 16:24 ` [RESEND PATCH 08/16] PCI/CARDBUS: " Hans Zhang
2026-04-30 16:24 ` [RESEND PATCH 09/16] PCI: al: " Hans Zhang
2026-04-30 16:24 ` [RESEND PATCH 10/16] PCI: eswin: " Hans Zhang
2026-04-30 16:24 ` [RESEND PATCH 11/16] PCI: s32g: " Hans Zhang
2026-05-04 19:12 ` Frank Li [this message]
2026-04-30 16:24 ` [RESEND PATCH 12/16] PCI: tegra194: " Hans Zhang
2026-04-30 16:24 ` [RESEND PATCH 13/16] PCI: qcom: " Hans Zhang
2026-04-30 16:24 ` [RESEND PATCH 14/16] PCI: dwc: " Hans Zhang
2026-04-30 16:24 ` [RESEND PATCH 15/16] PCI: mvebu: " Hans Zhang
2026-04-30 16:24 ` [RESEND PATCH 16/16] PCI: mediatek-gen3: " Hans Zhang
2026-04-30 18:08 ` [RESEND PATCH 00/16] PCI: Use FIELD_MODIFY() to simplify bitfield operations Bjorn Helgaas
2026-05-01 14:19 ` Hans Zhang
2026-05-05 16:54 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afjvhLycxNcNFcqa@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=18255117159@163.com \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=s32@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox