From: Pranjal Shrivastava <praan@google.com>
To: iommu@lists.linux.dev, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, Will Deacon <will@kernel.org>,
Joerg Roedel <joro@8bytes.org>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Baolu Lu <baolu.lu@linux.intel.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Kevin Tian <kevin.tian@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Samiullah Khawaja <skhawaja@google.com>
Subject: Re: [PATCH v9 0/4] iommu: Standardize ATS robustness and state tracking
Date: Fri, 3 Jul 2026 13:46:04 +0000 [thread overview]
Message-ID: <ake9HIb60em50WaC@google.com> (raw)
In-Reply-To: <20260615235037.259909-1-praan@google.com>
On Mon, Jun 15, 2026 at 11:50:33PM +0000, Pranjal Shrivastava wrote:
> The primary motivation for this series is an ATS state mismatch observed
> under heavy load (via iova_stress). A failure in pci_enable_ats() leaves
> IOMMU drivers like arm-smmu-v3 with inconsistent state leading to PCI core
> warnings during device detach.
>
> While David's recent work [1] addressed a discovery race for specific
> quirked devices by moving them to the HEADER phase, gaps remained
> regarding how Virtual Functions (VFs) inherit state from their Physical
> Functions (PFs). Specifically, pci_ats_supported() did not account for
> PF-level quirked status, and pci_prepare_ats() lacked STU validation for
> VFs.
>
> Based on discussion with Jason and Baolu in v3/v5, it was decided that the
> IOMMU drivers should explicitly check pci_ats_supported() before calling
> pci_prepare_ats(). To enforce this, pci_prepare_ats() now noisily checks
> for support via WARN_ON(). Furthermore, the device probe should fail if
> pci_prepare_ats() fails. Since these early gates preclude software
> configuration errors, any remaining failure during pci_enable_ats() is
> treated as a kernel bug.
>
> Following the discussion with the community, the driver-specific series
> have been posted separately:
>
> - Intel IOMMU fixes reported by Sashiko [2]
> - Refactors for AMD IOMMU [3]
>
> [1] https://lore.kernel.org/linux-pci/20260403222750.1215002-1-dmatlack@google.com/
> [2] https://lore.kernel.org/all/20260531170254.60493-1-praan@google.com/
> [3] https://lore.kernel.org/all/20260601134204.2150602-1-praan@google.com/
>
> [v9]
> - Collected R-b tags from Bjorn, Jason, Nicolin & Sami
> - Folded in the dev_err into the WARN for arm-smmu-v3
>
[...]
> Pranjal Shrivastava (4):
> PCI/ATS: Ensure pci_ats_supported() is PF-aware for VFs
> PCI/ATS: Validate STU for VFs in pci_prepare_ats()
> iommu/arm-smmu-v3: Standardize ATS enablement failure reporting
> iommu/vt-d: Fail probe on ATS configuration failure
>
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 9 +++++++--
> drivers/iommu/intel/iommu.c | 15 ++++++++++++---
> drivers/pci/ats.c | 13 ++++++++++---
> 3 files changed, 29 insertions(+), 8 deletions(-)
>
>
> base-commit: 6666bde33b83cb4fc9b1f7ba6a3471479f76ce72
Hi Joerg / Will,
Gentle ping on this, please LMK if anything else needs to be done for
this seris?
Thanks,
Praan
prev parent reply other threads:[~2026-07-03 13:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 23:50 [PATCH v9 0/4] iommu: Standardize ATS robustness and state tracking Pranjal Shrivastava
2026-06-15 23:50 ` [PATCH v9 1/4] PCI/ATS: Ensure pci_ats_supported() is PF-aware for VFs Pranjal Shrivastava
2026-06-16 0:03 ` sashiko-bot
2026-06-15 23:50 ` [PATCH v9 2/4] PCI/ATS: Validate STU for VFs in pci_prepare_ats() Pranjal Shrivastava
2026-06-15 23:58 ` sashiko-bot
2026-06-15 23:50 ` [PATCH v9 3/4] iommu/arm-smmu-v3: Standardize ATS enablement failure reporting Pranjal Shrivastava
2026-06-15 23:58 ` sashiko-bot
2026-06-15 23:50 ` [PATCH v9 4/4] iommu/vt-d: Fail probe on ATS configuration failure Pranjal Shrivastava
2026-06-15 23:58 ` sashiko-bot
2026-07-03 13:46 ` Pranjal Shrivastava [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ake9HIb60em50WaC@google.com \
--to=praan@google.com \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=skhawaja@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox