From: Lukas Wunner <lukas@wunner.de>
To: Max Lee <max.lee@canonical.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, acelan.kao@canonical.com,
mani@kernel.org, helgaas@kernel.org, kaihengf@nvidia.com,
victorshihgli@gmail.com, pandoh@google.com
Subject: Re: [PATCH v3] PCI: Disable ASPM L0s for Realtek RTS525A
Date: Mon, 6 Jul 2026 11:41:19 +0200 [thread overview]
Message-ID: <akt4P2C8vAHJzePv@wunner.de> (raw)
In-Reply-To: <20260706025358.516607-1-max.lee@canonical.com>
On Mon, Jul 06, 2026 at 10:53:58AM +0800, Max Lee wrote:
> The Realtek RTS525A PCIe card reader reports an AER Correctable Replay
> Timer Timeout storm when ASPM L0s is enabled on its link. On an affected
> HP ZBook Power 16 inch G11, the Root Port received tens of millions of
> AER interrupts from the RTS525A even when the rtsx_pci driver was
> blacklisted and the endpoint was not enabled by a driver.
>
> Testing with OS-native AER control showed that disabling only L0s on the
> RTS525A link stops new AER interrupt and counter growth while leaving L1
> enabled. Disabling L1, L1 substates, or Clock PM alone did not stop the
> storm.
>
> Prevent the broken L0s configuration by removing L0s from the RTS525A
> advertised ASPM capability. This avoids enabling the non-working ASPM
> state instead of masking the resulting AER Replay Timer Timeout reports.
>
> Signed-off-by: Max Lee <max.lee@canonical.com>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
Cc: stable@vger.kernel.org
Thanks for your great analysis in:
https://lore.kernel.org/r/CA+YcyLw0HpR1Dnz-mOL1Ryym89ytc=1a_Ri9buMt3at-9mib+g@mail.gmail.com/
In fact a quick Google search finds other reports of ASPM issues with
this card reader. This one is for Linux and talks about Receiver Errors
with RTS525A which are fixed by pcie_aspm=off, a more targeted fix was
apparently not developed:
https://github.com/pop-os/pop/issues/3775
And another one for macOS specifically mentioning non-working L0s on
RTS525A:
https://github.com/5T33Z0/OC-Little-Translated/blob/main/Content/04_Fixing_Sleep_and_Wake_Issues/Setting_ASPM_Operating_Mode/README.md
It looks like this product just doesn't support L0s and the vendor
neglected to set the ASPM Support bits in the Link Capabilities Register
correctly.
Thanks,
Lukas
next prev parent reply other threads:[~2026-07-06 9:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 3:23 [PATCH] PCI: Mask Replay Timer Timeout for Realtek RTS525A Max Lee
2026-05-28 3:41 ` sashiko-bot
2026-06-10 2:47 ` [PATCH v2] " Max Lee
2026-07-01 6:27 ` Manivannan Sadhasivam
2026-07-01 20:42 ` Bjorn Helgaas
2026-07-02 5:10 ` Lukas Wunner
2026-07-02 7:06 ` Max Lee
2026-07-02 14:42 ` Lukas Wunner
2026-07-06 2:34 ` Max Lee
2026-07-02 8:08 ` Manivannan Sadhasivam
2026-07-06 2:53 ` [PATCH v3] PCI: Disable ASPM L0s " Max Lee
2026-07-06 3:04 ` sashiko-bot
2026-07-06 9:41 ` Lukas Wunner [this message]
2026-07-06 10:20 ` Manivannan Sadhasivam
2026-07-07 2:15 ` [PATCH v4] " Max Lee
2026-07-07 2:20 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akt4P2C8vAHJzePv@wunner.de \
--to=lukas@wunner.de \
--cc=acelan.kao@canonical.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=kaihengf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
--cc=max.lee@canonical.com \
--cc=pandoh@google.com \
--cc=victorshihgli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox