From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Linux PCI mailing list <linux-pci@vger.kernel.org>
Subject: Re: could the [x86] Kconfig content for PCI be cleaned up at all?
Date: Sun, 18 May 2014 03:14:32 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.11.1405180307470.10223@localhost> (raw)
In-Reply-To: <CAErSpo6jn1gG=s9Vaz0_Lvf-ZKi=1QUz0WRZ55St--LBOUSZ7Q@mail.gmail.com>
On Sat, 17 May 2014, Bjorn Helgaas wrote:
> On Sat, May 17, 2014 at 5:29 AM, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> >
> > digging through the current PCI code and Kconfig files and it
> > seems like some of that could be made simpler, but i'm willing to
> > be convinced otherwise.
>
> I'm sure it could be cleaned up, and it would be great if you did!
>
> I don't know the reason why all the arches source
> drivers/pci/pcie/Kconfig directly; it seems like that should be done
> from drivers/pci/Kconfig.
that's what i thought, but i'll look more closely to see if there's
some subtlety there.
at the very least, i can submit a patch for both:
* .../pci/Kconfig
* .../pci/pcie/Kconfig
that removes all the extraneous dependencies on PCI and PCIEPORTBUS,
respectively, and just wraps the files in a single "if" condition,
unless someone has a reason why that wouldn't work. you know, along
the lines of acpi/Kconfig and many others:
menuconfig ACPI
bool "ACPI (Advanced Configuration and Power Interface) Support"
... snip ...
if ACPI
... big snip, entire rest of file ...
endif # ACPI
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
next prev parent reply other threads:[~2014-05-18 7:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 11:29 could the [x86] Kconfig content for PCI be cleaned up at all? Robert P. J. Day
2014-05-17 17:31 ` Bjorn Helgaas
2014-05-18 7:14 ` Robert P. J. Day [this message]
2014-05-19 6:59 ` Robert P. J. Day
2014-05-19 13:17 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.11.1405180307470.10223@localhost \
--to=rpjday@crashcourse.ca \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).