* Re: x86: runtime waring in pcibios_fwaddrmap_lookup
[not found] ` <alpine.SOC.1.00.1205131811590.7097@math.ut.ee>
@ 2012-05-14 20:21 ` Bjorn Helgaas
2012-05-14 20:53 ` Meelis Roos
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Helgaas @ 2012-05-14 20:21 UTC (permalink / raw)
To: Meelis Roos; +Cc: Myron Stowe, Linux Kernel list, Jesse Barnes, linux-pci
On Sun, May 13, 2012 at 06:15:18PM +0300, Meelis Roos wrote:
> > > Thanks for the quick response Meelis (unlike myself; I've been consumed
> > > with a hard deadline task recently - sorry).
>
> Not so quick this time - I had to replace the HDD and then recreate the
> failing config. Took 2.4-rc7 as a base. This gives us another data point
> - it does not warn on SMP but warns only on UP.
I think that's the critical point; thanks for mentioning it :)
The following patch should fix it. Can you confirm?
commit d7d1398aa087445ce04a1b1d45c4de7485590f57
Author: Bjorn Helgaas <bhelgaas@google.com>
Date: Mon May 14 12:01:26 2012 -0600
x86/PCI: only check for spinlock being held in SMP kernels
spin_is_locked() is always false on UP kernels: spin_lock_irqsave() does no
locking, so we can't tell whether the lock is held or not. Therefore,
this warning is only valid for SMP kernels.
Reported-and-tested-by: Meelis Roos <mroos@linux.ee>
CC: Myron Stowe <myron.stowe@redhat.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
diff --git a/arch/x86/pci/i386.c b/arch/x86/pci/i386.c
index 831971e..dd8ca6f 100644
--- a/arch/x86/pci/i386.c
+++ b/arch/x86/pci/i386.c
@@ -57,7 +57,7 @@ static struct pcibios_fwaddrmap *pcibios_fwaddrmap_lookup(struct pci_dev *dev)
{
struct pcibios_fwaddrmap *map;
- WARN_ON(!spin_is_locked(&pcibios_fwaddrmap_lock));
+ WARN_ON_SMP(!spin_is_locked(&pcibios_fwaddrmap_lock));
list_for_each_entry(map, &pcibios_fwaddrmappings, list)
if (map->dev == dev)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: x86: runtime waring in pcibios_fwaddrmap_lookup
2012-05-14 20:21 ` x86: runtime waring in pcibios_fwaddrmap_lookup Bjorn Helgaas
@ 2012-05-14 20:53 ` Meelis Roos
2012-05-15 23:02 ` Bjorn Helgaas
0 siblings, 1 reply; 3+ messages in thread
From: Meelis Roos @ 2012-05-14 20:53 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Myron Stowe, Linux Kernel list, Jesse Barnes, linux-pci
> > > > Thanks for the quick response Meelis (unlike myself; I've been consumed
> > > > with a hard deadline task recently - sorry).
> >
> > Not so quick this time - I had to replace the HDD and then recreate the
> > failing config. Took 2.4-rc7 as a base. This gives us another data point
> > - it does not warn on SMP but warns only on UP.
>
> I think that's the critical point; thanks for mentioning it :)
>
> The following patch should fix it. Can you confirm?
Yes, that fixes it, thanks!
--
Meelis Roos (mroos@linux.ee)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: x86: runtime waring in pcibios_fwaddrmap_lookup
2012-05-14 20:53 ` Meelis Roos
@ 2012-05-15 23:02 ` Bjorn Helgaas
0 siblings, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2012-05-15 23:02 UTC (permalink / raw)
To: Meelis Roos; +Cc: Myron Stowe, Linux Kernel list, Jesse Barnes, linux-pci
On Mon, May 14, 2012 at 1:53 PM, Meelis Roos <mroos@linux.ee> wrote:
>> > > > Thanks for the quick response Meelis (unlike myself; I've been consumed
>> > > > with a hard deadline task recently - sorry).
>> >
>> > Not so quick this time - I had to replace the HDD and then recreate the
>> > failing config. Took 2.4-rc7 as a base. This gives us another data point
>> > - it does not warn on SMP but warns only on UP.
>>
>> I think that's the critical point; thanks for mentioning it :)
>>
>> The following patch should fix it. Can you confirm?
>
> Yes, that fixes it, thanks!
I applied this to my "next" branch.
Bjorn
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-15 23:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <alpine.SOC.1.00.1204122238400.16365@math.ut.ee>
[not found] ` <CAErSpo6YnzywdjTTVdVEHj_E-B0ARBpZ+fiy29Rv==fO6m9-FA@mail.gmail.com>
[not found] ` <1335557685.2386.62.camel@zim.stowe>
[not found] ` <alpine.SOC.1.00.1204280819270.14507@math.ut.ee>
[not found] ` <1335905694.2386.138.camel@zim.stowe>
[not found] ` <1336430699.2427.117.camel@zim.stowe>
[not found] ` <alpine.SOC.1.00.1205131811590.7097@math.ut.ee>
2012-05-14 20:21 ` x86: runtime waring in pcibios_fwaddrmap_lookup Bjorn Helgaas
2012-05-14 20:53 ` Meelis Roos
2012-05-15 23:02 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).