Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Kees Cook" <kees@kernel.org>,
	linux-pci@vger.kernel.org, xlpang@linux.alibaba.com,
	oliver.yang@linux.alibaba.com
Subject: Re: [PATCH v1 0/2] PCI: Add pci=nobwctrl to disable the PCIe bandwidth controller
Date: Wed, 29 Jul 2026 09:01:59 +0200	[thread overview]
Message-ID: <ammlZzv7QSxLm9LC@wunner.de> (raw)
In-Reply-To: <20260729034505.469107-1-kanie@linux.alibaba.com>

On Wed, Jul 29, 2026 at 11:45:03AM +0800, Guixin Liu wrote:
> Enabling the PCIe bandwidth controller sets the Link Bandwidth Management
> Interrupt Enable (LBMIE) and Link Autonomous Bandwidth Interrupt Enable
> (LABIE) bits.  On some (typically old) platforms this has been observed to
> cause boot hangs; commit 46a9f70e93ef ("PCI/bwctrl: Disable BW controller
> on Intel P45 using a quirk") works around one such platform with a
> per-device quirk.
> 
> A per-device quirk only helps once the offending device is identified and
> a quirk has shipped, which is awkward for a boot hang since the machine
> cannot be booted to report the culprit.  The only existing escape hatch,
> pcie_ports=compat, is a blunt instrument that also disables AER, PME,
> hotplug and DPC.

Ideally we want to identify all devices that have problems if the
bandwidth controller is enabled and add quirks for every one of them.

In a sense, a command line option disincentivizes reporting and
fixing affected devices because users can just work around the problem.

Additionally, there is a general dislike in the community for
adding new command line options.

Are you seeing issues on different devices than the one that's
already been quirked?  If so, a patch to add quirks for them
would be welcome.

Thanks,

Lukas

  parent reply	other threads:[~2026-07-29  7:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29  3:45 [PATCH v1 0/2] PCI: Add pci=nobwctrl to disable the PCIe bandwidth controller Guixin Liu
2026-07-29  3:45 ` [PATCH v1 1/2] PCI/bwctrl: Add pci_bwctrl_available() Guixin Liu
2026-07-29  3:52   ` sashiko-bot
2026-07-29  3:45 ` [PATCH v1 2/2] PCI: Add pci=nobwctrl parameter to disable the PCIe bandwidth controller Guixin Liu
2026-07-29  3:50   ` sashiko-bot
2026-07-29  7:01 ` Lukas Wunner [this message]
2026-07-29  8:28   ` [PATCH v1 0/2] PCI: Add pci=nobwctrl " Guixin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ammlZzv7QSxLm9LC@wunner.de \
    --to=lukas@wunner.de \
    --cc=bhelgaas@google.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jic23@kernel.org \
    --cc=kanie@linux.alibaba.com \
    --cc=kees@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=oliver.yang@linux.alibaba.com \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=xlpang@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox