From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8CC14A2A65 for ; Fri, 4 Sep 2026 13:51:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788529873; cv=none; b=d+r9bEFYYMYZzLjkKDvUMU+cQrnX0ZBOCh9B0THab6+JTGvwixb1S8YafCvKmb9tBAOMcgS3dKKsQ0my4RIL0awifIOpCGzrg3DDGdYR1k1ASa7HQICVfPYmUcuslkjVsrEKTuTpi/m4/Nt/jnoYHm684aDAJNzF3IrozCMQLEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788529873; c=relaxed/simple; bh=z2esHt+ejmv7OQKxSE8vdxsoJaGIju5rEtZi2+jIiqI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rsTisT+FbCcTBbk35oPjFUgEbIW4YgNbb+2duzHK77vJ+UHnsQnpiughh0cAUEs5d9+GP/eIaYMGu+tkMLQkscR79dpn0BfbSOuf4ndJF1wwoFXNo2uhy1AGwb/XyrJwP2BNix1MNCUcU/LxzrJ88LfJWAkmv/05h7lhch6LCKo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F+uxlH62; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Xtl7R6p4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F+uxlH62"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Xtl7R6p4" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 684DgxBh042774 for ; Fri, 4 Sep 2026 13:51:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=Vz2jp8UAvQVC0hixBLaMAu6N bc13o3wiA7v7hXxixzI=; b=F+uxlH620Zn2HECmGPW1OIbHYSjiHPyMxqjOuLC5 FN6YSOubq4VyBqDAXNcrJVeNLNkGFS7dC8jzgE3aiEXnGbA2Nwy8Th2WAk2Otv8y nlBWVWJLejPoHjs5EJgmzgvF195gUlC1sHojuguG8tP8FDa0gWdVOjMJbjXXksnA isndiEMVLv+4od8mDkDAnBXsY/hLrmckzIwUW7KYePANDHt7UGB0VG9wg8TQerP2 hCnIg7dfayZDwu9zRzWmp654snjYsdVECMYoHA+7CHpxMYvWNXgNkW1gItJt/35q 2h7IZWDl6Yy8IV3vb+vhQCSrITOBq4tIMIqYlNm47W3nZQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gfhc9u6vn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 04 Sep 2026 13:51:10 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-93771aa0379so260756985a.1 for ; Fri, 04 Sep 2026 06:51:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788529870; x=1789134670; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Vz2jp8UAvQVC0hixBLaMAu6Nbc13o3wiA7v7hXxixzI=; b=Xtl7R6p4V3f0L9ZSi4PHjsm0IQU8hIsBirXNKtKh+jCSFSUyXGCV37x2GS+lB9ceLj 9O1Xeb/NV+0e3PRQnmBm/n5paB1XAKp41swDFENPvw4HcjUmIReUByfVkVF4bte9+MgC 5e8uRMPdYbfvs5J0uCf/d6TzypiqgS2x0nKRYscbcpnQhleVpslDC2F+mwQ60SdqJb1Q qB5jLqjZANtvyW+7YpfuHqx7Gu60SkJ2E71ubcoQWYKRjP6nHNG5pauJhQSIyu7kJNVa K6uR35f3+2Rivc2BpNbVIQakHP1gGhMDShMAFVJfa9uKL+rMu/APov5/WA4NzOHwwpNf Qm8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788529870; x=1789134670; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Vz2jp8UAvQVC0hixBLaMAu6Nbc13o3wiA7v7hXxixzI=; b=J74KGgZsDwTJ+pf2foVE6evXtALy4Zy6i4aOycWfw2Ih7IFaruG7RCGDbrm1896wcM cs1l5hO8O6mPSLMmzgVOty6mU5pEPyJxALIie3QpCCKRGwLLICsysRs0ImiToSqiCY6g 76OgX2V5NafWC2wSQjXFK9wwoCxu1PJs+COvXXdByxIelrjus6HNTRZAFM9Tdcl4qZ1/ LH4x1FBZy+nGdmlQiP+Jl0/cwnQewbn6/UZiLnxF8kaifoTTzjwl79MYj3k3u/Bolanj XfIYFLQQQs76obOBIhuBPoldVRojqxJFY8rbtYtxVSBqsMdZsxGhdbK/D6eqolct8UQk CZJg== X-Forwarded-Encrypted: i=1; AKwUvBxpBQ62iYw065TCzN8rJfMufgL5dHT3XuRhDHgu5AufWQuNNJSOkOWmppmQPgS0z+uaMIYYCb19OCY=@vger.kernel.org X-Gm-Message-State: AFuF++m7TwJkcQ0LJTwga7Y01NnHXUx9DC2vlVF/fLrps1Qbxr+hDDJb f7pCwUVDRK1V8xWFe5GUqjqPnrJ7j7JMcCStyWcT3ALhTWUjcR6vGKJ7HzxbOg/AwynYVeSdL94 qzYYXwtpwOo5cdafg7353XO33sc9GjbwYJ+jPMbSRQ/keDn1ulGheBH+fPPM1mFg= X-Gm-Gg: AYBFou1DcVmmACeYdsq1881FdgMkix0S7JiQeShdANccXbWAWRNNKCQ7fsWo96Cpm+u WMr0s7YQItLq7yGSsrTHJNLpjKQ3uXplBmwxn4O0QWKkOt04Mkro7m00SexJQtTmd13WtmxWZI6 zJnAeMKbL01CkAL6/tSbFqA10DEGbAeeuvy3sXbjAvkjvgXWBnU6iiRjs6qlgEiPXw4TxZiHvPV Y68t5e6whjSSnu31b++sjZ3PlU5xCzcPu+lbhFE8Nis4nJHcb9nGMqCG6SOOeLV1l2Mx3bWJF0K LQ//3r6XJdUkHsV36qn5aroIrMUrRXhpd9AEjo+wbJkjBl7DVeyD9moBNBgd4R5z3j1HwTyfNJT C2hVimvpPkSF4mw== X-Received: by 2002:a05:620a:4493:b0:939:31b5:4e08 with SMTP id af79cd13be357-939800fc582mr562396685a.0.1788529869689; Fri, 04 Sep 2026 06:51:09 -0700 (PDT) X-Received: by 2002:a05:620a:4493:b0:939:31b5:4e08 with SMTP id af79cd13be357-939800fc582mr562389585a.0.1788529869081; Fri, 04 Sep 2026 06:51:09 -0700 (PDT) Received: from localhost ([188.216.77.92]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-485883acd33sm6437481f8f.18.2026.09.04.06.51.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2026 06:51:07 -0700 (PDT) Date: Fri, 4 Sep 2026 15:51:06 +0200 From: Lorenzo Bianconi To: Manivannan Sadhasivam Cc: Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chaitanya Chundru , Linus Walleij , Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , Michael Walle , Alex Elder , Daniel Thompson , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 3/5] PCI/pwrctrl: tc9563: add GPIO auxiliary device support Message-ID: References: <20260903-pci-tc9563-aux-v2-0-34c625b542c1@oss.qualcomm.com> <20260903-pci-tc9563-aux-v2-3-34c625b542c1@oss.qualcomm.com> <3nlsilckqt673fs2qikpnniius7gxwxfit2xbwldp5ac74objo@yr5yhp267f3r> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vgq1jszOkLu1v/d0" Content-Disposition: inline In-Reply-To: <3nlsilckqt673fs2qikpnniius7gxwxfit2xbwldp5ac74objo@yr5yhp267f3r> X-Authority-Analysis: v=2.4 cv=afdRWxot c=1 sm=1 tr=0 ts=6a9accce cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=WpTaRW6qxYHRGzLzQsVYzg==:17 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=Pk19pllHZqhTeWfk69IA:9 a=QEXdDO2ut3YA:10 a=p8WpEMGEU3HvF4N80_gA:9 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA0MDEyNCBTYWx0ZWRfX9EwbyxUblzN8 iT1bC3BuUaddZAt/4duii/cgKwLVCe34C7dxOi1UXiyubTCBw34UTVr2VRt0CxjeouDoAqUACJK M4tkvdHTbIuaJrEt+hQpQxdPnnDRhJ0UO0LXfaoraqshi7+r2D1/Zym9obrUrwvCpOdc7OH9Gcu Xqvufz89joKkCAeW/w6PIvpqX98Eb+a6CuTHho+MHdreDmPdNb+KcgQa2rBgcRkuYUexBNGQCwm AWgF9KaRf761QnX5kJ6CwEvFEBQ1GpEGMcVp1ibwW4Ht9pMWcHKWeTiZBhtZsAozKdbGsGHmPvY /Vie4nT/zgsjupnAsHVRfyGf2ewYQeClkR7KGVuIcMKOh0ZWZfhaUzYODKO2hFsdk8GHWSQOTVJ E19UNkZ9bbbU0A0P3mVFKOrJiprJW2Izbx6EbbTb4Y3Rd3LtijBvK9PBkmevYDc3OEM4Eg2prbJ 3rlp8zJqXy8uanW7N6A== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA0MDEyNCBTYWx0ZWRfX0tv4eaRfx0W3 Ej8eSB68SgAc81/U9yIz13yw6lP7Saj0wOExiwDYKyel3N7Ye3t5spLkt+UL3bckOCs2+SGa2/+ NhKs/wicGOMavVSYai6C4z3cTsWbAqU= X-Proofpoint-ORIG-GUID: eOjMKhkCCIETzWkyEpEKoq4sJ3h-7grN X-Proofpoint-GUID: eOjMKhkCCIETzWkyEpEKoq4sJ3h-7grN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-04_04,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 malwarescore=0 bulkscore=0 spamscore=0 priorityscore=1501 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609040124 --vgq1jszOkLu1v/d0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > On Thu, Sep 03, 2026 at 09:52:59AM +0200, Lorenzo Bianconi wrote: > > The TC9563 embeds a GPIO controller used for per-port reset signals. > > Create an auxiliary device for it so the gpio-tc9563 driver can > > register the GPIO chip and enable DT-based GPIO lookups. Pass the > > tc9563 regmap to the auxiliary device as its platform data. > >=20 > > The downstream port DT parsing loop gains an of_node_is_type() filter > > to skip non-PCI child nodes such as the GPIO controller node. > >=20 > > The pwrctrl driver does not wait for the GPIO chip to be probed. The > > per-port reset GPIO lookup, returning -EPROBE_DEFER until the chip is > > registered, is added in the next patch. > >=20 > > Select AUXILIARY_BUS and GPIO_TC9563 in Kconfig. > >=20 > > Signed-off-by: Lorenzo Bianconi >=20 > One comment below. With that addressed, >=20 > Reviewed-by: Manivannan Sadhasivam >=20 > > --- > > drivers/pci/pwrctrl/Kconfig | 1 + > > drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c | 80 ++++++++++++++++++++++++= ++++++-- > > 2 files changed, 78 insertions(+), 3 deletions(-) > >=20 > > diff --git a/drivers/pci/pwrctrl/Kconfig b/drivers/pci/pwrctrl/Kconfig > > index 1952ab4f29b6..38aab596aa04 100644 > > --- a/drivers/pci/pwrctrl/Kconfig > > +++ b/drivers/pci/pwrctrl/Kconfig > > @@ -29,6 +29,7 @@ config PCI_PWRCTRL_TC9563 > > select PCI_PWRCTRL > > default m if ARCH_QCOM > > depends on I2C > > + depends on GPIO_TC9563 > > select REGMAP_I2C > > help > > Say Y here to enable the PCI Power Control driver of TC9563 PCIe > > diff --git a/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c b/drivers/pci/pwr= ctrl/pci-pwrctrl-tc9563.c > > index b0d8912690a2..6df512d78b54 100644 > > --- a/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c > > +++ b/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c > > @@ -4,11 +4,13 @@ > > */ > > =20 > > #include > > +#include > > #include > > #include > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -20,12 +22,10 @@ > > #include > > #include > > #include > > +#include > > =20 > > #include "../pci.h" > > =20 > > -#define TC9563_GPIO_CONFIG 0x801208 > > -#define TC9563_RESET_GPIO 0x801210 >=20 > These definitions are still used in this patch and only removed in 4/5. ack, I will fix it in v2. Regards, Lorenzo >=20 > - Mani >=20 > --=20 > =E0=AE=AE=E0=AE=A3=E0=AE=BF=E0=AE=B5=E0=AE=A3=E0=AF=8D=E0=AE=A3=E0=AE=A9= =E0=AF=8D =E0=AE=9A=E0=AE=A4=E0=AE=BE=E0=AE=9A=E0=AE=BF=E0=AE=B5=E0=AE=AE= =E0=AF=8D --vgq1jszOkLu1v/d0 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCaprMygAKCRA6cBh0uS2t rIcGAP9zc3Ril3L9NF5G0q0LUKY8UyK71zNC8Zp1ulXf2XCNHwEAule4t5jrNiNI 0qW3qeVwe8KvQMl3ZvwIJZSfsBr5nAM= =5qQo -----END PGP SIGNATURE----- --vgq1jszOkLu1v/d0--