Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Patryk Janik <patrykjanik1710@gmail.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, alex@shazbot.org,
	kvm@vger.kernel.org
Subject: Re: [PATCH RFC] PCI: Don't restore state of a device whose config space is inaccessible
Date: Sun, 25 Oct 2026 17:58:05 +0100	[thread overview]
Message-ID: <at41Hdy8ATMj9LRC@wunner.de> (raw)
In-Reply-To: <CAOz=NNVc4C3aSC+VL59V31==P_sfgCkjSK+nG3LAByUF84OVVQ@mail.gmail.com>

On Sun, Oct 25, 2026 at 05:37:39PM +0100, Patryk Janik wrote:
> After a failed reset, vfio_pci_core_disable() unconditionally calls
> pci_restore_state(). When the device did not come back (FLR timed out,
> config reads return ~0), restoring state walks the extended capability
> list and rewrites the whole config space. Every one of those accesses
> stalls for a completion timeout, so the host spends minutes in soft
> lockups instead of failing fast.

Config Space Writes are Posted Requests.  There are no Completions
sent in return and consequently no Completion Timeout is observed.
So the above paragraph doesn't really make sense.

> - "PCI: Avoid FLR for NVIDIA 5090 GPU" (linux-pci, 2026-04-16), where the
>   underlying FLR failure was described as a known device firmware defect.

I assume you're referring to:

https://lore.kernel.org/r/20260416070707.3242381-1-yuan.gao@ucloud.cn/

The outcome was that there's a firmware fix available and a quirk
should at least differentiate between good and bad firmware.
Or the fix is to update the firmware and then we don't need a quirk.

Thanks,

Lukas

  reply	other threads:[~2026-10-25 16:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-25 16:37 [PATCH RFC] PCI: Don't restore state of a device whose config space is inaccessible Patryk Janik
2026-10-25 16:58 ` Lukas Wunner [this message]
2026-10-25 17:52   ` Patryk Janik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=at41Hdy8ATMj9LRC@wunner.de \
    --to=lukas@wunner.de \
    --cc=alex@shazbot.org \
    --cc=bhelgaas@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=patrykjanik1710@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox