From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.50 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793059276; b=M3Ow9ialpKitHcxRJFKKLahykDOI8rQR9HlbF7NJZQCTgDPTANoK0s2zz15mEojJx/Kn 7s1bt08lhocABATevv6V3Zau62Z3BdPuHV4+t7hF4XxqCc4xl1/TV8hUcBHh+nHAgA4v6 1LoOfpTxtlb43ccbd7e7hb5B3IeQ2AIpEUgb4t5PO1lEArztFX6pR9xqfoXXy58S2DrZ8 0eYLOlYXZhXJW6sWqSHy9bAbbLe6zdR+kd07RxPTqR9zHKhWcIG1DVHIytU7ZjUDSfhV/ SrxQGvgXRkq+vvNXOM9OypS81zxoayPmQRbN+fY8m5Qyf/NI0XIE/Kr1uRKNzwenEjQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793059276; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=ixKouDoUlCLHB71PytJx4w1v0AUAxSqI48/quFxSDg4=; b=wCbvl/SWdDtn/hbi+U/5/FfQDViHulDpBRvwckYxexmmVtYXdcX2Ys3cqh8p6xJ3rLEr JQR+x13twePn9LuYUcFc1AtpEVlaejl41Dbnfkr5/ZefdNN2arto5UYbaA2oAgpeLEzkI BWvc9DHvnXYyQ4hi4Qhunt3+v/mHcSClS+ETMqLNmk20wT2Fdd/cZooZ69LELpRcLVVeG pFJ9YLPc/RMPtQTN/KjG8X0N2JjKpfz+n3rv1TMzVhBYsvlV1q0TCHhZO28n7q7uTDCYX y5Fb+/QoDw7tM2zEyrJlQIafJm5caoM6k5ciQaYqr0EVZPXixkzUiVBiOgweiocny2g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=Vhs5p+fb; arc=none smtp.remote-ip=209.85.216.50 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CD20606A31F for ; Tue, 27 Oct 2026 00:01:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 1CD20606A31F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=Vhs5p+fb Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-3ada4c06b7bso1691820a91.2 for ; Mon, 26 Oct 2026 17:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1793059275; x=1793664075; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ixKouDoUlCLHB71PytJx4w1v0AUAxSqI48/quFxSDg4=; b=Vhs5p+fbS6ae+l/V72p15FTxjt8th/Pt4+vhSDsaWCBVIhu2VWTSEEwme6W2CrRIIt cm87wM+c/ZRZC3L1HetmJmH1r+zVfT3MtnIynEH0k4t8oPu8slybgWLsNI0r3ACWpJIJ SmsXQWzbCod8Z3Gizsh+Y0Srp2XHy6jaVfadtmBorwjvPBXoJVhFtE9owsQi57MQebug UPCpLmXOjD6ZYp43TKFvRhqJzIcLFzqb/gvvX41zqbVT8EEp/KexvctLrQKvA5Jusvov k/xKcC5W1T9FavAmx3V7rmvKGZP/DeQ3/hKM/asq8UvkuR84O8G8HuKh6SgVoVDWdyof Bxxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793059275; x=1793664075; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ixKouDoUlCLHB71PytJx4w1v0AUAxSqI48/quFxSDg4=; b=zg+9kifRc9dYAvnv8aGMQsjlAfFEEFOXGPHyWxhgHFwmSCxCljpEPcK60v7zNQHsC4 iL5XV/hWMy4gq1XN+8yV/W37bm+1tq54USh5P+gIQtnPx0ps7lOsOypmuXLxwaEawSi7 O9jyq1iskAqetiWMqzHCXfvjCp0dZ6VBKH77SRD9FjQd55Cq4WMO5z3afUIjyE4M3rjd SkTR5chZzg7H7o3Q9alQiKHbVoIF78grS43r+ntRdarFeLD7Hdyj3Hm/g2s7GtSyA26I WMFnEKFN5VJQaGYBHpvfS3oPhlCOuSuf1Gk/WhJdtNOnlv6yHyVhvS0KuSNe3Y8xc+Y5 gcZw== X-Forwarded-Encrypted: i=1; AKwUvByqhj6wBcM8yK3VcTA4ueDol758WlzGgYppoY83buOajzsVR5sPnKBDnSgiR+oQZvCQOrOCy1obVuk=@vger.kernel.org X-Gm-Message-State: AFq9FYIAq3WRuwoFrxc/ulz871KlNal0LC/irEFpRZTGPabLWZfvMM+D YlFIpYLkmdjtcg8QULVhTmXNFhmqr3GIISJ6Qv4aeDnX/2b5ISEOneh+xIIrT1HT+w== X-Gm-Gg: AYBFou0uAgaJrsYNa7HagmhMM6xeNZ/71Js3EfTNMe2e+0/ReiXv+EG+cb+3VXtspoe NvXsNs9N40fR+HSXSXh6PMtBLZtm1u7/413heSZIx8FN2kFafYyjblIlseAQnk7qfaXEf10su/w t7CUI4M8U/d3SzbGdHv1S8sYDyk3rC5x8TbCh3QJAVIfWqpMPT7hNso2QW2fwPQmtAo1pnye+LF OVIifEjxLj25M5xHRNS23+1G2pLSQInMDlGoZnIocn51cm4dJ42xK1Z+aFw/55W6R0FDff9Df74 m3hw7lGWLsC1u08K5SmpbHHK96g8xYT7nuqeu1bjHGjLUt5rndItlZRAYNtzqZKoDwTp5gwXtSC O4XQO30SAvlu3kcKkjmEO21lT80GWdc3KlPvszZPqkN0ojtRshg7EZzMCRjknzL5hKx8LOmyqgM KgGtcPD31VBmrkzYXQTYFPHvKepe6MQKoddhSnrbUtb4lyQPiPLrtIQJFoaoJnuW4D4hgJwwtAd UYT75vpqsZIqMgfk/Pt+dlHkRVJ7PYarLz6eoRx+se5QOtv3BkZ/86c+AvYQyy42i0tjuPf5Muy 3/l2RGsqIiheJRYBhPM1oDtjGhliSVIXroZF+yIvNvevxJ3wKYzugd3VbEoofeGouNH/2Pc= X-Received: by 2002:a17:90b:528c:b0:3a0:e4ce:31fd with SMTP id 98e67ed59e1d1-3adead444ecmr7102022a91.10.1793059274755; Mon, 26 Oct 2026 17:01:14 -0700 (PDT) Received: from google.com (192.150.203.35.bc.googleusercontent.com. [35.203.150.192]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ae4066cf2dsm1119900a91.16.2026.10.26.17.01.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 17:01:14 -0700 (PDT) Date: Tue, 27 Oct 2026 00:01:10 +0000 From: David Matlack To: tarunsahu@google.com Cc: Andrew Morton , joro@8bytes.org, Mike Rapoport , Pratyush Yadav , maz@kernel.org, arnd@arndb.de, jgg@nvidia.com, robin.murphy@arm.com, loganodell@google.com, oupton@kernel.org, kevin.tian@intel.com, alex@shazbot.org, dwmw2@infradead.org, pbonzini@redhat.com, seanjc@google.com, will@kernel.org, Pasha Tatashin , Alexander Graf , Bjorn Helgaas , baolu.lu@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, sagis@google.com, linux-mm@kvack.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, linux-pci@vger.kernel.org, kexec@lists.infradead.org, skhawaja@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 3/4] liveupdate: Replace compatibility string with a 2-bit pair feature header Message-ID: References: <20261021152527.375070-1-tarunsahu@google.com> <20261021152527.375070-4-tarunsahu@google.com> <9huzzew0el59.fsf@tarunix.c.googlers.com> <9huzecdcghxu.fsf@tarunix.c.googlers.com> X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9huzecdcghxu.fsf@tarunix.c.googlers.com> On 2026-10-26 11:28 PM, tarunsahu@google.com wrote: > David Matlack writes: > > But looking at this again, I think the required bit is redundant. Whether > > a feature can be safely ignored is a property of the feature itself, not > > of any particular file. Every file that has a feature present will have > > the same required bit for it. The only thing that actually varies per > > file is whether the feature is present. > > The required bit is subsystem property not the per-file. e.g. memfd_luo, > it is set at compile time for a kernel. So every file will get that required > bit set. It is not per file property. > > struct u8 memfd_luo_feature_state { > [MEMFD_LUO_CORE_FEATURE] = LUO_FEATURE_REQUIRED > } Right, whether a feature is required is a static property of the feature. That's exactly why it's redundant to send it in every header. > > The required bit still has to be conveyed to the target somehow, since > > the kernel that needs it is the one that doesn't know about the feature. > > But it can be conveyed by the feature's number rather than an extra bit: > > split the flag space into required features and optional features, and > > assign each feature to one of them when it is defined. This is similar > > to the required_flags and optional_flags approach in struct pci_ser [1]. > > > > Keeping the same header shape as discussed with Pasha: > > > > struct kho_ser_hdr { > > __u32 size; /* Size of header + payload in bytes */ > > __u16 nr_required; /* Number of required feature bits */ > > __u16 nr_optional; /* Number of optional feature bits */ > > __u64 flags[]; /* Required bits, followed by optional bits */ > > }; > > > > Required feature N is bit N of flags[], and optional feature N is bit > > nr_required + N (using nr_required from the incoming header). The length > > of flags[] is DIV_ROUND_UP(nr_required + nr_optional, 64). Both spaces > > are numbered contiguously, so there are no gaps, and up to 64 features > > still fit in a 16-byte header. > > > > Each bit just means the feature is present, so the truth table becomes: > > > > Source bit Target supports Action > > --------------- --------------- ------------------------------ > > Not set - Accept: feature absent > > Optional set No Accept: ignore the feature data > > Optional set Yes Accept: use the feature data > > Required set No Reject: -EOPNOTSUPP > > Required set Yes Accept: use the feature data > > > > There is no invalid encoding left to check. > > > IIUC, I believe this will not work. > > To Communicate between source and target, We are defining a protocol, A > protocol which will be standard for all the kernel. And each bit location in > flags must have the same meaning in both the source and target kernel. > > Now in you approach, If Source kernel send feature N to target kernel, > target kernel must understand Nth bit as the same feature. Even though > the bit position in your approach is not fixed but they are fixed > relative to their starting point. I think you misunderstood the proposal. I'm not proposing to pack only the set bits, and I'm not proposing that each feature have a bit in both ranges. In my proposal, there is no such thing as "feature N", there is "required feature N" and "optional feature N". Required feature N can be found at bit position flags[N]. Optional feature N can be found at flags[nr_required + N]. In more detail: - Each feature is defined as either required or optional, once, when the feature is added. That choice is permanent. - Each feature gets exactly one bit, in its range, and that bit is always at the same position whether or not it is set. Required feature N is bit N. Optional feature N is bit nr_required + N. - nr_required and nr_optional are the number of features of each kind the source kernel knows about, not the number of bits set. They tell the target where the optional range starts and how long flags[] is. - A set bit means the feature is present in this file's payload. A clear bit means it is absent. - There is no invalid or reserved encoding to define. Each bit just means "present". - The target doesn't need a supported table. Required features are only ever appended, so it rejects any required bit at or beyond its own MEMFD_LUO_NR_REQUIRED. Optional bits need no validation; the target just checks the ones it knows about. > For the current appraoch and V3 [2]. Think the below one as msb is > required bit and lsb is feature present in payload bit. > > 00 FEATURE_ABSENT / DEPRECATED > 01 FEATURE_OPTIONAL > 11 FEATURE_REQUIRED > 10 IS INVALID (analogy: required set but feature is not present) which can > have different meaning in future if in future, a need arises to reuse this > field. In v3, 0b10 is reserved and not checked by the target. That means an older kernel will silently accept it, so the only meaning it could ever safely take on is "safe to ignore", which is what 0b01 already means. A reserved encoding is only useful if older kernels reject it, and at that point it's no different from adding a new required feature. > Deserialization can happen per feature from right to left. without > jumping back and forth. > > Because of all these reasons, I believe current approach presented in > V3 [2] is the better. It is close to your PCI series with two flags > field for required and optional except I combined both field into one > flags. In your above approach you do have two counts but not having gaps > (which is wrong) and the way you proposed to parse with an offset is different.