From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.46 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792623741; b=w3Jx4YuySEuziHBsY24j0uR8FXsLhYW0quFR4mfc+aIqWln6QV5xJnguYSn+p+BOan46 6wydRBPAmSl0pKDPgX6w50CcT0xMP5iIIrWXo2m4JfTnBqHdl5bqwfn3d57uCJAsCbCTV XVDoAP0jhjiyyELWRPHGlcJ32FuUWcZYisGvZMvD+AM914GsQJICNTDZXaeY3G7FYGavl GU6rC+CjFKlEzY3o/YIq7M1ceCwpknTpK1qI/p2fkquV64eIPxSQ0SpMQbMYH6AI3gUzx XA0pc0sb8KnTiemazaxJDBqImC433S33r1iwd7gKirGoq7/gGfXyVTuO82e6J+4rzLw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792623741; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:Content-Transfer-Encoding: In-Reply-To; bh=Rh1ct0ynFCJmpIeBgUsQvZu9SOoIsv6E2A9BdvVwioc=; b=pIBThleR0NdjDhNbMF1urkl+NPZSCYD0CoPx0DreMU3bAT2/Lvg+BelMRsP9fjT0W/o+ QstUZ3fvzZewpCnSgvZNTVhU/WD7IHVbMrusrfeT3B/6t8z91waMEtl2/oIkFI/W1LiCr Vm//HB9317M7KqpAKXqOHcCpMOUK6VCUX2go0OuHMdCgILdwnWAlDTmTJ+ca7HmAsrHnq M8L3X+k8ex8TxLG0Nucxnkt1d3zLnxDv/JOezeHRdLeEiw+epb+sxJ3cu2l6T8j6V2GK1 L7uwYG7r5AAxlmr7wvmnokjaNhPYGjBzA7XuYJxA/SaIIwjXU9z88d16roN4e8bOrHw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=Gz4UAPgW; arc=none smtp.remote-ip=209.85.216.46 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 231A3606A31B for ; Wed, 21 Oct 2026 23:02:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 231A3606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=Gz4UAPgW Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-3ac91ac8924so725531a91.1 for ; Wed, 21 Oct 2026 16:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1792623740; x=1793228540; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Rh1ct0ynFCJmpIeBgUsQvZu9SOoIsv6E2A9BdvVwioc=; b=Gz4UAPgW8JCrFaLwd83C+NYLWBh7WrVeAbPCKceaugzzPgdHzZFvs8xQ6P/pBp/GFn kNfUOGF2clZnhpB6j0JG8SCjgqZVXBLcBt3zjTlthbSSJqXFq6YSQPByfgyeRZOMqGqY gFdiOi9nkyHnv7/S3ROeTwkHOkKFreTBDdA1soan8c5QpUTRCqhdn5fOHAdholqli5V3 I9GKiTsc4yn/PjkjUPmdhxRgJSQ5dc5azJvexnRibXFtw6B8mh1iWuZUq5JyRnh1rp+u 2icul+79TpLQiVKEnbkiuQLaITX1iVd1WDOO/mhnpqnRnK1kTPPYSni7VSdjAHbgjppR F26Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792623740; x=1793228540; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Rh1ct0ynFCJmpIeBgUsQvZu9SOoIsv6E2A9BdvVwioc=; b=r0QIR8JTLii9yzpKcP9KwVEYMwc4U05HHQrClEcjRQzRFkuuMc1oQBhXhKH35HmpXb nWZD7j0Az3f54BTBMsm6ov5cMpR+RxCiWrL191iwTPAz5YqUZCDsJWk+LUhRsrGEDb6e m6MknkWeO/+REz1JSBDNZSOMt3rI2/7MoTU8icpXeCNWVzMaTC3y0Wjx+fqq6gA5WR8d +8/ylPyxwnoXQA1R4mqIiQf7+DismjJS0KkmxALPfooetPr0TMmZpfm4kg+HNn2p96rZ Uy74eZKCTQ+FbmGHU/RWzRnb0aUoolxb3iV4E82HFagdZn/zggBlMV/W0mNu8g+44oJ9 Ko1w== X-Forwarded-Encrypted: i=1; AKwUvBw5P36hSlEfvu1HfBoGg9Ip1K4DfslVUgYkF93UZCHrCM8/HXRjXOn712uEK21O3H7EyWYAC9LFe10=@vger.kernel.org X-Gm-Message-State: AFq9FYKQtcW79mcUXeJckSpfo/wpcoMEnbn52sEM41BXlQruD1amX6dL Ocl04ckFvglO6TWpnFRVqvXeD+XHrF5LMAHmnIdDXj7DtxSDOKc4LXavTM61UPWcpg== X-Gm-Gg: AYBFou2QFHCtH+RUV2Mj63HlXe5G/0JoZKyEnXvQL1y53FVz2kDy7XrasxqZEgE3W2j s3akEkPx5/8IOYhQRuTMZY/SyVnUas+AA7aPAl/L09BRdTruuHvkZhb9tTyf3zZSX8QGyP6Dawm sraIEobOCCOX9lonSUY9llZiMB/3i+VghS7pW4jp7+3HNG2Z+T7ebNhzk/7GRlesw5WK2dLJd5W kHMpCp+vfwzRUUaS5kLUvWPbT0moJB5B78+999GML0OVbu6gKFyhqo8Rmgz3Vm/bbu0D6JZe+JZ 13AeZgiQ51e7D3ya1NOkjepZSbua84tl1QQxejmw9UMr6bNHWicxqAHQle5WeEcHBSkOg5ByMUe 4HoHgA9vYdnrZf2/+GO9oOMeYVKw4eHUnZKmyP+jVdc7u4osUTbdfIW5abl2//afmHCdZIzze9I NG37sI0Y/0PMIbX48s3iv8tTqKkbedKHB36WDpGMQAfAvcMhiukp769VjYpzQLwg5GnokvLwRpG +DSIgJBFdQ/YPBdeoPmVnPGGR0WccJBG4SLMKgCXRGwiECLMebl8IS4NpBWUxyQyWAM9QIwdrEw kolmA567yTuGWCbmrpCDy16KkguT9RnEgSSuVQ== X-Received: by 2002:a17:90b:2f85:b0:3ac:7c4d:8be6 with SMTP id 98e67ed59e1d1-3ad86d9e088mr2829501a91.40.1792623739843; Wed, 21 Oct 2026 16:02:19 -0700 (PDT) Received: from google.com (64.75.127.34.bc.googleusercontent.com. [34.127.75.64]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ada4896c4dsm1314919a91.7.2026.10.21.16.02.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Oct 2026 16:02:18 -0700 (PDT) Date: Wed, 21 Oct 2026 23:02:14 +0000 From: David Matlack To: Pasha Tatashin Cc: Tarun Sahu , Andrew Morton , joro@8bytes.org, Mike Rapoport , Pratyush Yadav , maz@kernel.org, arnd@arndb.de, jgg@nvidia.com, robin.murphy@arm.com, loganodell@google.com, oupton@kernel.org, kevin.tian@intel.com, alex@shazbot.org, dwmw2@infradead.org, pbonzini@redhat.com, seanjc@google.com, will@kernel.org, Alexander Graf , Bjorn Helgaas , baolu.lu@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, sagis@google.com, linux-mm@kvack.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, linux-pci@vger.kernel.org, kexec@lists.infradead.org, skhawaja@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 2/4] liveupdate: Select file handler by name in the preserve ioctl Message-ID: References: <20261021152527.375070-1-tarunsahu@google.com> <20261021152527.375070-3-tarunsahu@google.com> X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 2026-10-21 01:17 PM, Pasha Tatashin wrote: > On Wed, Oct 21, 2026 at 11:25 AM Tarun Sahu wrote: > > > > Currently luo_preserve_file() iterates over luo_file_handler_list and > > picks the first registered handler whose .can_preserve() callback > > returns true. When a subsystem introduces a new, backwards-incompatible > > file handler alongside an existing one for the same file type, userspace > > has no way to choose which handler preserves a file descriptor, nor can > > the kernel keep the existing rollback-safe handler as the default while > > allowing callers to opt into the new handler. > > That is not how it will work. If we are in the .can_preserve() call, > it means the user has already decided which file handlers to use. We > need to do that before any preservation happens; otherwise, we could > run into conflicts on FLBs i.e. FH of different version require > different FLBs. > > Therefore, there should be a luoctl call (i.e via a new ioctl to set > compatability) that provides the kernel with the specs file of the > target kernel we are updating to, allowing the kernel to select the > compatible file handlers. Since .can_preserve() is called when the > user is already preserving files, the specification must have already > been supplied, or the kernel should fall back to using the default > (i.e., latest) file handlers. I don't think that is the right direction. IMO the kernel should not be choosing which file handler to use, userspace should be. If userspace gets it wrong and chooses a file handler the next kernel does not support, that's on them. The problem with the kernel making a decision about file handlers is then userspace does not know what arguments to pass in. We are adding custom per-file handler arguments to PRESERVE_FD and RETRIEVE_FD. If the kernel is picking which file handler to use, say for a memfd, then userspace doesn't know which arguments to pass in. Sure you could add some method where userspace could query which file handlers are active and decide arguments based on that. But it feels backwards. I think a much cleaner solution is that userspace chooses file handler during PRESERVE_FD. I would even require it for RETRIEVE_FD so that we are guaranteed that the args the user is passing in are being sent to the right file handler. Passing to RETRIEVE_FD also opens the door to transforming across Live Update (similar to how AWS did LU from Xen to KVM as discussed at LPC). Regarding FLB conflicts, today we don't support multiple FLBs for the same global state, so there is nothing to conflict. Selecting a file handler during PRESERVE_FD doesn't change that. If we ever need to support multiple FLBs for the same global state (e.g. an incompatible change to the PCI FLB), we can add an ioctl that lets userspace select which FLB to use before preserving any files. After that, only file handlers registered with the selected FLB can be used to preserve files. PRESERVE_FD with any other file handler fails. That keeps the FLB decision up front and global, like you want, while still letting userspace pick the file handler for each fd. I'd also expect this to be rare, since FLB serialized state can use the same feature flags as everything else in this series.