From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.214.177 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792691840; b=PoBnm8HZJAly3L7K9iedgmY7lRWkxpT4JFFrdUdU80il3oVhGqQj8VEL4mxwS+QxFuxW t9ZpoibU2ZpsNWGLrpD9XPyH7SS/0I578B0uFBwkbwA03Ee3v5Mcey0u4f2E/U+LOUe1S OTwhFVTWIZo+mOxNwmWs0ZpUB0tVkseiyaTL5O86AOfAtc2JRkxuVjt1Z15foRpRL+X1g UBp3TS/jI7tHxNjsIlXqn60sv6nXbrkprQrdX0b7UbbJFeVGdwTRVixtDer3bT5VC0+ju N+s8bnQJG19bCsTUglE2Fd8vAoraaUv9mCcYAwUcYaEulwndiUR1Enwdn/8lsgs4aLA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792691840; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:Content-Transfer-Encoding: In-Reply-To; bh=8EgRcbuDfKORZQpY0utOTTMffHlpWo5to8q3utLizKM=; b=aIM0m7WwwO4G0zyN6tGOYAb4x8zBXZ3INykN5BMi/pru3TbymhvdMQJS6OGaiSFw1H6p t7OsePFhQhr0n/TrA3n0AaL09tRLkVSHWd14x2vpxiwBGHtUmaUFQ2tWUCV8PuZ7eLPT3 z1lFZ32LNccsYVAH9ggvLSTjIM0yPg/etLHMJts6iNDL7xF7zVLMoDao/R+lGvWu0yRIo /MqXvH0SUSPhUn+XFINfsIS/AZGGSfj4AA9Nc8SdgtZuoiYuidQM1rNH8zxULl3KT49uP IV3QgGqbQfef9RlQJm+sRkGhJVGp9hQXcxW2R5FczMTnIkMkjiyu7oU+de7JmbEIPvA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=WA9JyD3j; arc=none smtp.remote-ip=209.85.214.177 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78B51606A321 for ; Thu, 22 Oct 2026 17:57:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 78B51606A321 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=WA9JyD3j Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2ea4f255ba1so26455ad.2 for ; Thu, 22 Oct 2026 10:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1792691840; x=1793296640; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=8EgRcbuDfKORZQpY0utOTTMffHlpWo5to8q3utLizKM=; b=WA9JyD3j3itUY4lpXFpySPuRa1vB0WMDbXDWzbH5meWjpkiKz8M2ORcecVCQMPW6On NZxrCd95AGwvVXGo2wNHowz20f3Y7syCumDLBaj0DE3bwViDTT5DHqk7RRBBguxfrEFC goGLj86653STW4eXuGeTo93EvGmQDdLRRJIEzZ16lfAHDcKM8/HI5+n6W4OPJ/4tLkbs NwLWZ9Qgya3s6H0s1NOzrjasSmSWIHbWZXPuqlCgHOHYQ7kqcFHB+hBd3GCAARAx7j/8 p/NAIP6KlLywer4KnwCnIGba7fMS3myOBLfQuC0IKs7/P6nGO+1XrYWZk2zLW4/TS25E pqng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792691840; x=1793296640; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=8EgRcbuDfKORZQpY0utOTTMffHlpWo5to8q3utLizKM=; b=H18DPtIad8aGclab6X3ye8qVsTc9hNk+WGQCkihVAeVDk2z9Hzdox5spYn8uzhu0UN /YP1xLEMq+xieOR1NSHRbm1zmuPniTSwv7nVNre6VZpHTI/xwhY1L4rEBVoKc4D2Zd+j Ld06yu//j3+n1zQYFYwwFmSNxSxorSBTflk87rNd3mzG45U9jXdkRlKxcIfGeqd2AtJu jJFKyE1fI9VbMF3mKyYzdF/Wh+dRl8ZgDA2g0kuGeTH+7vi6LsMy4egCTvoEVaL1sGxC dOFscbZK2MjxfEMifiIoLeAEq5zn9cEO8oMlW7F1LvVi3AaSUBj6+2vYvOEKfKVb/wDr 3/Ow== X-Forwarded-Encrypted: i=1; AKwUvBxDOA0DNZYMiiFEFu7HKmR2fa0Eoy2WYdXyxctFqirwXlPMSMqQLoY8rnvNEgwl+t+v9QCKC39kI4Y=@vger.kernel.org X-Gm-Message-State: AFq9FYIbJ4keJoODLXcOzfYx9sXBK7XWap8omFeyA99IPpWBStTCBSCL xf4M6asCjIRBgC6D+SrautfA9MyjBTFHMBLMOwwBwIwoogUJLYgzugtyGSrQiQ7Oow== X-Gm-Gg: AYBFou1XsOzcYJG79aKSOCP4KkQ3fnwYWK+qraElt0uF8KsKBtUChnKYG9Q04pFIOml guSk0RSYIV0idKqgTOZNzSKONW8EEUb5eYnYajk0StZ7ogkj7riu8Da2uNGx4oQLJp1kKDx8tBn DUFiZHCZKP6skg78LxDzaHE5QxumbtNbjovWNKXxhHw+W/XGM8cNy30tVIIJj2PM/y85RdH4aD4 7Nvz6cylOBZcuwl4Da66EdEl1+9dGOM1qxLRYQBjQJ94DRoDOyt5H+sKBSuMOfutUwcMVLumwTP KAzrczYk920fSdQ6RYsgdzeII3SNoJJnk2NsPgiBYmG/A4vYz463gP1Z3kx+rd83ps/4LAu89rT WRl7Kce61ApJFcEd3y2q5FJkzngGnBv+peEaBc7ta7+t0BA1k3nFbXcI9zqvigqxHleM64vZU/X fda7Eza/QeGuCnqS31Uh0uxdH6csFZZbS2Zpsh0t3TtixSvarG+sqCyBQpPJXzaUjqSdBnJk3+c TELCpd6DsvdBW2lKqZeXGaUIlzarfdFEbRGDL7PVTcDsSFLWmf1R6P3eyfvpyvcUzRauF3jQsdS g8oBK5FFbT9hnV9Wc8nmRQ== X-Received: by 2002:a17:903:19ef:b0:2e9:61bf:6591 with SMTP id d9443c01a7336-2ea7c33be70mr1491705ad.45.1792691839016; Thu, 22 Oct 2026 10:57:19 -0700 (PDT) Received: from google.com (192.150.203.35.bc.googleusercontent.com. [35.203.150.192]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ea7b34dadbsm1687675ad.26.2026.10.22.10.57.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2026 10:57:18 -0700 (PDT) Date: Thu, 22 Oct 2026 17:57:15 +0000 From: David Matlack To: Pasha Tatashin Cc: Tarun Sahu , Andrew Morton , joro@8bytes.org, Mike Rapoport , Pratyush Yadav , maz@kernel.org, arnd@arndb.de, jgg@nvidia.com, robin.murphy@arm.com, loganodell@google.com, oupton@kernel.org, kevin.tian@intel.com, alex@shazbot.org, dwmw2@infradead.org, pbonzini@redhat.com, seanjc@google.com, will@kernel.org, Alexander Graf , Bjorn Helgaas , baolu.lu@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, sagis@google.com, linux-mm@kvack.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, linux-pci@vger.kernel.org, kexec@lists.infradead.org, skhawaja@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 2/4] liveupdate: Select file handler by name in the preserve ioctl Message-ID: References: <20261021152527.375070-1-tarunsahu@google.com> <20261021152527.375070-3-tarunsahu@google.com> X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 2026-10-21 09:14 PM, Pasha Tatashin wrote: > On Wed, Oct 21, 2026 at 7:02 PM David Matlack wrote: > > > > On 2026-10-21 01:17 PM, Pasha Tatashin wrote: > > > On Wed, Oct 21, 2026 at 11:25 AM Tarun Sahu wrote: > > > > > > > > Currently luo_preserve_file() iterates over luo_file_handler_list and > > > > picks the first registered handler whose .can_preserve() callback > > > > returns true. When a subsystem introduces a new, backwards-incompatible > > > > file handler alongside an existing one for the same file type, userspace > > > > has no way to choose which handler preserves a file descriptor, nor can > > > > the kernel keep the existing rollback-safe handler as the default while > > > > allowing callers to opt into the new handler. > > > > > > That is not how it will work. If we are in the .can_preserve() call, > > > it means the user has already decided which file handlers to use. We > > > need to do that before any preservation happens; otherwise, we could > > > run into conflicts on FLBs i.e. FH of different version require > > > different FLBs. > > > > > > Therefore, there should be a luoctl call (i.e via a new ioctl to set > > > compatability) that provides the kernel with the specs file of the > > > target kernel we are updating to, allowing the kernel to select the > > > compatible file handlers. Since .can_preserve() is called when the > > > user is already preserving files, the specification must have already > > > been supplied, or the kernel should fall back to using the default > > > (i.e., latest) file handlers. > > > > I don't think that is the right direction. IMO the kernel should not be > > choosing which file handler to use, userspace should be. If userspace > > gets it wrong and chooses a file handler the next kernel does not > > support, that's on them. > > > > The problem with the kernel making a decision about file handlers is > > then userspace does not know what arguments to pass in. We are adding > > custom per-file handler arguments to PRESERVE_FD and RETRIEVE_FD. If the > > kernel is picking which file handler to use, say for a memfd, then > > userspace doesn't know which arguments to pass in. > > It is not the kernel deciding on its own which handler to use; it is > the system admin (or host orchestrator) that configures LUO before the > LU process starts, because the sysadmin knows what kernel we are > rebooting into and the LUO specs of that target kernel. Meanwhile, the > process calling PRESERVE_FD (e.g., a VMM) only knows about its own FDs > and should not have to track target kernel serialization versions. > > Also, the PRESERVE_FD and RETRIEVE_FD arguments are uABI tied to the > FD type, not to a specific internal handler version. They are stable, > and we can expand them the same way any ioctl argument is expanded > (via size and flags), without ever shrinking or breaking them. We > should not play the game of providing completely different uABI > argument structs for different versions of a file handler. If a caller > passes a new feature in the uABI args that the currently configured > file handler version does not support, PRESERVE_FD simply returns > -EOPNOTSUPP, just like any other extensible ioctl. If we require that PRESERVE_FD and RETRIEVE_FD uAPI is stable across different file handlers for the same file type, then my concern is resolved. > More generally, we are rebooting the host into a single target kernel, > so compatibility is a session-level property, not a per-FD property. > If we need an upfront global ioctl anyway, configuring the target > compatibility upfront in one place is much cleaner than exposing FLBs > to userspace and splitting version selection between a global ioctl > and per-FD PRESERVE_FD calls. That's a good point. Ok let's not do per-FD FH selection.