From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.214.171 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793071595; b=uhFOeyaTQMjQwY7knk3JxQ1R7dQ6GEvNVlesZvmK1rd9IMmejRyI6tYIMlaoaauStBRP hqsr/R3ND4aecA5d/9Nu9umJAlrxXCaWMPnapKg1Je+qYsbdWB67t9dWU7xMnE1Wpz40z 9wYqGCvySJi5esftxiwl2Kg4VUBhD5JVJ2g/SVa0o+/4Lad+kVOqKIuGpNfwTUepJRIQZ OAOp6gkqFPu7Xae86VutZfU86DE2gTBpubgoCzPSBOapckvZeKb8oyhFmvEqVGABCN3ZI CF4uM6f9Sw2sEK0jG4hkBeGHmtWR9iswWaNsgY4WT4mGz9QuTUL5a/1Ia5mh3hjVR8A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793071595; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:Content-Transfer-Encoding: In-Reply-To; bh=mFFfrqlGcCKVNylEOU7fJD0/AGoCZ65FALqe+xT5SYA=; b=E+7ENykIBMt+fhMDFFujVXNFdNJYCdOpDGX9dARw0vl8Qws65J8kJTXLQrmslwGLj7UO KkYP/wgocCZM9JRwoYAw8RtF6/txatPG4xVDGaLq0eXUxsReEq2nyx4iCMW2kI7g1/lyc p3vq497Xvbgn8mPN8W204uocqlt6b6xfb5uF4i7mGxEhuzom7pZihiIwWcN1GK6JJV4zI ePLMR9OVN0dgF4UeU9pKRcT3cOPDFMOm2VASfQAVe+v/0426e33IOqI6Gdx1qSQek98Cy 7B4FVtt6xRh0WP6JyMIzyUr6IcTmlGrltI4ZLvuVrq/3Za5d0M5NJpwL51VYMdrKcew== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=ctJlfWTF; arc=none smtp.remote-ip=209.85.214.171 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9A6D606A31F for ; Tue, 27 Oct 2026 03:26:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E9A6D606A31F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=ctJlfWTF Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2e8fe8e343fso21456555ad.2 for ; Mon, 26 Oct 2026 20:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1793071594; x=1793676394; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=mFFfrqlGcCKVNylEOU7fJD0/AGoCZ65FALqe+xT5SYA=; b=ctJlfWTFSAAkxOyoCbcKoCYm5sa7PQkArlEMktHuP2e1Z/TnvR6B2Eci7g7zR2OP/a z0ftTAM8q4BPpA9mLqA7HjdTBvZ884W5DhsbdTWH3vGa/U34pPpFF6m6vA7CT7hUTsDE EsLODOrMJPN2eHtZKvdn0E4isOhcUZnygqt4dpaj92LFqIJK5CWBhDAgNImVyZDizUUs rq7cdrDg/cEa1tu2hYIjPpmenPe4O39G2U5GiueFTlIFLOa3FxrtMMGNsascOXMjvg1L ynwndpzHxdBStfN0SD4wcz9ESDOBFHh48Zs79R+0rBSX9WtRnYmpf0wOG+HDjrNwStrQ y0VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793071594; x=1793676394; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=mFFfrqlGcCKVNylEOU7fJD0/AGoCZ65FALqe+xT5SYA=; b=NtXNP1FW9aqyESfWaFWKNb68FvQAYu/mehsS4uvXO7N2UnOqL4aNoUlvqbmNK8oTxE pJQTF12v6s7ZKAY8tmNs4qwkRFmPmD8211PUNBFjAgZtRgK7hIE1OMTyyMG0PMBawXaU e7Wp94/yP44wIqIMQ3FF5nar/dJpKby4JWdEhwptf2xqYW0HZ4HXFwIp0Y3s0f4XzIRo HEuJe9o3YkjvXzUfKfSEWZqzzxQ2LH5Lwlen2Xxq7KfjzY33EMIckcWmju4lkeUosuEz eYYfafu+SveyT3iRzjNeh110acmTbZCuaBb4CgimuZNmiSyd3ZOE5r7ZOVrj/DvaYwEE ebag== X-Forwarded-Encrypted: i=1; AKwUvBwTBwaqEaxSGMiWkDRlqgEeQdnBWBK9ntouYeDTQfcZOplbwA1LY3v0ZYzKAHjpw93PFYF4IzHUswc=@vger.kernel.org X-Gm-Message-State: AFq9FYJrR7GuIWwOD7sVGkDOkljT1CP0xqCNfeN+6W4EJZMUpiEm4ntB PntX1IWUeTaw/TCvpHK2JLo1dZWzH4Zupo8oC/UNp9m6jnU0N/kvTNDaXEc+ectryw== X-Gm-Gg: AYBFou1l7YsUcMl9s3H4Lg8DNgKNDVU1lKTKkSlBGb9FLo22dUr+0/6QDhXGtRT2H/R +F9NrAh50UjBUOVvQjGRX8Q5hUucgnmYQPSqabd89Qv3TMVhWP0mqdbLPF2RHXEgh23gO+tboLv ZpPj2Qwon8qRon0BkwT7/sJC+GJPtjAJloO8m7j0ErXuKiEhQRZywGLl74B2Zp6wQZq6ECUAcv1 pZHJhOYHX7oPo8nHhlwYxrWOBUwRH18/o4FA9dfE7VYb+lysJ/92NdL5qvp/i8QwHBWB2VziHLu BtH6iZcdHVPtABuKLPLKDP0BTFEt8xF2Y+A1ceS9aIMEud/GaXEAiYMuO3MfrTYrrcjKT3FQIlw uaBNaFIst1+nDCF/TCPa/taz5bT4vf+i3T0uM4xFmEXzmPW4qhZQRmREplpRN1HjahE6lVzfURE vjqUxaIKmWm8z0Wxz7XGsvTcS+c5K17ZWtQcMBtqS0dfBk8txqW4thJaARd9uhb728CuEa3yhEZ 92UZh49MQ9yYvZkIzvIZTtVKfZJhMdnAj/LY+y7/aFWP3qv1fxX6raly9+DL0l6bd2F8cH/S5Bm uO07KF6q1CebZ7wno/hrjv6GrpHfQpdjsLvMcG7rTKhY+vuIQLjNPiFMw+NqW79ucyEaPHw= X-Received: by 2002:a17:902:d548:b0:2df:ad58:cf54 with SMTP id d9443c01a7336-2ea9c81ab95mr64373815ad.34.1793071593614; Mon, 26 Oct 2026 20:26:33 -0700 (PDT) Received: from google.com (192.150.203.35.bc.googleusercontent.com. [35.203.150.192]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2eae6ce0f45sm2398915ad.70.2026.10.26.20.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 20:26:32 -0700 (PDT) Date: Tue, 27 Oct 2026 03:26:29 +0000 From: David Matlack To: Tarun Sahu Cc: Andrew Morton , joro@8bytes.org, Mike Rapoport , Pratyush Yadav , maz@kernel.org, arnd@arndb.de, jgg@nvidia.com, robin.murphy@arm.com, loganodell@google.com, oupton@kernel.org, kevin.tian@intel.com, alex@shazbot.org, dwmw2@infradead.org, pbonzini@redhat.com, seanjc@google.com, will@kernel.org, Pasha Tatashin , Alexander Graf , Bjorn Helgaas , baolu.lu@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, sagis@google.com, linux-mm@kvack.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, linux-pci@vger.kernel.org, kexec@lists.infradead.org, skhawaja@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 3/4] liveupdate: Replace compatibility string with a 2-bit pair feature header Message-ID: References: <20261021152527.375070-1-tarunsahu@google.com> <20261021152527.375070-4-tarunsahu@google.com> <9huzzew0el59.fsf@tarunix.c.googlers.com> <9huzecdcghxu.fsf@tarunix.c.googlers.com> X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 2026-10-27 01:55 AM, Tarun Sahu wrote: > On Tue, Oct 27, 2026 at 1:01 AM David Matlack wrote: > > Right, whether a feature is required is a static property of the > > feature. That's exactly why it's redundant to send it in every header. > > I meant the different thing.I was saying if a Feature in a kernel will have > constant value either required or optional which is fixed at compile time. > But the same feature can have different values in two different kernels. Those would just be 2 separate features. One optional feature, and one required feature. They might use the same fields in the struct, that is fine. > Maybe a seal added in kernel version M. Later in kernel version N this seal is > deprecated and replaced by a new seal. I think this example works fine. The old seal is still a required feature. The kernel just stops marking it present and marks the new seal present instead. Retiring a feature doesn't change whether it is required, only whether the source sets it. The only thing this split doesn't allow is changing the whether a feature is required or optional after it has been introduced. But for that case we just introduce a new feature of the desired type. > > I think you misunderstood the proposal. I'm not proposing to pack only > > the set bits, and I'm not proposing that each feature have a bit in both > > ranges. > > > > In my proposal, there is no such thing as "feature N", there is > > "required feature N" and "optional feature N". Required feature N can > > be found at bit position flags[N]. Optional feature N can be found at > > flags[nr_required + N]. > > > > In more detail: > > > > - Each feature is defined as either required or optional, once, when > > the feature is added. That choice is permanent. > > > > - Each feature gets exactly one bit, in its range, and that bit is > > always at the same position whether or not it is set. Required > > feature N is bit N. Optional feature N is bit nr_required + N. > > > > - nr_required and nr_optional are the number of features of each kind > > the source kernel knows about, not the number of bits set. They tell > > the target where the optional range starts and how long flags[] is. > > > > - A set bit means the feature is present in this file's payload. A clear > > bit means it is absent. > > So For #NR number of features, We will end up using 2*NR bits which > is exactly same number of bits, V3 [2] uses. So this is just a different > way of encoding in implementation perspective. No, it's NR bits. I think this is the core misunderstanding. Let's say you have 3 features. 2 are optional. 1 is required. That gets encoded in 3 bits: nr_required = 1 nr_optional = 2 flags[0] = Required-Feature-0 flags[1] = Optional-Feature-0 flags[2] = Optional-Feature-1 > > - There is no invalid or reserved encoding to define. Each bit just > > means "present". > > What if a buggy source sets both required and optional for a feature? > That is an invalid case here. Same as 0b10 is an invalid value set by > buggy kernel. That cannot happen. A feature is either required or optional. If you have a "logical feature" that is sometimes optional and sometimes required then you would have 2 feature bits for that in flags[]. But that should be an unusual case. > > - The target doesn't need a supported table. Required features are only > > ever appended, so it rejects any required bit at or beyond its own > > MEMFD_LUO_NR_REQUIRED. Optional bits need no validation; the target > > just checks the ones it knows about. > > > > As I explained above, incase a feature is replaced by another feature, > new kernel > can support it deserialization but it will not be required from there on. So > The supported table will still be needed. The one case where a count isn't enough is if a newer kernel drops support for an old required feature entirely (e.g. removes the code that translates the old seal). That can be handled with an explicit check in the handler, or we can keep a supported bitmap. Either way, that question is independent of how the header encodes required vs. optional. Certainly in the immediate-term we can just use a count.