From: Krzysztof Kozlowski <krzk@kernel.org>
To: Richard Zhu <hongxing.zhu@nxp.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
shawnguo@kernel.org, l.stach@pengutronix.de
Cc: devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
imx@lists.linux.dev
Subject: Re: [PATCH v5 2/4] arm64: dts: imx8mq: Add dbi2 and atu reg for i.MX8MQ PCIe EP
Date: Tue, 13 Aug 2024 10:55:05 +0200 [thread overview]
Message-ID: <b1ab67c5-f465-4b0e-9104-a5b15c2fa724@kernel.org> (raw)
In-Reply-To: <cc845521-8547-4db6-b729-c4d3f1fa6125@kernel.org>
On 13/08/2024 10:54, Krzysztof Kozlowski wrote:
> On 13/08/2024 09:42, Richard Zhu wrote:
>> Add dbi2 and iatu reg for i.MX8MQ PCIe EP.
>>
>> For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the
>> driver. This method is not good.
>>
>> In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"),
>> Frank suggests to fetch the dbi2 and atu from DT directly. This commit is
>> preparation to do that for i.MX8MQ PCIe EP.
>>
>> These changes wouldn't break driver function. When "dbi2" and "atu"
>> properties are present, i.MX PCIe driver would fetch the according base
>> addresses from DT directly. If only two reg properties are provided, i.MX
>> PCIe driver would fall back to the old method.
>>
>> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
>> Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
> Stop adding fake tags. This never happened. If it happened, provide lore
> link.
>
Ah, my bad, now I see it. It's fine, sorry.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-13 8:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 7:42 [PATCH v5 0/4] Add dbi2 and atu for i.MX8M PCIe EP Richard Zhu
2024-08-13 7:42 ` [PATCH v5 1/4] dt-bindings: imx6q-pcie: Add reg-name "dbi2" and "atu" for i.MX8M PCIe Endpoint Richard Zhu
2024-08-13 8:52 ` Krzysztof Kozlowski
2024-08-13 16:32 ` Rob Herring (Arm)
2024-08-14 1:49 ` Hongxing Zhu
2024-08-31 12:59 ` Shawn Guo
2024-09-02 2:08 ` Hongxing Zhu
2024-09-04 13:38 ` Frank Li
2024-09-06 6:31 ` Krzysztof Wilczyński
2024-10-09 15:00 ` Niklas Cassel
2024-10-10 2:17 ` Hongxing Zhu
2024-10-10 9:33 ` Niklas Cassel
2024-08-13 7:42 ` [PATCH v5 2/4] arm64: dts: imx8mq: Add dbi2 and atu reg for i.MX8MQ PCIe EP Richard Zhu
2024-08-13 8:54 ` Krzysztof Kozlowski
2024-08-13 8:55 ` Krzysztof Kozlowski [this message]
2024-08-13 7:42 ` [PATCH v5 3/4] arm64: dts: imx8mp: Add dbi2 and atu reg for i.MX8MP " Richard Zhu
2024-08-13 7:42 ` [PATCH v5 4/4] arm64: dts: imx8mm: Add dbi2 and atu reg for i.MX8MM " Richard Zhu
2024-08-31 13:02 ` [PATCH v5 0/4] Add dbi2 and atu for i.MX8M " Shawn Guo
2024-09-04 9:38 ` Shawn Guo
2024-09-09 1:43 ` Hongxing Zhu
2024-09-25 3:39 ` Hongxing Zhu
2024-09-25 3:45 ` Hongxing Zhu
2024-09-25 4:03 ` Hongxing Zhu
2024-10-08 8:30 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1ab67c5-f465-4b0e-9104-a5b15c2fa724@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).