From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Li zeming <zeming@nfschina.com>
Cc: jgross@suse.com, bhelgaas@google.com, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, xen-devel@lists.xenproject.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: pci: xen: Remove unnecessary ‘0’ values from ret
Date: Fri, 14 Jun 2024 17:54:30 +0300 (EEST) [thread overview]
Message-ID: <b1c91d7e-9701-c93c-d336-3729be33f67e@linux.intel.com> (raw)
In-Reply-To: <20240612092406.39007-1-zeming@nfschina.com>
On Wed, 12 Jun 2024, Li zeming wrote:
> ret is assigned first, so it does not need to initialize the assignment.
While the patch seems fine, this description and the shortlog are
confusing.
--
i.
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
> arch/x86/pci/xen.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
> index 652cd53e77f6..67cb9dc9b2e7 100644
> --- a/arch/x86/pci/xen.c
> +++ b/arch/x86/pci/xen.c
> @@ -267,7 +267,7 @@ static bool __read_mostly pci_seg_supported = true;
>
> static int xen_initdom_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
> {
> - int ret = 0;
> + int ret;
> struct msi_desc *msidesc;
>
> msi_for_each_desc(msidesc, &dev->dev, MSI_DESC_NOTASSOCIATED) {
> @@ -353,7 +353,7 @@ static int xen_initdom_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
>
> bool xen_initdom_restore_msi(struct pci_dev *dev)
> {
> - int ret = 0;
> + int ret;
>
> if (!xen_initial_domain())
> return true;
>
prev parent reply other threads:[~2024-06-14 14:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 9:24 [PATCH] x86: pci: xen: Remove unnecessary ‘0’ values from ret Li zeming
2024-06-14 14:54 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1c91d7e-9701-c93c-d336-3729be33f67e@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=zeming@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox