From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90BB9C77B75 for ; Sat, 6 May 2023 12:03:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232237AbjEFMDL (ORCPT ); Sat, 6 May 2023 08:03:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232018AbjEFMDK (ORCPT ); Sat, 6 May 2023 08:03:10 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A79DA11561 for ; Sat, 6 May 2023 05:03:07 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2ac770a99e2so30655391fa.3 for ; Sat, 06 May 2023 05:03:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683374586; x=1685966586; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LqckTjKTfIM8bi9e0TYeW5j9DGnhHcptl3P/WnkXQ8g=; b=qP9WeiDqZYvqeBXaJ6sF23csHfH+xrYe3gSr1KeIid24zxAMGELBpts49yQ/DKvnAe tbeLxayrnT3Y4W7wk/NaMqocaRA4GtgGXwLU/1VGbMDeqVRWJOQUdkQKL/tnA50BGGm9 RibfpyPV53YIL0zGC24y1kqjIFyrCOKWi6DBN3sIof6NOGhS9cOY9fU9dh4y2W9Mvywt NLCPlKw5BrXsF8mSGdAa5ZRRIXdy/+HlrBSyezyiAF6rmXtA5s7c4jJ1vnqWUSP0g83O p+ovKVdY2GIHvv89zj3IMI7hhk3SI/rljv1WZc6wZzqsTXA7LZO4V9ey7SoM/szcvUh4 6XfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683374586; x=1685966586; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LqckTjKTfIM8bi9e0TYeW5j9DGnhHcptl3P/WnkXQ8g=; b=GRqDHQceE6j5DueFLsRsgcfkSKn6ftrihqfOrfWyA3LWbme2d7jCYzxfyLutsz/XQL b3YzK5rpzyD+oNb1jXaPHNyR/4TTvFdTPNyf49uvdM7DBdnLEfPfATBtN97BRGi5MNVR AApgnAwb9gMpZQoAUyUuj7+1c2jC3Hd9/piIe+OZzh3NeybHUxqif7m26kvW2+vig/Qg wfQeGCgfwWa5HSb2L4GT1blvB+HzKDRKA39Hp+quEIKaw0h/FU8tb2laJaL/tM0ehC9T sjo+t6BJPBLCbpKcEH5CQRqWKjOrIPo2DbbpEZr4WtFb361WdWZeAy0oMJJNetn7MUBS zrDQ== X-Gm-Message-State: AC+VfDwn8SlWudCrQ7JB1pXggXz2OOJyBMbwStYO+bSC5h3k0rLnCU0X bnY6BayawPZU9V6yJ3AbWOsS4Q== X-Google-Smtp-Source: ACHHUZ5vuD9oicd6ZZ/GS97yQDfSo/yzWgXR5BzTzQNv4q9B9n9iZWDYdKmTPiPZGKSJZAMJWoseeA== X-Received: by 2002:a2e:6e02:0:b0:2a7:f1e8:b08 with SMTP id j2-20020a2e6e02000000b002a7f1e80b08mr1229274ljc.19.1683374585927; Sat, 06 May 2023 05:03:05 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id u24-20020a2e8558000000b002a7746800d0sm359066ljj.130.2023.05.06.05.03.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 May 2023 05:03:05 -0700 (PDT) Message-ID: Date: Sat, 6 May 2023 15:03:04 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 2/8] PCI: qcom: Disable write access to read only registers for IP v2.9.0 Content-Language: en-GB From: Dmitry Baryshkov To: Manivannan Sadhasivam , lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com Cc: robh@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, steev@kali.org, quic_srichara@quicinc.com References: <20230506073139.8789-1-manivannan.sadhasivam@linaro.org> <20230506073139.8789-3-manivannan.sadhasivam@linaro.org> <56da1bb2-86ea-e31e-15f3-5eb50e3000e1@linaro.org> In-Reply-To: <56da1bb2-86ea-e31e-15f3-5eb50e3000e1@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 06/05/2023 14:44, Dmitry Baryshkov wrote: > On 06/05/2023 10:31, Manivannan Sadhasivam wrote: >> In the post init sequence of v2.9.0, write access to read only registers >> are not disabled after updating the registers. Fix it by disabling the >> access after register update. >> >> Fixes: 0cf7c2efe8ac ("PCI: qcom: Add IPQ60xx support") >> Signed-off-by: Manivannan Sadhasivam >> --- >>   drivers/pci/controller/dwc/pcie-qcom.c | 3 +++ >>   1 file changed, 3 insertions(+) > > Reviewed-by: Dmitry Baryshkov > Of course: Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry