From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CE626BFAB; Fri, 5 Apr 2024 19:02:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712343724; cv=none; b=hENaDgsGcl2pQF2Ahe/9pH3+xb4OkCMOD9MgoVxElG/zLKYuObOs8FRPLr19sbMav5n+19qsXHir4jqqK4LtBHzl0IUKl/hRq3lN81BHB+N9xsJS7gMpwPzrgKsTdMicFoZznIF+9bjS+N8w18lhUTZDGZZPOc4bHlJwc1vh2uE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712343724; c=relaxed/simple; bh=nw7V9sglSsCdlmjFtFn+xziFCoG1Ras9nyHd5YLKus4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GzKTZjiBv52oWB2TXYQIRV6WY7IO9IOwAU/VrAxTL3b7epnRlHLkTMCThv5pUPHUyePbIUpi4raKC1+uYiMySXEA9vpjm+E0afp2NalIi536tSM+8PUcGrnke0RemtBI7o+3/KBZcwUEWeqONNlngFxW8bMAi+Y+uJOsHnWirM8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fzr3RwYC; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fzr3RwYC" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a51b4032ac7so15574166b.0; Fri, 05 Apr 2024 12:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712343721; x=1712948521; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=YCydaye7fGEguRI4B7g0/kq2YLpbPdSprOIVnhlJHDQ=; b=fzr3RwYCaeTjsz+VAontHo3PxDVqCQ/oeUNbtBXplhFpspSbld8DDRm2sGzKyxItPI jFoVfAKn2gvwDaxlnQltaB3kRNV7kf1qlhSzf5UX5VQFtheAuDexKDD27xuPQ2Q6nB3b L2CWU7ZL7DNexarkCXXSkNGqK5UtA+usVDLrNQovU6EfA/gMlreAuj8P5Aa+wE8XG8ue Bvla2Xeh0B42WSZmglKu3XFFrLJAVQY9aBJEULFTSbL/jsKaWyGoAviV/QPlRMytVK4z 5/8/HIGiYWW2QLbzmCJkKTWZfejxD/PAWANDR6WlBXGVL+zT4x7i6YUUjnGic5hFl/j3 zWHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712343721; x=1712948521; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YCydaye7fGEguRI4B7g0/kq2YLpbPdSprOIVnhlJHDQ=; b=A1Zdeu3vo2lSp0Iyttlo2ijLDOn8pES62VKM3A+M2MiYVO5DIWMimbWnfRSo7Hufmp 2lgbFoY5ZG6WteSxzMJOUi5fQ9UFb5lLalyBHT/oBJG2oD515P3a7ChLqz+icZvSMgmT YzQcwEiVX7rVLAgNDF+Znk6PwSHi6f+Q8ycThBenonIVAoezkL2ZLiSr4Hh1Jm8jCr05 keifck7mG0D1rCU2/exXSVCMj3MrNFiICqymAC3JbKvbgVBqEBwaNciXtFEI7hn1D1ir QLpJcsSCf7re4+YrJ+682Z0H8gDVS9YHciF1pVCmA03+I8LbbJayaX3cowrpyDccqyZL U7OQ== X-Forwarded-Encrypted: i=1; AJvYcCUqL5E8/nhGPddhLyYi27gsiLEB/NH2N72J+1mWtyqPyrsNAuOg/xICoeF9YOmiYWvbX+0B86GwHJzScqSM7sDSS1qURFn4jEbRpKbDetbVElS6NZfLBxFUzLJoa2L7ac6m X-Gm-Message-State: AOJu0YyUKtLtdVfLcoiPHbH0g6mQAnDsMAtADinT+XcwRMhgfMammfJa fXY3TxNF30LHnY5uG8efbkgscrmOavcrbrHCBuYBOY2j7ZDPNtFE X-Google-Smtp-Source: AGHT+IFeoL4xhfRkglFIcYSiTqZVuyMvRkS/SuSfT8UziayVKARcEsXrAfmsxmzumHkJOo1nyFdlCQ== X-Received: by 2002:a17:906:eca5:b0:a46:4bd4:df86 with SMTP id qh5-20020a170906eca500b00a464bd4df86mr2771600ejb.3.1712343720424; Fri, 05 Apr 2024 12:02:00 -0700 (PDT) Received: from ?IPV6:2a01:c22:72bb:b200:e0e0:cd27:7a04:5c79? (dynamic-2a01-0c22-72bb-b200-e0e0-cd27-7a04-5c79.c22.pool.telefonica.de. [2a01:c22:72bb:b200:e0e0:cd27:7a04:5c79]) by smtp.googlemail.com with ESMTPSA id re9-20020a170906d8c900b00a4e6750a358sm1121493ejb.187.2024.04.05.12.01.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 12:02:00 -0700 (PDT) Message-ID: Date: Fri, 5 Apr 2024 21:01:59 +0200 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Deadlock in pciehp on dock disconnect To: Lukas Wunner Cc: Roman Lozko , linux-pci@vger.kernel.org, Bjorn Helgaas , Dave Hansen , Sean Christopherson , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Christian Marangi , Kurt Kanzenbach , Jesse Brandeburg , Tony Nguyen , intel-wired-lan@lists.osuosl.org References: Content-Language: en-US From: Heiner Kallweit Autocrypt: addr=hkallweit1@gmail.com; keydata= xsFNBF/0ZFUBEAC0eZyktSE7ZNO1SFXL6cQ4i4g6Ah3mOUIXSB4pCY5kQ6OLKHh0FlOD5/5/ sY7IoIouzOjyFdFPnz4Bl3927ClT567hUJJ+SNaFEiJ9vadI6vZm2gcY4ExdIevYHWe1msJF MVE4yNwdS+UsPeCF/6CQQTzHc+n7DomE7fjJD5J1hOJjqz2XWe71fTvYXzxCFLwXXbBiqDC9 dNqOe5odPsa4TsWZ09T33g5n2nzTJs4Zw8fCy8rLqix/raVsqr8fw5qM66MVtdmEljFaJ9N8 /W56qGCp+H8Igk/F7CjlbWXiOlKHA25mPTmbVp7VlFsvsmMokr/imQr+0nXtmvYVaKEUwY2g 86IU6RAOuA8E0J5bD/BeyZdMyVEtX1kT404UJZekFytJZrDZetwxM/cAH+1fMx4z751WJmxQ J7mIXSPuDfeJhRDt9sGM6aRVfXbZt+wBogxyXepmnlv9K4A13z9DVLdKLrYUiu9/5QEl6fgI kPaXlAZmJsQfoKbmPqCHVRYj1lpQtDM/2/BO6gHASflWUHzwmBVZbS/XRs64uJO8CB3+V3fa cIivllReueGCMsHh6/8wgPAyopXOWOxbLsZ291fmZqIR0L5Y6b2HvdFN1Xhc+YrQ8TKK+Z4R mJRDh0wNQ8Gm89g92/YkHji4jIWlp2fwzCcx5+lZCQ1XdqAiHQARAQABzSZIZWluZXIgS2Fs bHdlaXQgPGhrYWxsd2VpdDFAZ21haWwuY29tPsLBjgQTAQgAOBYhBGxfqY/yOyXjyjJehXLe ig9U8DoMBQJf9GRVAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHLeig9U8DoMSycQ AJbfg8HZEK0ljV4M8nvdaiNixWAufrcZ+SD8zhbxl8GispK4F3Yo+20Y3UoZ7FcIidJWUUJL axAOkpI/70YNhlqAPMsuudlAieeYZKjIv1WV5ucNZ3VJ7dC+dlVqQdAr1iD869FZXvy91KhJ wYulyCf+s4T9YgmLC6jLMBZghKIf1uhSd0NzjyCqYWbk2ZxByZHgunEShOhHPHswu3Am0ftt ePaYIHgZs+Vzwfjs8I7EuW/5/f5G9w1vibXxtGY/GXwgGGHRDjFM7RSprGOv4F5eMGh+NFUJ TU9N96PQYMwXVxnQfRXl8O6ffSVmFx4H9rovxWPKobLmqQL0WKLLVvA/aOHCcMKgfyKRcLah 57vGC50Ga8oT2K1g0AhKGkyJo7lGXkMu5yEs0m9O+btqAB261/E3DRxfI1P/tvDZpLJKtq35 dXsj6sjvhgX7VxXhY1wE54uqLLHY3UZQlmH3QF5t80MS7/KhxB1pO1Cpcmkt9hgyzH8+5org +9wWxGUtJWNP7CppY+qvv3SZtKJMKsxqk5coBGwNkMms56z4qfJm2PUtJQGjA65XWdzQACib 2iaDQoBqGZfXRdPT0tC1H5kUJuOX4ll1hI/HBMEFCcO8++Bl2wcrUsAxLzGvhINVJX2DAQaF aNetToazkCnzubKfBOyiTqFJ0b63c5dqziAgzsFNBF/0ZFUBEADF8UEZmKDl1w/UxvjeyAeX kghYkY3bkK6gcIYXdLRfJw12GbvMioSguvVzASVHG8h7NbNjk1yur6AONfbUpXKSNZ0skV8V fG+ppbaY+zQofsSMoj5gP0amwbwvPzVqZCYJai81VobefTX2MZM2Mg/ThBVtGyzV3NeCpnBa 8AX3s9rrX2XUoCibYotbbxx9afZYUFyflOc7kEpc9uJXIdaxS2Z6MnYLHsyVjiU6tzKCiVOU KJevqvzPXJmy0xaOVf7mhFSNQyJTrZpLa+tvB1DQRS08CqYtIMxRrVtC0t0LFeQGly6bOngr ircurWJiJKbSXVstLHgWYiq3/GmCSx/82ObeLO3PftklpRj8d+kFbrvrqBgjWtMH4WtK5uN5 1WJ71hWJfNchKRlaJ3GWy8KolCAoGsQMovn/ZEXxrGs1ndafu47yXOpuDAozoHTBGvuSXSZo ythk/0EAuz5IkwkhYBT1MGIAvNSn9ivE5aRnBazugy0rTRkVggHvt3/7flFHlGVGpBHxFUwb /a4UjJBPtIwa4tWR8B1Ma36S8Jk456k2n1id7M0LQ+eqstmp6Y+UB+pt9NX6t0Slw1NCdYTW gJezWTVKF7pmTdXszXGxlc9kTrVUz04PqPjnYbv5UWuDd2eyzGjrrFOsJEi8OK2d2j4FfF++ AzOMdW09JVqejQARAQABwsF2BBgBCAAgFiEEbF+pj/I7JePKMl6Fct6KD1TwOgwFAl/0ZFUC GwwACgkQct6KD1TwOgxUfg//eAoYc0Vm4NrxymfcY30UjHVD0LgSvU8kUmXxil3qhFPS7KA+ y7tgcKLHOkZkXMX5MLFcS9+SmrAjSBBV8omKoHNo+kfFx/dUAtz0lot8wNGmWb+NcHeKM1eb nwUMOEa1uDdfZeKef/U/2uHBceY7Gc6zPZPWgXghEyQMTH2UhLgeam8yglyO+A6RXCh+s6ak Wje7Vo1wGK4eYxp6pwMPJXLMsI0ii/2k3YPEJPv+yJf90MbYyQSbkTwZhrsokjQEaIfjrIk3 rQRjTve/J62WIO28IbY/mENuGgWehRlTAbhC4BLTZ5uYS0YMQCR7v9UGMWdNWXFyrOB6PjSu Trn9MsPoUc8qI72mVpxEXQDLlrd2ijEWm7Nrf52YMD7hL6rXXuis7R6zY8WnnBhW0uCfhajx q+KuARXC0sDLztcjaS3ayXonpoCPZep2Bd5xqE4Ln8/COCslP7E92W1uf1EcdXXIrx1acg21 H/0Z53okMykVs3a8tECPHIxnre2UxKdTbCEkjkR4V6JyplTS47oWMw3zyI7zkaadfzVFBxk2 lo/Tny+FX1Azea3Ce7oOnRUEZtWSsUidtIjmL8YUQFZYm+JUIgfRmSpMFq8JP4VH43GXpB/S OCrl+/xujzvoUBFV/cHKjEQYBxo+MaiQa1U54ykM2W4DnHb1UiEf5xDkFd4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 05.04.2024 19:48, Lukas Wunner wrote: > On Fri, Apr 05, 2024 at 03:31:34PM +0200, Heiner Kallweit wrote: >> On 05.04.2024 12:02, Lukas Wunner wrote: >>> On Fri, Apr 05, 2024 at 11:14:01AM +0200, Roman Lozko wrote: >>>> Hi, I'm using HP G4 Thunderbolt docking station, and recently (?) >>>> kernel started to "partially" deadlock after disconnecting the dock >>>> station. This results in inability to turn network interfaces on or >>>> off, system can't reboot, `sudo` does not work (guess because it uses >>>> DNS). >>> >>> unregister_netdev() acquires rtnl_lock(), indirectly invokes >>> netdev_trig_deactivate() upon unregistering some LED, thereby >>> calling unregister_netdevice_notifier(), which tries to >>> acquire rtnl_lock() again. >>> >>> From a quick look at the source files involved, this doesn't look >>> like something new, though I note LED support for igc was added >>> only recently with ea578703b03d ("igc: Add support for LEDs on >>> i225/i226"), which went into v6.9-rc1. >> >> It's unfortunate that the device-managed LED is bound to the netdev device. >> Wouldn't binding it to the parent (&pdev->dev) solve the issue? > > I'm guessing igc commit ea578703b03d copy-pasted from r8169 commit > be51ed104ba9 ("r8169: add LED support for RTL8125/RTL8126") because > that driver has exactly the same problem. :) > Right, just tested it for r8169 and got a similar lockdep error. > Roman, does the below patch fix the issue? > > Note that just changing the devm_led_classdev_register() call isn't > sufficient: I'm changing the devm_kcalloc() in igc_led_setup() as well > to avoid a use-after-free (memory would already get freed on netdev > unregister but led a little later on pdev unbind). > > -- >8 -- > > diff --git a/drivers/net/ethernet/intel/igc/igc_leds.c b/drivers/net/ethernet/intel/igc/igc_leds.c > index bf240c5..0b78c30 100644 > --- a/drivers/net/ethernet/intel/igc/igc_leds.c > +++ b/drivers/net/ethernet/intel/igc/igc_leds.c > @@ -257,13 +257,13 @@ static void igc_setup_ldev(struct igc_led_classdev *ldev, > led_cdev->hw_control_get = igc_led_hw_control_get; > led_cdev->hw_control_get_device = igc_led_hw_control_get_device; > > - devm_led_classdev_register(&netdev->dev, led_cdev); > + devm_led_classdev_register(&adapter->pdev->dev, led_cdev); > } > > int igc_led_setup(struct igc_adapter *adapter) > { > struct net_device *netdev = adapter->netdev; > - struct device *dev = &netdev->dev; > + struct device *dev = &adapter->pdev->dev; > struct igc_led_classdev *leds; > int i; > >