From: Hans Zhang <18255117159@163.com>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: bhelgaas@google.com, lpieralisi@kernel.org,
kwilczynski@kernel.org, hans.zhang@cixtech.com, robh@kernel.org,
mpillai@cadence.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] PCI: cadence: Add debugfs property to provide LTSSM status of the PCIe link
Date: Thu, 7 May 2026 00:15:23 +0800 [thread overview]
Message-ID: <b3c11907-18e2-4bb2-953c-a849ae77eee0@163.com> (raw)
In-Reply-To: <twryupjevgplfyfcjip323jcy2gjdnbigvvdpytcodisq76lfs@p7fvtw2ev6lr>
On 5/7/26 00:06, Manivannan Sadhasivam wrote:
> On Wed, May 06, 2026 at 11:52:06PM +0800, Hans Zhang wrote:
>
> [...]
>
>>>> +static int ltssm_status_open(struct inode *inode, struct file *file)
>>>> +{
>>>> + return single_open(file, ltssm_status_show, inode->i_private);
>>>> +}
>>>> +
>>>> +static const struct file_operations cdns_pcie_ltssm_status_ops = {
>>>> + .open = ltssm_status_open,
>>>> + .read = seq_read,
>>>> +};
>>>
>>> Sashiko pointed out that you could use DEFINE_SHOW_ATTRIBUTE() to simplify the
>>> code here.
>>
>> I haven't received any notification from Sashiko. Next time, I'll go
>> directly to the website to check the relevant information. It seems that
>> Sashiko only sent out an email recently; I didn't receive any emails from
>> her before.
>>
>
> Yes, that's the recent behavior. Thanks to kwilczynski ;) You should get
> notification for next iteration.
Wow, that's great!
Best regards,
Hans
>
> - Mani
>
prev parent reply other threads:[~2026-05-06 16:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 10:32 [PATCH v3 0/2] PCI: cadence: Add LTSSM debugfs Hans Zhang
2026-04-06 10:32 ` [PATCH v3 1/2] PCI: cadence: Add HPA architecture flag Hans Zhang
2026-04-06 10:32 ` [PATCH v3 2/2] PCI: cadence: Add debugfs property to provide LTSSM status of the PCIe link Hans Zhang
2026-05-06 15:43 ` Manivannan Sadhasivam
2026-05-06 15:52 ` Hans Zhang
2026-05-06 16:06 ` Manivannan Sadhasivam
2026-05-06 16:15 ` Hans Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3c11907-18e2-4bb2-953c-a849ae77eee0@163.com \
--to=18255117159@163.com \
--cc=bhelgaas@google.com \
--cc=hans.zhang@cixtech.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=mpillai@cadence.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox