From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org ([198.145.29.96]:45006 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbeBTE5E (ORCPT ); Mon, 19 Feb 2018 23:57:04 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Date: Tue, 20 Feb 2018 10:27:02 +0530 From: poza@codeaurora.org To: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Sinan Kaya , Timur Tabi Subject: Re: [PATCH v7 0/7] Address error and recovery for AER and DPC In-Reply-To: <1516430119-3825-1-git-send-email-poza@codeaurora.org> References: <1516430119-3825-1-git-send-email-poza@codeaurora.org> Message-ID: Sender: linux-pci-owner@vger.kernel.org List-ID: On 2018-01-20 12:05, Oza Pawandeep wrote: > This patch set brings in error handling support for DPC > > The current implementation of AER and error message broadcasting to the > EP driver is tightly coupled and limited to AER service driver. > It is important to factor out broadcasting and other link handling > callbacks. So that not only when AER gets triggered, but also when DPC > get > triggered (for e.g. ERR_FATAL), callbacks are handled appropriately. > > DPC should enumerate the devices after recovering the link, which is > achieved by implementing error_resume callback. > > Changes since v6: > Sinan's and Stefan's comments implemented. > > reordered patch 6 and 7 > > cleaned up > Changes since v5: > Sinan's and Keith's comments incorporated. > > made separate patch for mutex > > unified error repotting codes into driver/pci/pci.h > > got rid of wait link active/inactive and > made generic function in driver/pci/pci.c > Changes since v4: > Bjorn's comments incorporated. > > Renamed only do_recovery. > > moved the things more locally to drivers/pci/pci.h > Changes since v3: > Bjorn's comments incorporated. > > Made separate patch renaming generic pci_err.c > > Introduce pci_err.h to contain all the error types and > recovery > > removed all the dependencies on pci.h > Changes since v2: > Based on feedback from Keith: > " > When DPC is triggered due to receipt of an uncorrectable error > Message, > the Requester ID from the Message is recorded in the DPC Error > Source ID register and that Message is discarded and not forwarded > Upstream. > " > Removed the patch where AER checks if DPC service is active > Changes since v1: > Kbuild errors fixed: > > pci_find_dpc_dev made static > > ras_event.h updated > > pci_find_aer_service call with CONFIG check > > pci_find_dpc_service call with CONFIG check > > Oza Pawandeep (7): > PCI/AER: Rename error recovery to generic pci naming > PCI/AER: factor out error reporting from AER > PCI/ERR: add mutex to synchronize recovery > PCI/DPC: Unify and plumb error handling into DPC > PCI/AER: Unify aer error defines at single space > PCI/DPC: Enumerate the devices after DPC trigger event > PCI: Unify wait for link active into generic pci > > drivers/acpi/apei/ghes.c | 1 + > drivers/pci/hotplug/pciehp_hpc.c | 21 +- > drivers/pci/pci.c | 39 +++- > drivers/pci/pci.h | 11 + > drivers/pci/pcie/Makefile | 2 +- > drivers/pci/pcie/aer/aerdrv.h | 30 --- > drivers/pci/pcie/aer/aerdrv_core.c | 293 > +------------------------- > drivers/pci/pcie/aer/aerdrv_errprint.c | 1 + > drivers/pci/pcie/pcie-dpc.c | 115 ++++++++++- > drivers/pci/pcie/pcie-err.c | 366 > +++++++++++++++++++++++++++++++++ > drivers/pci/pcie/portdrv.h | 2 + > include/linux/aer.h | 4 - > include/linux/pci.h | 1 + > 13 files changed, 534 insertions(+), 352 deletions(-) > create mode 100644 drivers/pci/pcie/pcie-err.c Hi Bjorn, I will rebase this patch series on pci and post it again. on https://kernel.googlesource.com/pub/scm/linux/kernel/git/helgaas/pci Regards, Oza.