From: poza@codeaurora.org
To: Keith Busch <keith.busch@intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Dongdong Liu <liudongdong3@huawei.com>, Wei Zhang <wzhang@fb.com>,
Sinan Kaya <okaya@codeaurora.org>,
Timur Tabi <timur@codeaurora.org>
Subject: Re: [PATCH v2] PCI/DPC: Fix PCI legacy interrupt acknowledgement
Date: Thu, 15 Mar 2018 13:24:03 +0530 [thread overview]
Message-ID: <b67f0624a9643f73a86126f4c6f18657@codeaurora.org> (raw)
In-Reply-To: <20180314205230.GF29867@localhost.localdomain>
On 2018-03-15 02:22, Keith Busch wrote:
> On Wed, Mar 14, 2018 at 09:20:48PM +0530, Oza Pawandeep wrote:
>> Current DPC driver acknowledges the interrupt in deferred work, which
>> works
>> since MSI are edge triggered.
>>
>> But when MSI is disabled (e.g. pci=nomsi boot option) port service
>> driver falls back to PCI legacy INT interrupt.
>>
>> With current code we do not acknowledge the interrupt back in
>> dpc_irq()
>> and we get dpc interrupt storm.
>>
>> This patch acknowledges the interrupt in interrupt handler.
>>
>> Signed-off-by: Oza Pawandeep <poza@codeaurora.org>
>
> Thanks, this looks good to me.
>
> Reviewed-by: Keith Busch <keith
checkpatch script shows
WARNING: 'acknowledgement' may be misspelled - perhaps 'acknowledgment'?
but dictionaries shows acknowledgement.
Regards,
Oza.
prev parent reply other threads:[~2018-03-15 7:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 15:50 [PATCH v2] PCI/DPC: Fix PCI legacy interrupt acknowledgement Oza Pawandeep
2018-03-14 20:52 ` Keith Busch
2018-03-14 20:56 ` Keith Busch
2018-03-28 15:12 ` poza
2018-03-15 7:54 ` poza [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b67f0624a9643f73a86126f4c6f18657@codeaurora.org \
--to=poza@codeaurora.org \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=keith.busch@intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=okaya@codeaurora.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
--cc=wzhang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).