From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org ([198.145.29.96]:52142 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbeCOHyE (ORCPT ); Thu, 15 Mar 2018 03:54:04 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Date: Thu, 15 Mar 2018 13:24:03 +0530 From: poza@codeaurora.org To: Keith Busch Cc: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Wei Zhang , Sinan Kaya , Timur Tabi Subject: Re: [PATCH v2] PCI/DPC: Fix PCI legacy interrupt acknowledgement In-Reply-To: <20180314205230.GF29867@localhost.localdomain> References: <1521042648-20522-1-git-send-email-poza@codeaurora.org> <20180314205230.GF29867@localhost.localdomain> Message-ID: Sender: linux-pci-owner@vger.kernel.org List-ID: On 2018-03-15 02:22, Keith Busch wrote: > On Wed, Mar 14, 2018 at 09:20:48PM +0530, Oza Pawandeep wrote: >> Current DPC driver acknowledges the interrupt in deferred work, which >> works >> since MSI are edge triggered. >> >> But when MSI is disabled (e.g. pci=nomsi boot option) port service >> driver falls back to PCI legacy INT interrupt. >> >> With current code we do not acknowledge the interrupt back in >> dpc_irq() >> and we get dpc interrupt storm. >> >> This patch acknowledges the interrupt in interrupt handler. >> >> Signed-off-by: Oza Pawandeep > > Thanks, this looks good to me. > > Reviewed-by: Keith Busch