Re: [PATCH RESEND v6 2/2] dmaengine: dw-edma: Add non-LL mode

[Eugen Hristev <eugen.hristev@linaro.org>]

On 12/1/25 11:58, Verma, Devendra wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
> 
> Hi All
> 
> Could you all please review the following patch?

No need to remind people, your patch will be reviewed.

> 
> Regards,
> Dev
> 
>> -----Original Message-----
>> From: Devendra K Verma <devendra.verma@amd.com>
>> Sent: Friday, November 21, 2025 5:05 PM
>> To: bhelgaas@google.com; mani@kernel.org; vkoul@kernel.org
>> Cc: dmaengine@vger.kernel.org; linux-pci@vger.kernel.org; linux-
>> kernel@vger.kernel.org; Simek, Michal <michal.simek@amd.com>; Verma,
>> Devendra <Devendra.Verma@amd.com>
>> Subject: [PATCH RESEND v6 2/2] dmaengine: dw-edma: Add non-LL mode
>>
>> AMD MDB IP supports Linked List (LL) mode as well as non-LL mode.

Is this non-LL mode some official name ? (e.g. in the datasheet or
official product name )
Because having a 'bool non-LL' as false making it in a LL mode adds a
double negation that is difficult to follow.
 >> The current code does not have the mechanisms to enable the DMA
>> transactions using the non-LL mode. The following two cases are added with
>> this patch:
>> - When a valid physical base address is not configured via the
>>   Xilinx VSEC capability then the IP can still be used in non-LL
>>   mode. The default mode for all the DMA transactions and for all
>>   the DMA channels then is non-LL mode.
>> - When a valid physical base address is configured but the client
>>   wants to use the non-LL mode for DMA transactions then also the
>>   flexibility is provided via the peripheral_config struct member of
>>   dma_slave_config. In this case the channels can be individually
>>   configured in non-LL mode. This use case is desirable for single
>>   DMA transfer of a chunk, this saves the effort of preparing the
>>   Link List. This particular scenario is applicable to AMD as well
>>   as Synopsys IP.
>>
>> Signed-off-by: Devendra K Verma <devendra.verma@amd.com>

[...]