From: Florian Fainelli <f.fainelli@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>
Cc: Rob Herring <robh@kernel.org>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel@pengutronix.de
Subject: Re: [PATCH 08/15] PCI: iproc: Convert to platform remove callback returning void
Date: Tue, 21 Mar 2023 14:37:49 -0700 [thread overview]
Message-ID: <b6e076d4-4014-edfc-edba-284e26d4ca0c@gmail.com> (raw)
In-Reply-To: <20230321193208.366561-9-u.kleine-koenig@pengutronix.de>
On 3/21/23 12:32, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks.
>
> The iproc driver always returns 0, it's just a bit hidden. So make
> iproc_pcie_remove() return void instead of always zero and convert the
> platform driver to the alternative remove callback that returns void and
> eventually replaces the int returning callback.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2023-03-21 21:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 19:31 [PATCH 00/15] PCI: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-21 19:31 ` [PATCH 01/15] PCI: aardvark: " Uwe Kleine-König
2023-03-21 19:36 ` Pali Rohár
2023-03-21 21:08 ` Uwe Kleine-König
2023-03-21 19:31 ` [PATCH 02/15] PCI: altera: " Uwe Kleine-König
2023-03-21 19:31 ` [PATCH 03/15] PCI: altera-msi: " Uwe Kleine-König
2023-03-21 19:31 ` [PATCH 04/15] PCI: brcmstb: " Uwe Kleine-König
2023-03-21 21:37 ` Florian Fainelli
2023-03-21 19:31 ` [PATCH 05/15] PCI: cadence/j721e: " Uwe Kleine-König
2023-03-21 19:31 ` [PATCH 06/15] PCI: dwc/*: " Uwe Kleine-König
2023-03-22 18:06 ` Serge Semin
2023-03-21 19:32 ` [PATCH 07/15] PCI: hisi-error: " Uwe Kleine-König
2023-03-21 19:32 ` [PATCH 08/15] PCI: iproc: " Uwe Kleine-König
2023-03-21 21:37 ` Florian Fainelli [this message]
2023-03-21 19:32 ` [PATCH 09/15] PCI: mediatek: " Uwe Kleine-König
2023-03-21 19:32 ` [PATCH 10/15] PCI: mediatek-gen3: " Uwe Kleine-König
2023-03-21 19:32 ` [PATCH 11/15] PCI: mt7621: " Uwe Kleine-König
2023-03-22 6:40 ` Sergio Paracuellos
2023-03-21 19:32 ` [PATCH 12/15] PCI: mvebu: " Uwe Kleine-König
2023-03-21 19:32 ` [PATCH 13/15] PCI: rockchip-host: " Uwe Kleine-König
2023-03-21 19:32 ` [PATCH 14/15] PCI: tegra: " Uwe Kleine-König
2023-03-21 19:32 ` [PATCH 15/15] PCI: xgene-msi: " Uwe Kleine-König
2023-05-30 14:07 ` [PATCH 00/15] PCI: " Uwe Kleine-König
2023-06-02 21:37 ` Bjorn Helgaas
2023-06-06 16:02 ` Uwe Kleine-König
2023-06-24 14:23 ` Krzysztof Wilczyński
2023-06-11 13:24 ` Pali Rohár
2023-06-12 16:19 ` Bjorn Helgaas
2023-06-12 18:17 ` Pali Rohár
2023-06-24 14:19 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6e076d4-4014-edfc-edba-284e26d4ca0c@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=kernel@pengutronix.de \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).