From: Sinan Kaya <okaya@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Lukas Wunner <lukas@wunner.de>,
Keith Busch <keith.busch@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Frederick Lawler <fred@fredlawl.com>,
"Gustavo A . R . Silva" <gustavo@embeddedor.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] PCI: pciehp: Prevent deadlock on disconnect
Date: Sun, 18 Aug 2019 22:28:13 -0400 [thread overview]
Message-ID: <ba0380b1-e8d1-890a-82e2-61d0ab6e9cae@kernel.org> (raw)
In-Reply-To: <20190812143133.75319-2-mika.westerberg@linux.intel.com>
On 8/12/2019 10:31 AM, Mika Westerberg wrote:
> +int pciehp_card_present_or_link_active(struct controller *ctrl)
> {
> - return pciehp_card_present(ctrl) || pciehp_check_link_active(ctrl);
> + int ret;
> +
> + ret = pciehp_card_present(ctrl);
> + if (ret)
> + return ret;
> +
> + return pciehp_check_link_active(ctrl);
The semantics of this function changed here. Before it was checking for
either presence detect bit or link active bit. Now, it is looking to
have both set.
There are PCI controllers that won't report presence detect correctly,
but still report link active.
I think you want
if (ret < 0)
return ret;
here to match the previous behavior while still handling device removal.
next prev parent reply other threads:[~2019-08-19 2:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 14:31 [PATCH v2 1/2] PCI: pciehp: Do not disable interrupt twice on suspend Mika Westerberg
2019-08-12 14:31 ` [PATCH v2 2/2] PCI: pciehp: Prevent deadlock on disconnect Mika Westerberg
2019-08-19 2:28 ` Sinan Kaya [this message]
2019-08-19 8:56 ` Mika Westerberg
2019-08-19 12:28 ` Sinan Kaya
2019-09-23 5:34 ` Lukas Wunner
2019-09-23 8:12 ` Mika Westerberg
2019-09-23 8:28 ` Lukas Wunner
2019-09-23 8:28 ` Mika Westerberg
2019-10-18 7:10 ` Kai-Heng Feng
2019-10-22 23:00 ` Bjorn Helgaas
2019-10-23 7:52 ` Mika Westerberg
2019-10-24 9:38 ` Mika Westerberg
2019-10-24 17:11 ` Bjorn Helgaas
2019-09-19 6:42 ` [PATCH v2 1/2] PCI: pciehp: Do not disable interrupt twice on suspend Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba0380b1-e8d1-890a-82e2-61d0ab6e9cae@kernel.org \
--to=okaya@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=fred@fredlawl.com \
--cc=gustavo@embeddedor.com \
--cc=kai.heng.feng@canonical.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).