From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2046.outbound.protection.outlook.com [40.107.236.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9F318827; Mon, 24 Jun 2024 18:00:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.46 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719252054; cv=fail; b=l7W+LVUpjgMl0OeE2nKTdhUUwrmYxQPXzvJtECPvKo4m7ltO9Uj9eU2P9eYOmHncqTHtaMCMsa0IB+5NgXXrVyiTWcyhidf56YAH1zXm5fusgmyk5H2h3h2YzYvJ373sPFJJlD4wpBOXhaLeZfKNwiOLL0Cx+i4W4JbqW+yhW/g= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719252054; c=relaxed/simple; bh=atk9gTHDdO4XpWlh6K8SCw8spYRlY2bB35jdqToTLA4=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=Ao31CozMjsWW8phnC0xe4KOWyuuOpCfCEEr11IlsvAexWrMeLVbTDM5BrdsiQ0K0iXrRjX46NkpW5XR10Fvfd6cv+j6yvQg9W8+cyg1LC12BYRpEVMtJTQ0HUANgFxaV0iVvM7X7flbCkYM0Tq4QYS79FaEZbhbR/mecOAREh34= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=bquyTqnF; arc=fail smtp.client-ip=40.107.236.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="bquyTqnF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eaE8Y0CMefNmWXrTJgbfprMcjN5PuBfcZmdt1oPJodrenBP/N0jMiHio3Dmka1ui7/lMoM2WnRDaTG6FMs9wDaNGQg5wUJ0ST+LNxVZn/yzMyyww9TW7ssMnoDe+Z5f1P9nH6iv+ZqiijOoXtdlIP7THgk5V/ku03udYDO+XICm7e7iDF1ZP2985CRNOivM+cp7TVgfUDC4Yp3LMnGU/0JOEhucuF8OMYwF1pq4bOIL9dGKV3tvANZttZH8gmiFd2Mzkl9VOzpMCAJRNs1bXQPO2cJnH1QLHigYr5vMZwaT8vatOmaNCQ3Kb0CnYYD289UPRL9A7eIxUMjAsAHdUNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0i0SqlM4IX7PkJVXHedx/P9ssYQo04Z1R+wZzx215vA=; b=ll3o1SuZsT7WQBJUWPbd065wdIVDtWTMI3VAsveeaLPMINMB6xlF9cxZGdlb8jTJoU6CHXt9Oxp0Doi+ghy5ufEAz8HkHtNRykU2yupEb2JI6IDiV8I/O8Iflas8uY+iAh9efVMq75KCtXNDKKaRdFeBlcUd549UJxXR4YYRbC2gRLiplznMLgBRyVT7egyt2fuRAvuUYPh1zMM8dMi1fS68oAEjlF1YcmH5jBZ4tJaxdpbxuKhNTBNcgC9jzqTjWY/ql4nTl9oLWxVoVUVtfclooLUC6BycfFwCPjx62bKHm+nSiBwrhjFMloTGfOyoi2hkT4b7PpZ8jAkbQZTfFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0i0SqlM4IX7PkJVXHedx/P9ssYQo04Z1R+wZzx215vA=; b=bquyTqnFwNxt69FeTWqTvUJZa+JpGV0rULFlgH+PYz6hUnlTKeQFD7vSRWAS+zsaJVTvisZkD+OByFKjbRp7Ob6UdWMn4K7CcImmDcO66MFa6TlxJkmg/iwFt4PyetXbvjPjkSUEa4GtQpO5xh0Ed+unQ1/IOTFp2+IMJAwrH5c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BL3PR12MB6380.namprd12.prod.outlook.com (2603:10b6:208:38d::18) by DS0PR12MB7656.namprd12.prod.outlook.com (2603:10b6:8:11f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.29; Mon, 24 Jun 2024 18:00:44 +0000 Received: from BL3PR12MB6380.namprd12.prod.outlook.com ([fe80::66cf:5409:24d1:532b]) by BL3PR12MB6380.namprd12.prod.outlook.com ([fe80::66cf:5409:24d1:532b%7]) with mapi id 15.20.7698.025; Mon, 24 Jun 2024 18:00:44 +0000 Message-ID: Date: Mon, 24 Jun 2024 13:00:41 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 2/9] PCI/AER: Call AER CE handler before clearing AER CE status register Content-Language: en-US To: Dan Williams , ira.weiny@intel.com, dave@stgolabs.net, dave.jiang@intel.com, alison.schofield@intel.com, ming4.li@intel.com, vishal.l.verma@intel.com, jim.harris@samsung.com, ilpo.jarvinen@linux.intel.com, ardb@kernel.org, sathyanarayanan.kuppuswamy@linux.intel.com, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, Yazen.Ghannam@amd.com, Robert.Richter@amd.com Cc: Bjorn Helgaas , linux-pci@vger.kernel.org References: <20240617200411.1426554-1-terry.bowman@amd.com> <20240617200411.1426554-3-terry.bowman@amd.com> <6675d34860e5e_57ac294a2@dwillia2-xfh.jf.intel.com.notmuch> From: Terry Bowman In-Reply-To: <6675d34860e5e_57ac294a2@dwillia2-xfh.jf.intel.com.notmuch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN6PR04CA0074.namprd04.prod.outlook.com (2603:10b6:805:f2::15) To BL3PR12MB6380.namprd12.prod.outlook.com (2603:10b6:208:38d::18) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL3PR12MB6380:EE_|DS0PR12MB7656:EE_ X-MS-Office365-Filtering-Correlation-Id: b5f4c788-e5dc-4843-9c37-08dc9477912d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|376011|7416011|1800799021|366013|921017; X-Microsoft-Antispam-Message-Info: =?utf-8?B?V0VsTXhkb3hHZmsvU1l0SWNucnpMbDZmYld3RUFEeU9zSmhJbDl4NUpWKzBz?= =?utf-8?B?VlpTN1ZBNS8vUW1OMVhjWVhIQ0xqUjJuSi8yRVBCMlovRE5tNWtwSU1yVkY0?= =?utf-8?B?TS9qNlF2SUJtN3RZY3YvTWtneEtpZUN4c211QWlvcmt4TkpZV2M0ZXRIRmRz?= =?utf-8?B?dGFiczdrVENGR1FUNHZPS3NFR1g5OVd2ZFNnbk51SkJ6TFBBU0tSSzFKT09T?= =?utf-8?B?SzFKTVRKN3RQRjU5SlF6bmxpSnBKYUE1amtCZGJ3aW9jaUhUdU1UazBkY1FM?= =?utf-8?B?T0hXZkpBcFp1NEd3NXU4dEVGMzZFTVZsL0prbEwwR1NJUHQvWHNib2grZUJr?= =?utf-8?B?Q1F6cVErMTN1anR1V3gzOTFESjZRdC9VNzdGdmRiNjVId2JzLzlYNEhURTI5?= =?utf-8?B?TkZiQjNMWEwwclo1dWM0SmNqNGF2MTR3bGtXUFF6NlZLUkM3Ri9MS2Z2YXlu?= =?utf-8?B?dUEzN2xwWTUwZVl6T1FYR3daRTJyN0R0Z2FFZEs0NERFNHhxNHJqNFhMVjlN?= =?utf-8?B?SXFqZkd3ay9kY3NkLzNmK285cVZsOGMwN2UwWWFQeHI0b3JSTXA3NlU1UEdD?= =?utf-8?B?RnZ5dVJLK3phRzRBVWt2QmFLdEJTdE9NRGVVeHAwU0d6YWEvSi93TWlaQmxu?= =?utf-8?B?UzQ5OTFqWkN0SFpuRUZUQTJobmw5dFBBVmE5eVVqNVpMdGZ4cDB0VnpyRkM5?= =?utf-8?B?akJNWW5md0dyOUp3QjJkMFFvOFBBeVJIYVJrRy9NajJvNmFPaEFSNk5nR0pw?= =?utf-8?B?UEF0WGlseFJRd0tRbFkrMWtUbVNUa2lrK3BBbTU1QVZjRnFzTTZtZ2Mvemo1?= =?utf-8?B?VEt1SmxzaVJSRXFKU1Y2QnVTNHFkSnhOZXFUWE5PT3gwallRZ1pwUHdvVzZ5?= =?utf-8?B?dS9hVDBrTU5xa1k5YjBGS1FJcFAyWlBKbU5Zdk40R1lseExuZ0E1U1dwTDRC?= =?utf-8?B?VkkvQ1VINndOa3ZScFJLRy9xN24rVkVPUWQ3YVZRanI4SzlvSzBvOFE1SllE?= =?utf-8?B?NXU3cWg2TWt5d3g0dGpkczRpb2wycVp3ZmZoVGJRMTFCajRZcG1yeXlWODVj?= =?utf-8?B?KzFLSjh3QUY5Wng5cGVqdnNQVjFuOGJpdys4MnlhQ1hndTZpelkxTW1wK3Mw?= =?utf-8?B?bkxlODBrWVYyRTltZnhUNi9lOUF2SkJoOHRyQVpjeVZib3RsRkhUcmVKSUsw?= =?utf-8?B?aDJxa2x4amJjOFozNmdoQ1dIZk83OWRmQ09pd0hCWmZkdjN3N05zZlg2c2Za?= =?utf-8?B?aXJrdUE5SFVQdTQrMDdDaENNei9rcmZ6MnRQaWMvVlJrNUtVMjEwVW5JaTZH?= =?utf-8?B?dERpVERJb0JpQWpBb0xyVHcxYVhpbGZEdEtvRS84TmVLalRvMnhOYUNWQ3Jw?= =?utf-8?B?Yk5rcXphRFBoVUM1NU5SMVk1NFllbEhiT3hWdCtVWlp3R0Fodjg3MW1UV3Fh?= =?utf-8?B?cmZlTzNKMXlQdTkxRGVTcU9WeDhsdWlzK2lQTFRveEY0MEZWK21TV1hoOXVy?= =?utf-8?B?QVpnSkc3SmxBaWxuVlExZklmdHc2NmxxVzJsak8wb2ZNY0p0aHMvQzBtSHg3?= =?utf-8?B?YmgzSUEyb0RKR0k3Tzd5RkdVd2lFUDZEZmMySllUMFA0MmJjcXEvZnpTK1Bu?= =?utf-8?B?ZFFOU0lvTURxVjhFSHZHOVM2TDI3ZlVNVFBQbHluMTlxSkVpd0x5TkpZSlFm?= =?utf-8?B?aStRRndQVHdKWmsyU3hEUjZ6WlpiNS9iZ1VjanovMTdZeXhtbU5Qc3pKKys2?= =?utf-8?B?bnltQTg2TndzOEI0NzFSNWcyRmNUbnMyWnpEaDJHeDY3a3dZRFBrQ1RKWkRF?= =?utf-8?Q?wCMsFqilC8kMae+LOAlGaVdqLP6LZREzoPlAc=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL3PR12MB6380.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230037)(376011)(7416011)(1800799021)(366013)(921017);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWREMkpGcHVRa3JCRXNYbmRua25KcFlqajV2aGxiL1Y0V2xJaXhkTnJxWjh1?= =?utf-8?B?L1BUUGszbnJieWw5R216NU9pWWM4TkVVbzF5UGY1Sy9Ba0tSM215UUZzL1M3?= =?utf-8?B?Q2dVT1psUmRtRk1YNUJSTHhlK0M3dFNaUnlpaUtYWStidzB6ZGxoTWxVZHFv?= =?utf-8?B?WjF6TEJERnl3N3Y3WkduZGlnVnBXOXFJOXp1dFZNZW95QURPc3ZwR0ovNzA0?= =?utf-8?B?USs1aU92clpQeFd6dUJMcjl6dHYxTTlKQW11MU9Dc3FRUWxKbWhpZ3lCelFW?= =?utf-8?B?eGdGN0Jsa29STVhQTDNhYkk3bVhiWVVsT1hrZjZ1MG4ybFVuY0FpU2F1UlpL?= =?utf-8?B?eDFibklpclNzeGlRVDlGaUNQb2hRem91d0tQWG94M3FaL3BManYvbTcvVjNs?= =?utf-8?B?STE4T0dZUUtXdStrZEEvVElqeGorV3FKK2RyaHkyOGR0VmlhWmFXMWdvVXk0?= =?utf-8?B?dXFOMGdJckw5NmVFQzZHK2p5VlVEVXpidkJXRnlyZEo4S2diM0xaS1RzbFBJ?= =?utf-8?B?TVcvN1N6aGV4TGFMVHI1QVF1REM4cEJuUENpdDExdkgrQ0RiS3VndkZUVjVW?= =?utf-8?B?RGpFUDV0OUNQVmZxZ0YzY3M1VWtDcFVocS8yNjI0ZnZhOWV4WFZUVldRSGI2?= =?utf-8?B?ZEgvTUUzU3ZDR05ncVdHUkdaS2xKQUJvVHhIZmd4enpsaXIvQ2NGaG5LS2M0?= =?utf-8?B?Z01OY09oVWtZUFA5Mnd6TWw1Y2xibGJnVE8zb1RSamdrT1JiN2t6bGVrUEE2?= =?utf-8?B?QnNqczRmZmVkUGk5Tzl0bmxHZ0Uya1F3ZnBlTFVmcHJ0M0c3WW9RVWQ1b0hG?= =?utf-8?B?Q3FQRm44TGhSakZqNnYrQXhuMW1KSmFCMnJQak1iL00yM1JPMnY2VTd6Y21m?= =?utf-8?B?SVhnQS9CQmh0WlpreUFxencxdkh3dUdGbEs3ajBlNzNKczhJVllDRVJjM2xu?= =?utf-8?B?WllYSHRiVUhQSmY2TnB0V2FMaStBSlNOWGdIZjVadkZ5MC9kWEdEVllucnpr?= =?utf-8?B?UWlobkJJU0Y0Q1pRc3hsdGdXV2M4ckt4QkVSc1VlclpJaXJKZEFGYUIxYnpm?= =?utf-8?B?UmFsREdSclRIWVVEVk9hbFlBaEQ4OGpUOU42K1c3cnlSd1JXVVFMUGI5Uld6?= =?utf-8?B?NDErdWtxZW9vby9LSENOazN4YXNnaStTVWthdkVDTS9PaitBd2pWZU82RkQv?= =?utf-8?B?T09lY2Q4YTFFMXc4dWJXS3hJWjRBZWtXelpaYXdWY0MwYURjMmdrR2F3QWth?= =?utf-8?B?TXRFNXFkeDNnRTQ1aUFCMmVtdUVWRE85dVZzZDRTNUNMaWxLSW9CcGxvanNH?= =?utf-8?B?dmdVaDkwR0xQSzVrSmx5bTRSNUNXWlE0cnluWXJXOXF2ZHRKNmlWZkwrTHRK?= =?utf-8?B?SjlHN0JyeXFmckNYeVNyb2NUSVBlTmJSRVA2a0t0c2ZNTWNwMHhweWFtTzY5?= =?utf-8?B?QnlVYVJ2K3FCR3BvOGczd2pkdmZSZzdiRERNb3UxZEFtWXBtT015b1l2YjMw?= =?utf-8?B?VStnSnNMTk1uNDFMaHpoMC9kMTR0ak96MWluZ0FFWW9ROXJiZW1FRGkxcTM1?= =?utf-8?B?QkxZdmZjTHVtUTRSWGgyd2lROXFYc21DcUJNTGN4d0pLOEVUb3IyNkpMWWlK?= =?utf-8?B?Y1BLdGdLUGszR2kveGp4aEtVMzhZZ0xmQUFVZ1J1MUFhQVhVVmoyS1RXKzR5?= =?utf-8?B?VUhPcHVZOXViaEh2R2cwbHNNZWttcEtRZWllbk1LTEw3UTZEVU1FNU12cXFP?= =?utf-8?B?K0QzeUV1RFFDRVVUeEs3MXVTNVd1dXhacEk3cnhXYTJZRTRnVHJENjhyMVh5?= =?utf-8?B?OEJkSHVnRXZtQ3JJanFUOEM3aVJMQjlXWndMb1JBTWJkbkMwd1hkOVJFQ01Q?= =?utf-8?B?Z0t6c3BBMm9MM0QwTXpSc3VpV1NxbkUvTjZyTHNsTHJHNnZ6V3h0WG5UL1Nq?= =?utf-8?B?OUJGUDY4RmN0SWZnWWtqNkZRZnNDcmo3dGd3dVRua09aK3V5NGh5UnROcldw?= =?utf-8?B?WUwzRHl3azN3NWxESVI1S3Y1TjdURDFLZnFuL0tTS0RsUmNlcHFneGtBWUpU?= =?utf-8?B?VXVMYkRhUTJSOGg3V1JGTFIyKzFJNU5OUTdSazYrY0wwbmJoK283S0F0TXlF?= =?utf-8?Q?7YHMj8+n3qOrki1y8L5EomxWE?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5f4c788-e5dc-4843-9c37-08dc9477912d X-MS-Exchange-CrossTenant-AuthSource: BL3PR12MB6380.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2024 18:00:43.9355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AT8dwRV8qHdljzzVkOPm9wU8hBKK/eioVAfPr7KOw450ml9whLydItIC5SJqD/E/qWMf2hCy7Rg3aljOa9y6AA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7656 Hi Dan, I added a response below. On 6/21/24 14:23, Dan Williams wrote: > Terry Bowman wrote: >> The AER service driver clears the AER correctable error (CE) status before >> calling the correctable error handler. This results in the error's status >> not correctly reflected if read from the CE handler. >> >> The AER CE status is needed by the portdrv's CE handler. The portdrv's >> CE handler is intended to only call the registered notifier callbacks >> if the CE error status has correctable internal error (CIE) set. > > Is this a fix or a prep patch? It reads like a "fix", but there are no > notifiers to worry about today. > I will add mention "in preparation for future patch". >> This is not a problem for AER uncorrrectbale errors (UCE). The UCE status >> is still present in the AER capability and available for reading, if >> needed, when the UCE handler is called. >> >> Change the order of clearing the CE status and calling the CE handler. >> Make it to call the CE handler first and then clear the CE status >> after returning. > > With the changelog clarified to indicate whether this has any impact on > current behavior you can add: > > Acked-by: Dan Williams Regards, Terry