From: Sinan Kaya <okaya@kernel.org>
To: Keith Busch <keith.busch@intel.com>,
Dongdong Liu <liudongdong3@huawei.com>
Cc: "helgaas@kernel.org" <helgaas@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linuxarm@huawei.com" <linuxarm@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>,
tanxiaofei <tanxiaofei@huawei.com>
Subject: Re: [PATCH] PCI/ERR: Fix run error recovery callbacks for all affected devices
Date: Fri, 25 Jan 2019 12:37:14 -0500 [thread overview]
Message-ID: <bbe67d36-103c-1cda-4186-128a155e8c0e@kernel.org> (raw)
In-Reply-To: <20190125171713.GB11210@localhost.localdomain>
On 1/25/2019 12:17 PM, Keith Busch wrote:
> On Fri, Jan 25, 2019 at 06:28:03AM -0800, Dongdong Liu wrote:
>> I want to fix 2 points by the patch.
>>
>> 1. For EP devices (such as multi-function EP device) under the same bus,
>> when one of the EP devices met non-fatal error, should report non-fatal
>> error only to the error endpoint device, no need to broadcast all of them.
>> That is the patch (PCI/AER: Report non-fatal errors only to the affected endpoint #4.15)
>> have done, but current code PATCH [1] broken this.
>
> How do you know a non-fatal affects only the reporting end point? These can
> certainly be bus errors, and it's not the first to detect may be affected.
>
> In any case, what harm does the broadcast cause?
>
What is the PCIe spec rule about AER errors for multi-function devices?
Does it say it needs to be propagated to all functions or each function has
its own unique AER error handler?
next prev parent reply other threads:[~2019-01-25 17:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 13:50 [PATCH] PCI/ERR: Fix run error recovery callbacks for all affected devices Dongdong Liu
2019-01-24 18:18 ` Sinan Kaya
2019-01-24 21:37 ` Keith Busch
2019-01-25 14:28 ` Dongdong Liu
2019-01-25 17:09 ` Sinan Kaya
2019-01-28 14:05 ` Dongdong Liu
2019-01-25 17:17 ` Keith Busch
2019-01-25 17:37 ` Sinan Kaya [this message]
2019-01-25 17:46 ` Keith Busch
2019-01-25 17:46 ` Sinan Kaya
2019-01-28 14:54 ` Dongdong Liu
2019-01-28 15:47 ` Sinan Kaya
2019-01-28 16:15 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbe67d36-103c-1cda-4186-128a155e8c0e@kernel.org \
--to=okaya@kernel.org \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=tanxiaofei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).