From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 285ED19DF40 for ; Wed, 28 Aug 2024 14:50:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724856604; cv=none; b=Y2OnPFdpqrMU2JiA1yqsSOky5sEUxZytWC8h8Yp1NiY58O6OiXsFcvi+rczqaDkoAd/cBZ+YMlVrwlFM1DlQKwhkFFixfuUGmudgJYsV4DEpx1lQ8Jpmu0IwIJpw56H3kCylJom3GtPuIsDd0WNX8rL5oyMx99JEpizwc410FfY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724856604; c=relaxed/simple; bh=J/jwHT4zbJgGObXt+D2j/0zzLiAWfKkvbdM+Ta6bS7Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=H6kPxE6kTzEQOcGqqjqJc3Sb16YGT/Hia/GIuaBsm1mFO+C5BmGVy7gaO6OowetlIvb6SUxYKOaeLvTFUdSfPTpiKLI6nEbJ0FmDZXxR7ddKZlKcwZM9iCL7cExLoC4w6AoBdkYa+6Xu+ZEZ9MUVkjLYHXmZ9ElppvJ9rux2FmU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=TjpLr7zm; arc=none smtp.client-ip=209.85.166.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="TjpLr7zm" Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-39d21fdc11bso24031995ab.2 for ; Wed, 28 Aug 2024 07:50:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1724856601; x=1725461401; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mkLMtpGIw3Y/dhXXuYhIUT4xTca0Ie89HWp40We3Xeg=; b=TjpLr7zmxDKYik9nmetyJQTPQ9slqpYnCX+aBlaLqojZBLk7IRhTLRpbZEP3Q/pTZ1 ebGzhjX07IssLxwUhGJ8Kl13VjMprmSiPuZV+sf1UTpkn3Vn8BGewden42zQkJJFVLuk 0jOr4VgnEQnr2nLyhDhKB8DwLq53k9VxkNlo1mO4Sshpr9BRe7a1fFT9jOX17l4beRKV g/Lwhcc+uCFPAXq5o/i+uK7tih8uZTtFTW1aMNZs6RXkC+5g40SBWlPr9PlBEAOGgV2n M448MMMOd7lvgdpHrdNJv5UcLLZkiLEorqY/Jj349ybOM0uL8I/cQSmto3/GpoMdbfyS qoXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724856601; x=1725461401; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mkLMtpGIw3Y/dhXXuYhIUT4xTca0Ie89HWp40We3Xeg=; b=obMVQdvfbrmBtu+W8pslkI1g5E4nxAP2k+rwgg7Yi3v8oesd4c27IJWMLyPEHpGHiT XctBGz6A3W3aSWQUTrcBYK5mxLbHVn//RKph62muOWtY9egzNHsqiVyslw5AcNtez/l7 WJF+bf326K75M+fJrJD+r3m/8GsSuHomqqoHMjsjQnh8jq2q/kMgtWF2xvUDLCVuU4iJ UkdaosFCzQOEkDiKLtLpaFgGXje2g99q7CgAzFPiVKPo5Kota8Iug9qcHHFVV0Z+O4Ze pWeHmksDgAsf4aKkCghwUV8Br8Uv6UxEusdH/d637jnDXZk9TnDxEoyt+nU7RvSSiG4B FjHQ== X-Forwarded-Encrypted: i=1; AJvYcCUrelkpioW0S2llFa0Mr3Gz7PpYJ8Xn9W3huEFy8DpvR0LHCS3G+z8PEAu/ecZEJbVAvMpD/2iio50=@vger.kernel.org X-Gm-Message-State: AOJu0Ywb5/3LDihmEpuL82KvWwlhIy7DhTiYK/N5tdwfTVBMEGVm4oMW IAGKF8SgsLbGuoLD1QmkgBaYlbrYDApU9lUuXHlrnazPQhyeFtDy/Ku/HYaQQ1I= X-Google-Smtp-Source: AGHT+IFBscc8IYAxjJLTBWjrXmkHgdjkc3wJmP/EHCRSuAoFvcdmRkkoVZFsL6zQmmMKLOgkxkhFgQ== X-Received: by 2002:a05:6e02:12cf:b0:39a:e9ec:9462 with SMTP id e9e14a558f8ab-39e3c976ba5mr195862795ab.5.1724856601103; Wed, 28 Aug 2024 07:50:01 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-39f376ff875sm34085ab.42.2024.08.28.07.49.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Aug 2024 07:49:59 -0700 (PDT) Message-ID: Date: Wed, 28 Aug 2024 08:49:54 -0600 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/7] block: mtip32xx: Replace deprecated PCI functions To: Philipp Stanner , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bjorn Helgaas , Alvaro Karsz , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Richard Cochran , Damien Le Moal , Hannes Reinecke , Keith Busch Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, virtualization@lists.linux.dev References: <20240827185616.45094-1-pstanner@redhat.com> <20240827185616.45094-4-pstanner@redhat.com> <189ab84e8af230092ff94cc3f3addb499b1a581d.camel@redhat.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <189ab84e8af230092ff94cc3f3addb499b1a581d.camel@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/28/24 1:10 AM, Philipp Stanner wrote: > On Tue, 2024-08-27 at 13:05 -0600, Jens Axboe wrote: >> On 8/27/24 12:56 PM, Philipp Stanner wrote: >>> pcim_iomap_regions() and pcim_iomap_table() have been deprecated by >>> the >>> PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate >>> pcim_iomap_table(), pcim_iomap_regions_request_all()"). >>> >>> In mtip32xx, these functions can easily be replaced by their >>> respective >>> successors, pcim_request_region() and pcim_iomap(). Moreover, the >>> driver's calls to pcim_iounmap_regions() in probe()'s error path >>> and in >>> remove() are not necessary. Cleanup can be performed by PCI devres >>> automatically. >>> >>> Replace pcim_iomap_regions() and pcim_iomap_table(). >>> >>> Remove the calls to pcim_iounmap_regions(). >> >> Looks fine to me - since it depends on other trees, feel free to take >> it >> through those: >> >> Reviewed-by: Jens Axboe > > Thank you for the review. > > I have to provide a v5 because of an issue in another patch. While I'm > at it, I'd modify this patch here so that the comment above > pcim_request_region() is descriptive of the actual events: > > - /* Map BAR5 to memory. */ > + /* Request BAR5. */ > > > I'd keep your Reviewed-by if that's OK. It's the only change I'd do. That's fine. -- Jens Axboe