From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61B49285C99 for ; Tue, 14 Oct 2025 05:20:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760419255; cv=none; b=Bx5RSnn85qC2wGzoVfxAc9TdPXvGHlkvJp65QAtRRuHi8IEqetrcSalYtG85xXUkp99xf6IjuyNN46P2/pYK0qsqeJ35KjqqhJeE+OzPxZ9UHVQTuMwJialEyFyDvJYTPGjiFt6yIw4j0PpEYYRi4wEGZJCEEcE/AiHCgb1jM/k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760419255; c=relaxed/simple; bh=UxrCrURIYoEaGcszpb56z3jQjOCNpu2sTBsM6wrz+yQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mpFjPn//VyEUSv4B7nEoOxJDIZo3VgMzN/tML75Froe/z8eFNjX7rRPPHSj1fECeNfqEz4cq3iW3Em4y8lJkC/0g9Z13qDh7ksgiAs2xe8/SYiDtuaWxJkzeJLgYTCRrnZmoUq/umGbnBRNH4M7GJehoQ1i/V2nV8XZ8y7mY8Vg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fX41j3W8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fX41j3W8" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59DHDFND002501 for ; Tue, 14 Oct 2025 05:20:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yvqF8DYLjafvi+gMij4k/ZfLIN5YYyS6USXN/Cv/VcM=; b=fX41j3W8rvIocm7p JUQz0BlDwmPhjDPs3ykoqGHbg0BTCr1Y2rloEKSmcmY5XcZOzI0BLc4kpZDngQjf dLEDXdq9fiMEj7qY9JOH9Jx4boZUqzR5Xr3/EO792xJJuLT7VO2h8Tkvxb7l1OUR qYK1rtiH32nzpIFzsg1SF/8rgXyxrlNdOnkuRliU082bMP66HVirpOMCaP9J3YpF kH4f0ClRKlE7oi1E74lqHWiTQ4etfv9Hfg6GFcqCSro6Z+7tcKdXqwGawsb375tK 93jnhlzHGqUHBlbutNlr8FHuwXw3cGGVzaeK/U4apiPaGf/T6+gjk3Klld8cXm9f pa9WXg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49qfdk76km-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 14 Oct 2025 05:20:53 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-28e8d1d9b13so91860195ad.0 for ; Mon, 13 Oct 2025 22:20:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760419252; x=1761024052; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yvqF8DYLjafvi+gMij4k/ZfLIN5YYyS6USXN/Cv/VcM=; b=WTs1GR+rH/7Yvn62UtAP5KQuqacKwjvAZY26edt+fe4uPMFNf8NA8YNoQoLC385i1J 3UKfrnL8JXjdeC1hpfp0kodzs9jj+IwzztLIJf9NmIF+dP5oU+E/rENPTrBouYFfy9DF 0/ndKSHz+3VjzjUa+WQEmsTcvhxNe2VkrtwIoIZkc1B21MJU07/+il5Fs7OnAsKfQko6 k/Y9ehmb9UiQtFrVE5wKyjpH/4zw+7R1FZE7TS06j8Wzy2p4RS4aQAOg5hwd2k7q9oHk lGqijlXGNWWUfIA+cK64CbPAXbId9IYtaeWgcNnEou/p14c/8PDuuYY8Zd56Unq4IrB+ 77Lg== X-Forwarded-Encrypted: i=1; AJvYcCX1llZUHVvuUilgzjxnacnxMKnx0M9IcCieGXW8m4xl2tJya/PZnR5n+qmrNrC6EKxP9+n7q2c3NVw=@vger.kernel.org X-Gm-Message-State: AOJu0YzV269NJ81KQTcDtv+6KQozdQ/G5Xq3vmeZWMi7daIgv/AZeulc JDVrgs1sNzTsEQ4nCxESUnaCjPoAGiVol4LlWqFsHh4WpEZsSbLSxfHE+vp1o1DX6wYsgUW59OW tBAt0XigRBEzHR2l/vyRf35IAy7oMaypFFxEi2KdFMtugiOH9hUs5/dCTHOB01oE= X-Gm-Gg: ASbGncu92cXB0pyWyq11R05HI7ekT7z+P9nqgYqH+gJ7YW4JiS1ctuhI/CeYaRDfzQ8 iLuoTaQHm+kwZv/JnDG9J5rU9hQ5X4eDyhw+7+He/YHdcUhvtqZo8TzW/ZQYTjcXQ4RqYKN6cPY nuRMSPYRKBOTB3AVmpGToWDde88aOeo8d4iHfVkbawGod5qVFb8yZeWwotDgkwLRc8lNPKGdcLW 2RCGwgfujU+uGORtbIH+NVF/o6ARNpb+wOSM5VNXXuonnuo+Gh5Xu2At4c3U0m2P3+95hLwH667 tl6Lg9h0vf8vizlCHcY80KbCoYFBKMxisL1qc95HaX1NuD//mijB7YclCcxorfcZUsL6HEitaw= = X-Received: by 2002:a17:903:244c:b0:27e:dc53:d222 with SMTP id d9443c01a7336-290273713c8mr281598425ad.44.1760419251726; Mon, 13 Oct 2025 22:20:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEsL1A/NUIg/+/5DcYNeqv6XyMlYlzj4jSQQAAeiL0ON/Muf4qcSsKga9vyJuwXAaA1wTT+9w== X-Received: by 2002:a17:903:244c:b0:27e:dc53:d222 with SMTP id d9443c01a7336-290273713c8mr281598155ad.44.1760419251227; Mon, 13 Oct 2025 22:20:51 -0700 (PDT) Received: from [10.218.42.132] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29034f894c8sm151716115ad.122.2025.10.13.22.20.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Oct 2025 22:20:50 -0700 (PDT) Message-ID: Date: Tue, 14 Oct 2025 10:50:45 +0530 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: SiFive FU740 PCI driver fails on 6.18-rc1 To: Bjorn Helgaas , Ron Economos , Conor Dooley Cc: bhelgaas@google.com, rishna.chundru@oss.qualcomm.com, mani@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv , Paul Walmsley , Greentime Hu , Samuel Holland , regressions@lists.linux.dev References: <20251013212801.GA865570@bhelgaas> Content-Language: en-US From: Krishna Chaitanya Chundru In-Reply-To: <20251013212801.GA865570@bhelgaas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: RQS8yCtd-1WVin4ieNOL0DghVlaaWCft X-Authority-Analysis: v=2.4 cv=MrNfKmae c=1 sm=1 tr=0 ts=68edddb5 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=fhfb3jyVSOwbcj7u4KkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: RQS8yCtd-1WVin4ieNOL0DghVlaaWCft X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDExMDAxOCBTYWx0ZWRfXxF0w6CDKxZRt EgNrgZnlKHMOttOXW+iDEJPDLgHLZN1ZyBFHOnCYatjJBuQb479w8OXSFuuEQQ47L+V8G8j6KMA UVsaw8ULcttsxjyGxcCHus+1QuibdHgalf6p+YNUq/Q1rWtax1KiPPK0tOElBLvr9OT7UqPE1x7 Yd/k7wK+GAxoTWi0OFZttJ/Hg4jnc0Qx9UjfJzsnyrbhCBUc1p6lHhYledJdkqRoNhc5WGf25Jz 4NWCA8kZjcbzboXiY5VH0YBaS7FIsd5RYDP5uQYniu+iyx7TY0YdkkhfkLkF3VLD5AB7qUIfdr9 0/Pjq1tWhy8wRD8nP1jOmRpFp07cEe5Vt+jbKBsHqkYEkAhlPwdVYRpO047nEMGj+YiWMNW4Uvs ELO527ajhjM2T9j4HxSySkHokPuS1g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-13_09,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 clxscore=1015 adultscore=0 phishscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510110018 On 10/14/2025 2:58 AM, Bjorn Helgaas wrote: > [+cc FU740 driver folks, Conor, regressions] > > On Mon, Oct 13, 2025 at 12:14:54AM -0700, Ron Economos wrote: >> The SiFive FU740 PCI driver fails on the HiFive Unmatched board with Linux >> 6.18-rc1. The error message is: >> >> [    3.166624] fu740-pcie e00000000.pcie: host bridge /soc/pcie@e00000000 >> ranges: >> [    3.166706] fu740-pcie e00000000.pcie:       IO >> 0x0060080000..0x006008ffff -> 0x0060080000 >> [    3.166767] fu740-pcie e00000000.pcie:      MEM >> 0x0060090000..0x007fffffff -> 0x0060090000 >> [    3.166805] fu740-pcie e00000000.pcie:      MEM >> 0x2000000000..0x3fffffffff -> 0x2000000000 >> [    3.166950] fu740-pcie e00000000.pcie: ECAM at [mem >> 0xdf0000000-0xdffffffff] for [bus 00-ff] >> [    3.579500] fu740-pcie e00000000.pcie: No iATU regions found >> [    3.579552] fu740-pcie e00000000.pcie: Failed to configure iATU in ECAM >> mode >> [    3.579655] fu740-pcie e00000000.pcie: probe with driver fu740-pcie >> failed with error -22 >> >> The normal message (on Linux 6.17.2) is: >> >> [    3.381487] fu740-pcie e00000000.pcie: host bridge /soc/pcie@e00000000 >> ranges: >> [    3.381584] fu740-pcie e00000000.pcie:       IO >> 0x0060080000..0x006008ffff -> 0x0060080000 >> [    3.381682] fu740-pcie e00000000.pcie:      MEM >> 0x0060090000..0x007fffffff -> 0x0060090000 >> [    3.381724] fu740-pcie e00000000.pcie:      MEM >> 0x2000000000..0x3fffffffff -> 0x2000000000 >> [    3.484809] fu740-pcie e00000000.pcie: iATU: unroll T, 8 ob, 8 ib, align >> 4K, limit 4096G >> [    3.683678] fu740-pcie e00000000.pcie: PCIe Gen.1 x8 link up >> [    3.883674] fu740-pcie e00000000.pcie: PCIe Gen.3 x8 link up >> [    3.987678] fu740-pcie e00000000.pcie: PCIe Gen.3 x8 link up >> [    3.988164] fu740-pcie e00000000.pcie: PCI host bridge to bus 0000:00 >> >> Reverting the following commits solves the issue. >> >> 0da48c5b2fa731b21bc523c82d927399a1e508b0 PCI: dwc: Support ECAM mechanism by >> enabling iATU 'CFG Shift Feature' >> >> 4660e50cf81800f82eeecf743ad1e3e97ab72190 PCI: qcom: Prepare for the DWC ECAM >> enablement >> >> f6fd357f7afbeb34a633e5688a23b9d7eb49d558 PCI: dwc: Prepare the driver for >> enabling ECAM mechanism using iATU 'CFG Shift Feature' > > As Conor pointed out, we can't fix a code regression with a DT change. > > #regzbot introduced: f6fd357f7afb ("PCI: dwc: Prepare the driver for enabling ECAM mechanism using iATU 'CFG Shift Feature'") Hi Conor, Can you try with this patch and see if it is fixing the issue. diff --git a/drivers/pci/controller/dwc/pcie-fu740.c b/drivers/pci/controller/dwc/pcie-fu740.c index 66367252032b..b5e0f016a580 100644 --- a/drivers/pci/controller/dwc/pcie-fu740.c +++ b/drivers/pci/controller/dwc/pcie-fu740.c @@ -328,6 +328,8 @@ static int fu740_pcie_probe(struct platform_device *pdev) platform_set_drvdata(pdev, afp); + pci->pp.native_ecam = true; + return dw_pcie_host_init(&pci->pp); } - Krishna Chaitanya. >