From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78E0B2F3600 for ; Mon, 13 Oct 2025 08:19:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760343590; cv=none; b=YgmgTyNgqtsKy5vgQe8pzXmHY+OxlFjMcZGwYTMR2RsG6ycGUz24/fMa2Gg0fL7Ix6H8d+rZwiLD0/Ecx0wmjLQ75nIoOa3+CRM8idGdLkIrzyOQNWEr9a1yaDvmJOLCMwfQxOSLMx3gSjKLqK4N4wl3WY284rh9HVwn4cIMZcA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760343590; c=relaxed/simple; bh=nbyUnGNC6iVkZvoDa9txOSKwAbxy+aGL/94mTbuV1Ek=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Gk0JmbKy/6QmgHmM9NV0jiZwB6rNiFKzSteu6AUiNifzqQbjN9Q7xF3K+jZMJzdo2JBq7N6hvsC4TR9EDiIB6Khkezkuh279o3UVeSwTO71Jjs/YoVXDTooDn/ipjj+3HiZDFT2Tks9BH0N88qkk4BYtvWLQaDTe/tU8FmLAIBU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VgZJW0Ml; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VgZJW0Ml" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59D2n6ak000377 for ; Mon, 13 Oct 2025 08:19:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AjJaopS3DAoZEJ7/MA+CTzo8Z6j33qR5fjkH7kQjqNg=; b=VgZJW0Mlu3siiy2/ dVjYVlnPHzVjP9lGh2L4CxvtLD1ZJWRxVuOWU7z2//gS/WCGPSBk+4oRD3lipkzu Feqw8Yl2cdhzNuIfllTorZnpEKYb8csWQM95K1CoPzhqA3oszsJL2F2UvJQpqy1W 01vlvhOEXU7zFPtH+3gXAgaVemPJe/WQWQJDVxZe1JkJh3+JaeLJgjkqIVO/5XmZ vPExBQY1cPRbEeS1ovdFyLrUxXeJuA0AuNNgu1RIQ4ozfujr9sONY/5sRo8b2MUH YnyD4/cFmJRT8Fr2YfuLc/8GGP+JG+MWx0pJdStLp/rGRpCzrBbo4ojRELyWuFrn W6boFA== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49qferusrs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 13 Oct 2025 08:19:46 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-b630b4d8d52so7394393a12.3 for ; Mon, 13 Oct 2025 01:19:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760343585; x=1760948385; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AjJaopS3DAoZEJ7/MA+CTzo8Z6j33qR5fjkH7kQjqNg=; b=i2C/7qrgbwHjqNfgzRTqJRHLGmBue43c+NpvA7hBggX6lQSTmGDHeUSjncGxFEtsR9 Zv92GdSx+VEikjgg4/CA2XxW/0GkCC2M5/k2f5gBfwPcjTwEA6cDG6drHyTd2HFtpPLR 7tF2pePAlNVgYUKtWhWI+stjdiP/5KFYfxIjDIa71OpxP5DcaIWENc1avduTyditDBlY VCkx2Dg+0gnFKk3UT4083J8w4s90bX+PmGNb4eeQNlxmQQPc303lGbrEOUqZFVO0/zSy Mh5L0ezMOu76o8GeFjPMWyzAsbNiz4SgP8E9etFhwwuuJW8b5eFYH8eWeL6k0gfWNdWW Pdjg== X-Forwarded-Encrypted: i=1; AJvYcCXYtZ+zD3CCJD6976GT9lvxVS65IrmdaoNtZjJJyJqcOv3hfcJJwsJTM/eFlPAUrRGnaP51NtKI1/Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8jPQOehcfUB2yLAn5oYcBKgnLUBwhabv1SOPIuT1b25ECJtvB G3JeNxu152VHwIKmIRCbjK7otGuAmPl/jF5ZrqRAJBnkzyuD4Gvui52fr/UAP5x9JSVFEoAGReb rrWDxagBfinBnYA+vQPVJJNO/STXEghoV8O67luSLFB0OFOG14OhZN8exwnvtXdk= X-Gm-Gg: ASbGnctvii6nx3T4giW86pJkIFmDskBV++TJbYAw/aC8XC0JZqSpGLp0r0fuBw6o28e 2hCxeX9TLVXarvxemQmWQ4YW7SivghB9uDVU/OuKioDNYA5VaLe9qlGREfNlipFfVuFF+Q8j/Aq spZ+cwThoHqZlp9Du0dJUNs5UVavyKGn4v6XkdrVnBDt7tus99E7fWcPfaby6a7BKJJ7Siy4gyD dRSynVkcCNB3fTarsYD24J+/M6uYIq+NUgedyx/b1jrphmnfL5MVBYXPJkgsBYw8AB1nfabGvgJ N31ODDycSOXgax06BmiKx1lmrjAgUWKhSFYWsDfMeU5ZKjoxSX7LLaPninHUPiXt0WTwL2/kXQ= = X-Received: by 2002:a05:6a20:431a:b0:2ff:3752:8377 with SMTP id adf61e73a8af0-32da854263amr27466081637.59.1760343584828; Mon, 13 Oct 2025 01:19:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFHNAWKOFDk92n8UbYkabdHidddN3fqxBwTK3LAi4Pw/9wjCPtct6Ntx+TbA7ICVZ9FA1FWWw== X-Received: by 2002:a05:6a20:431a:b0:2ff:3752:8377 with SMTP id adf61e73a8af0-32da854263amr27466054637.59.1760343584368; Mon, 13 Oct 2025 01:19:44 -0700 (PDT) Received: from [10.218.42.132] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7992bb18e28sm10786156b3a.29.2025.10.13.01.19.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Oct 2025 01:19:44 -0700 (PDT) Message-ID: Date: Mon, 13 Oct 2025 13:49:39 +0530 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: SiFive FU740 PCI driver fails on 6.18-rc1 To: Ron Economos , bhelgaas@google.comk, rishna.chundru@oss.qualcomm.com, mani@kernel.org Cc: helgass@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv References: Content-Language: en-US From: Krishna Chaitanya Chundru In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=R64O2NRX c=1 sm=1 tr=0 ts=68ecb622 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=0_2MnD8HFQHHBmd3TK8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-GUID: dq622zXBpy_LtMvnU-WSag2Q361GFrE2 X-Proofpoint-ORIG-GUID: dq622zXBpy_LtMvnU-WSag2Q361GFrE2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDExMDAxOCBTYWx0ZWRfX8WfR5H038LlG 2FOGHigu9dyXsf5ayRH77EFpKozUwjwF3LqywhiLUAjVlhGla67lsqx/Wr1Pd8IEUmsVZAkBpZA 4ClrqkrbRH9ZYogeSe1xO2ba0qK9p0xWL56oLh0jGCGao/6npU3iNa30V0ERjez3O4FW/9scIIv Rj596FpDS2nf0hwYRudwUX2KTtp9vmvjG2ej1ESLz9MaPgUKX0LC5XbDZbLfv9+E6uovl8DBtjb B68r7obdi/KKeQ3WdFYQXMFo/eZViZAriCjOZNt70tYbcyIcdP9uQHoUknglAHasGUgU19R+Nim vdOlj1UiUfUsJja4Rhs2xdgphVd/3fUyJZsAVn+RcYSwwJtxqXDjr71qw2m159BC8J5+DEiI5rM l0QVAOtFxJR32eE0CiDB1z+FEc3Qqg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-13_03,2025-10-06_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 adultscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510110018 On 10/13/2025 12:44 PM, Ron Economos wrote: > The SiFive FU740 PCI driver fails on the HiFive Unmatched board with > Linux 6.18-rc1. The error message is: > > [    3.166624] fu740-pcie e00000000.pcie: host bridge > /soc/pcie@e00000000 ranges: > [    3.166706] fu740-pcie e00000000.pcie:       IO > 0x0060080000..0x006008ffff -> 0x0060080000 > [    3.166767] fu740-pcie e00000000.pcie:      MEM > 0x0060090000..0x007fffffff -> 0x0060090000 > [    3.166805] fu740-pcie e00000000.pcie:      MEM > 0x2000000000..0x3fffffffff -> 0x2000000000 > [    3.166950] fu740-pcie e00000000.pcie: ECAM at [mem > 0xdf0000000-0xdffffffff] for [bus 00-ff] > [    3.579500] fu740-pcie e00000000.pcie: No iATU regions found > [    3.579552] fu740-pcie e00000000.pcie: Failed to configure iATU in > ECAM mode > [    3.579655] fu740-pcie e00000000.pcie: probe with driver fu740-pcie > failed with error -22 > > The normal message (on Linux 6.17.2) is: > > [    3.381487] fu740-pcie e00000000.pcie: host bridge > /soc/pcie@e00000000 ranges: > [    3.381584] fu740-pcie e00000000.pcie:       IO > 0x0060080000..0x006008ffff -> 0x0060080000 > [    3.381682] fu740-pcie e00000000.pcie:      MEM > 0x0060090000..0x007fffffff -> 0x0060090000 > [    3.381724] fu740-pcie e00000000.pcie:      MEM > 0x2000000000..0x3fffffffff -> 0x2000000000 > [    3.484809] fu740-pcie e00000000.pcie: iATU: unroll T, 8 ob, 8 ib, > align 4K, limit 4096G > [    3.683678] fu740-pcie e00000000.pcie: PCIe Gen.1 x8 link up > [    3.883674] fu740-pcie e00000000.pcie: PCIe Gen.3 x8 link up > [    3.987678] fu740-pcie e00000000.pcie: PCIe Gen.3 x8 link up > [    3.988164] fu740-pcie e00000000.pcie: PCI host bridge to bus 0000:00 > > Reverting the following commits solves the issue. > > 0da48c5b2fa731b21bc523c82d927399a1e508b0 PCI: dwc: Support ECAM > mechanism by enabling iATU 'CFG Shift Feature' > > 4660e50cf81800f82eeecf743ad1e3e97ab72190 PCI: qcom: Prepare for the DWC > ECAM enablement > > f6fd357f7afbeb34a633e5688a23b9d7eb49d558 PCI: dwc: Prepare the driver > for enabling ECAM mechanism using iATU 'CFG Shift Feature' > Hi Ron, can you try with this change. Looks like fu740-pcie driver has 256MB space of config space so dwc driver is trying to enable ecam and seeing failures while enabling. you can try two options 1 is to enable ecam if your hardware supports it and other is to use native method like below. If you want to enable ecam your config space should start with dbi address and should have 256Mb aligned 256Mb memory of config space. Uf you want to enable ecam and had this memory requirement fulfilled, try to change your devicetree by starting config space with dbi start address and give it a try. diff --git a/drivers/pci/controller/dwc/pcie-fu740.c b/drivers/pci/controller/dwc/pcie-fu740.c index 66367252032b..b5e0f016a580 100644 --- a/drivers/pci/controller/dwc/pcie-fu740.c +++ b/drivers/pci/controller/dwc/pcie-fu740.c @@ -328,6 +328,8 @@ static int fu740_pcie_probe(struct platform_device *pdev) platform_set_drvdata(pdev, afp); + pci->pp.native_ecam = true; + return dw_pcie_host_init(&pci->pp); } - Krishna Chaitanya. >