From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2187431AF39 for ; Thu, 27 Nov 2025 10:55:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764240921; cv=none; b=INoNCS5d6GZTn8telIHy+dDL4gs2hYW4jkakG7NlaMtxIUlUqvC35nSXhUHp3874vqthrCnFpQ/ekeYch5b1TFk0E4zWsk9AeGtB+ngB03aPbRc51vzltXVWkStzyzbZdqUeXt8HAAfEI8HUUGA66UGRNwE8+CqWJMFf9vsqLGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764240921; c=relaxed/simple; bh=fv5Fh2RKoj+Y489woLzpEbj7gwcHRZz9/j0V4OT4KRs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q1EPDSlJ5epKzLrkKqYniiFZaiXblQcdl9amufdXwyOHTQsf4NgLZBjIhF+zBs/U4VYTyiaePPtDiPxAvu5BkV2KQ0D/KFAneHqVdeOYu0uOpsT2oXF4EbwgEo1hd3FCd09pAuWTqj6kj4sboX2n6Td5rr1c/7ZRqNSNDKts+p4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=o0jYeD/H; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PN287aA4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="o0jYeD/H"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PN287aA4" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ARA3gaL848717 for ; Thu, 27 Nov 2025 10:55:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= c2YDfc+p8Tt4b3hwPmgXQ52xlaEjaZ+Pst10I0/9esY=; b=o0jYeD/HOY8n/6S/ TBdpyY9j8E0n3wks6juFzCf6fPiNNzVKGP6vHkJcT4l5Xe0mPuOHglZODiYoRiMj EKV+c/x1aMGuA+M6BwKZO65za1wAuoPnDxj/JdsIi7OL7o5yqP2t7YIyr8pt9kFs hFlltci2AspWhzfZbNqV6Tyxtij1x4LJi3O97OolUCgQXPrW6l6hx9XfdMmXtbB/ W1DRXilaIuyQtVHwSSsMHNFQG9Hy/fUk7eriSVygH/fNvmdLKF0XFVwV6o6nDycl MM+w8grabjDZYhZcdFT7hIambkczo5U/4kK5nUk3Pgd5DO03TIAF5K5vfU9su706 fM8Okg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4apmjd84qn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 27 Nov 2025 10:55:19 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8b1be0fdfe1so23695385a.2 for ; Thu, 27 Nov 2025 02:55:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764240918; x=1764845718; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c2YDfc+p8Tt4b3hwPmgXQ52xlaEjaZ+Pst10I0/9esY=; b=PN287aA4AAVbLhlk8GPeSDkc04smqTdD8vmf1wfOrPlrg6K58WALyJ6+axjETm6cgM In8KWliPpgiZgSful6KK4KQTJMhTiWHuuxaEcQAzRXucFW7wSHzsCnqJKw1d1ytCh660 i5GGxxRCHGY5H29K3U/HuSX/sl9trnow6yNtq0WXVIvGfUBwLvFh+0dlfIVjTPXV5Cbw 81g/P7Y31IoN0QTuoxtZYhoMH2O9sA2K2WyVOrzzWaS0ZJwNDnPqoeEnWKVNyamFtfPW lmpfWQKfidqebH8cqga6tsH63zl4GLzwxSllEvhTYat0oiofOQNWU3g2C+21crHes8EM ne7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764240918; x=1764845718; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=c2YDfc+p8Tt4b3hwPmgXQ52xlaEjaZ+Pst10I0/9esY=; b=djaV5AnhSIMGv+6kW+h6HK0TWNYQu6jugo8RhxzqpUWOgR4J9Cs/r5Ct9pvDQhCVLp qPVLnwOqH7JrZnwsGXuXQNtFSvd6JArJnhb/+coTUFKwAJjy3hGDGXzyOy/XIiGU3HNn GnIssugXJmsqetk7ytAa6CZZCuUcKvwNIgME4WGkkOSTzBK3P/VNdeJeVf25RzanSGn/ AffjHIeqZ9fHNS4k9Zn7OYjMNVQtQWVj4hGxrhrDWpUOaiHoH/AxiFU8hadhKnmzC2dM eAwBC2m3DGzFBjokeTriIHC5MJwdK/NTJEhWgwVMlCq1U+RqLztbr1QSWskfEabI+jZb 2n3Q== X-Forwarded-Encrypted: i=1; AJvYcCW+vZj5H1GDgRHVCPqMoSSl/UuwUPG0NTsc7+9PLhg4hNCzwVayPHKbedvBSCYqrcGsVMCMwgcz3Pc=@vger.kernel.org X-Gm-Message-State: AOJu0YzbxLAr4z66xm+NJtTAgtpE8OiWpBLWN2THLnVVATsM2vjfzvww dCV0rFCQKZ4hG1Har3yUcYYJbQDiu89uwAhvLbYOBUfH7T4rplr2JrcvrTBpB6snzP0FLAHwzxV 2R9XzET37vg9Do5k4JKGxrHMR43ftNLNZTVa0yK5KoLDeJ0LlC5BuqvxEk1t3XGY= X-Gm-Gg: ASbGnctaq1pf5YrCbyPnBSvxH5M/3mn5qfrblLE4GfYDf+0TUCTALS+LqdhzPM+Dn3/ 17IWzB1StsnZHlc77aKJd7muQJwd0jStFil+snX5fqS9W2zqIw0F6I7xRRnNpx32Je4/tfuyEvg C8KqIYCEQ97RI53wvqdU5mdDvHJEZ3OQEKUsh9AqKYBbMV81HmTSebTIGi5ykKQv6s642p9/4oi AmjJNL0wCHwRJ6v7IpoO/ZKUDYVatpu8C4XuJ784fEtTeU2e/4bKWhjWVHqjTuhme471NHp6uNP Ju8SAbp+IGzBJvnka2PnZNE3M9JswOfL9EM93k100ZOkmsj4Qw+4mN951tGIEOT3v96hSk3QAaN N6RBR7PV6B6CzUUD6vzasCLY8e3OONNtlMBOccubSWKylAnWYCwkdkEjUthMV8vJMFlc= X-Received: by 2002:a05:620a:1a24:b0:8b2:1f04:f8b with SMTP id af79cd13be357-8b341d19712mr2153434585a.6.1764240918287; Thu, 27 Nov 2025 02:55:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IHAINkQldET4/FL4YwiT5PaRN8/2dvHPKux6iQuu+XVvy/67Et+F4hY8Vw6Tycdb48e79a8UQ== X-Received: by 2002:a05:620a:1a24:b0:8b2:1f04:f8b with SMTP id af79cd13be357-8b341d19712mr2153431785a.6.1764240917827; Thu, 27 Nov 2025 02:55:17 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f4d533f2sm137904666b.0.2025.11.27.02.55.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Nov 2025 02:55:17 -0800 (PST) Message-ID: Date: Thu, 27 Nov 2025 11:55:15 +0100 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI: qcom: Clear ASPM L0s CAP for MSM8996 SoC To: Manivannan Sadhasivam , mani@kernel.org, lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com Cc: robh@kernel.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov References: <20251126081718.8239-1-mani@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251126081718.8239-1-mani@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: q6K0VoDdeBd0y6OEJ4ZF1pRF70X5r4FR X-Proofpoint-ORIG-GUID: q6K0VoDdeBd0y6OEJ4ZF1pRF70X5r4FR X-Authority-Analysis: v=2.4 cv=OPcqHCaB c=1 sm=1 tr=0 ts=69282e17 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=69A4WOKrWbd8LYLoJcoA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI3MDA4MCBTYWx0ZWRfX133QbR4MN88y JfAZjI51eLe9iWGQlQ0GUNDvBy5C/fRWUFclO/Spwa4lO1JGM2cwKvMRqXirejYeRGTLbKHY/fu K0ktGDJKlYIxnjlUtZRSgcuhzYRsv5UhIGsbJrbWM8wgNG1d7Qi20Dgh8cmEJ1PKu9i+BbMZsxx /64qTLBLEUgsNyzbnv4yZBM1CNLfPTW61aMiBFcK0Ph3uOOjglODmnNS8vgy1P5ZCD9dk9emeVC 03LAkrhFm2KnFrm/lo0VoSaY9a3e95zK6cPi7bmqjOEEvgPN+Qg8+oQNV7zlzcnxznIt62nFj0f 0XgxP0/yhIg5nFKghYiRJjvESF66ZK/NiRYqqYtiaASkQWqTOR4aSzjtfeLb1mdZkLlnLofQ0m6 2bAmUbMZKDeg9r2mFE0H04oTaw5whQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 spamscore=0 malwarescore=0 phishscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511270080 On 11/26/25 9:17 AM, Manivannan Sadhasivam wrote: > From: Manivannan Sadhasivam > > Though I couldn't confirm the ASPM L0s support with the Qcom hardware team, > bug report from Dmitry suggests that L0s is broken on this legacy SoC. > Hence, clear the L0s CAP for the Root Ports in this SoC. FWIW if we trust the downstream DT, we have this hunk: arch/arm64/boot/dts/qcom/msm8996.dtsi 1431: qcom,l1-supported; 1432: qcom,l1ss-supported; 1586: qcom,l1-supported; 1587: qcom,l1ss-supported; 1739: qcom,l1-supported; 1740: qcom,l1ss-supported; But also funnily enough, msm8996auto boards specifically manually do a /delete-property/ on those.. (there exists one 'qcom,l0s-supported', but it's NOT set for 8996, 98, or 845) On msm-4.14, this became "qcom,no-l0s/l1/l1ss-supported". This forbids L0s on at least 8150 and 8250. Later, both hosts on SM8350 and SM8450-PCIe0 (not 1) forbid L0s. SM8350-PCIe0 sets 'qcom,l1ss-sleep-disable' which influences some RPMh things, but also prevents some clock ops wrt the CLKREF source There's probably more platforms affected, this was a quick grep. Konrad