From: Vidya Sagar <vidyas@nvidia.com>
To: Om Prakash Singh <omp@nvidia.com>, <kw@linux.com>,
<helgaas@kernel.org>, <lorenzo.pieralisi@arm.com>,
<bhelgaas@google.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>
Cc: <linux-tegra@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kthota@nvidia.com>,
<mmaddireddy@nvidia.com>
Subject: Re: [PATCH V2 2/5] PCI: tegra: Fix MSI-X programming
Date: Tue, 8 Jun 2021 16:07:48 +0530 [thread overview]
Message-ID: <c0d4b6bd-d521-191b-6fb6-50ba4c89df51@nvidia.com> (raw)
In-Reply-To: <20210606082204.14222-3-omp@nvidia.com>
Acked-by: Vidya Sagar <vidyas@nvidia.com>
On 6/6/2021 1:52 PM, Om Prakash Singh wrote:
> Lower order MSI-X address is programmed in MSIX_ADDR_MATCH_HIGH_OFF
> DBI register instead of higher order address. This patch fixes this
> programming mistake.
>
> Signed-off-by: Om Prakash Singh <omp@nvidia.com>
> ---
>
> Changes in V2:
> - No change
>
> drivers/pci/controller/dwc/pcie-tegra194.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 6f388523bffe..66e00b276cd3 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -1863,7 +1863,7 @@ static void pex_ep_event_pex_rst_deassert(struct tegra_pcie_dw *pcie)
> val = (ep->msi_mem_phys & MSIX_ADDR_MATCH_LOW_OFF_MASK);
> val |= MSIX_ADDR_MATCH_LOW_OFF_EN;
> dw_pcie_writel_dbi(pci, MSIX_ADDR_MATCH_LOW_OFF, val);
> - val = (lower_32_bits(ep->msi_mem_phys) & MSIX_ADDR_MATCH_HIGH_OFF_MASK);
> + val = (upper_32_bits(ep->msi_mem_phys) & MSIX_ADDR_MATCH_HIGH_OFF_MASK);
> dw_pcie_writel_dbi(pci, MSIX_ADDR_MATCH_HIGH_OFF, val);
>
> ret = dw_pcie_ep_init_complete(ep);
>
next prev parent reply other threads:[~2021-06-08 10:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-06 8:21 [PATCH V2 0/5] Update pcie-tegra194 driver Om Prakash Singh
2021-06-06 8:22 ` [PATCH V2 1/5] PCI: tegra: Fix handling BME_CHGED event Om Prakash Singh
2021-06-08 10:37 ` Vidya Sagar
2021-06-06 8:22 ` [PATCH V2 2/5] PCI: tegra: Fix MSI-X programming Om Prakash Singh
2021-06-08 10:37 ` Vidya Sagar [this message]
2021-06-06 8:22 ` [PATCH V2 3/5] PCI: tegra: Disable interrupts before entering L2 Om Prakash Singh
2021-06-08 10:38 ` Vidya Sagar
2021-06-06 8:22 ` [PATCH V2 4/5] PCI: tegra: Don't allow suspend when Tegra PCIe is in EP mode Om Prakash Singh
2021-06-08 10:38 ` Vidya Sagar
2021-06-06 8:22 ` [PATCH V2 5/5] PCI: tegra: Cleanup unused code Om Prakash Singh
2021-06-08 10:38 ` Vidya Sagar
2021-06-21 9:32 ` [PATCH V2 0/5] Update pcie-tegra194 driver Om Prakash Singh
2021-06-21 18:30 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0d4b6bd-d521-191b-6fb6-50ba4c89df51@nvidia.com \
--to=vidyas@nvidia.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mmaddireddy@nvidia.com \
--cc=omp@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox