From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ED25C83F32 for ; Thu, 31 Aug 2023 10:04:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244357AbjHaKEv (ORCPT ); Thu, 31 Aug 2023 06:04:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229733AbjHaKEv (ORCPT ); Thu, 31 Aug 2023 06:04:51 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33A45CEE; Thu, 31 Aug 2023 03:04:48 -0700 (PDT) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CC4595C0094; Thu, 31 Aug 2023 06:04:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 31 Aug 2023 06:04:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1693476285; x=1693562685; bh=3Bxg+078KgJz5tyNgD/JmbFy76+3swKXt6B GQD9tQ3o=; b=xQaKSO/slhT3iA6z7K5DoGuYaIFmdHmzjpEo0OmEiUFCe4VqLi1 xU6xeQdztTvQFeaH/AfVmqolCmgFZvEOTNITKudVAa956Q/5yA6eGWh41wiMOI8x gT5YyXsGBaGDCRgfSY2z5Y1LoiotjF5ZEroa5bW/lTJNwMKXey5sce2CQ+BGsk5c vulklhbn4WCP1/koVDm3jTQn9SeX2QG6kRNkfzCm0ixri46ljbKecFa4U3faxS7X I6MYBozS+vrqSgIgqruc58RES+kXRq0+heaBLB3gQ8bZ8m25KIzn5t6OlYvEMYVk wP8OwtVgbC4lfhTwDAzNdfwP9PJyui/efGw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1693476285; x=1693562685; bh=3Bxg+078KgJz5tyNgD/JmbFy76+3swKXt6B GQD9tQ3o=; b=iZqLyH1wWf1q38vMPMgm18pJKTKFDes4WE2z36cbp7XPNyN3mct GRyOX2+EibJYON8+OHzOfQ0apZwy2Uaf6mPPF+AQERGPw4grTA7Cizk8ElpHqipN F/Pb9CW11XMYHBRnMLIlctSYfR7JkiE1i4epHorM/+59Ff1uZR175D3+ufl+RGml r3ooSFRWDc93kxePIDZEWICdYBGsCZ3bJ11sesWxIDJULk0mwyKLufcCA5MTCPNv HzffujUf7yeB2lwlE1ZgsujxWUiUJf03Wm1Tb1wiVz8U2YpcJByPwwNouVdTq4wN G7kCrdApfeVAVUtbHtmZh9jz+uX3nlfuubQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudegtddgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeflihgr gihunhcujggrnhhguceojhhirgiguhhnrdihrghnghesfhhlhihgohgrthdrtghomheqne cuggftrfgrthhtvghrnhepudfhkeevvddtueekfeefgfetlefgueegueeltddtieejgeei heevgfehgfdvfeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepjhhirgiguhhnrdihrghnghesfhhlhihgohgrthdrtghomh X-ME-Proxy: Feedback-ID: ifd894703:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 31 Aug 2023 06:04:43 -0400 (EDT) Message-ID: Date: Thu, 31 Aug 2023 18:04:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2] pci: loongson: Workaround MIPS firmware MRRS settings Content-Language: en-GB To: Huacai Chen , bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kw@linux.com, lpieralisi@kernel.org, stable@vger.kernel.org References: <20230725061008.1504292-1-jiaxun.yang@flygoat.com> <861a809d-3df1-327e-e033-87506f6d89e5@flygoat.com> <62a7b292-ea1e-fb88-79cb-e7968d350a5e@flygoat.com> From: Jiaxun Yang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org 在 2023/8/31 17:42, Huacai Chen 写道: > On Thu, Aug 31, 2023 at 4:58 PM Jiaxun Yang wrote: >> >> >> 在 2023/8/31 14:22, Huacai Chen 写道: >> >> [...] >>> But it is worth to try, and you can walk the children to set mrrs when >>> the quirk runs on bridges, I think. >> No, this will break hotplug, I had managed to get hotplug work on 2K1000. >> Also we have no guarantee on order of discovering devices. >>>> but the old quirk should run on every single device. >>> Your current patch has a drawback that both quirks will run for MIPS, >>> and their order is random (though it may cause nothing, but not >>> elegant). >> Actually loongson_mrrs_quirk is declared by DECLARE_PCI_FIXUP_EARLY but >> loongson_old_mrrs_quirk is declared by DECLARE_PCI_FIXUP_ENABLE, >> which means loongson_old_mrrs_quirk always runs after loongson_mrrs_quirk as >> expected. > Then I think it is better to put this quirk in arch/mips/loongson64/, > just as pci_fixup_radeon(). Hmm, spiting two quirks with similar functionality into two places doesn't sound like a good idea. PCI folks, what do you think? Thanks. - Jiaxun [...]