From: Jon Derrick <jonathan.derrick@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
Bjorn Helgaas <helgaas@kernel.org>
Cc: "Wang, Wendy" <wendy.wang@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PCI <linux-pci@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
David Box <david.e.box@linux.intel.com>
Subject: Re: [PATCH v2] PCI: VMD: ACPI: Make ACPI companion lookup work for VMD bus
Date: Thu, 26 Aug 2021 12:24:31 -0600 [thread overview]
Message-ID: <c3bcd4fe-15f6-5033-8419-eb44a3306245@intel.com> (raw)
In-Reply-To: <CAJZ5v0hNNfVyFoFbKb_r70oiHmOPjZONsFO__JbsaSgLSvB-kg@mail.gmail.com>
On 8/25/21 9:26 AM, Rafael J. Wysocki wrote:
> On Wed, Aug 25, 2021 at 5:00 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
>>
>> On Wed, Aug 25, 2021 at 11:02:47AM +0000, Wang, Wendy wrote:
>>> Hi Rafael,
>>>
>>> Tested this PATCH v2 against intel next v5.12 kernel on ADL-S NVME and SATA storages:
>>>
>>> cat /sys/devices/pci0000\:00/0000\:00\:0e.0/firmware_node/path
>>> \_SB_.PC00.VMD0
>>>
>>> 10000:e0:17.0 SATA controller: Intel Corporation Device 7ae2 (rev 11)
>>> 10000:e0:1d.0 System peripheral: Intel Corporation Device 09ab
>>> 10000:e0:1d.4 PCI bridge: Intel Corporation Device 7ab4 (rev 11)
>>> 10000:e1:00.0 Non-Volatile memory controller: Samsung Electronics Co Ltd NVMe SSD Controller PM9A1/PM9A3/980PRO
>>>
>>> [ 6193.658074] ahci 10000:e0:17.0: PCI PM: Suspend power state: D3hot
>>> [ 6193.658156] nvme 10000:e1:00.0: PCI PM: Suspend power state: D3hot
>>> [ 6193.710883] pcieport 10000:e0:1d.4: PCI PM: Suspend power state: D3cold
>
> This doesn't happen without using the ACPI companion object (the
> deepest power state you can get then is D3hot) AFAICS.
>
>>> [ 6193.730318] vmd 0000:00:0e.0: PCI PM: Suspend power state: D3hot
>>>
>>> cat /sys/kernel/debug/pmc_core/substate_residencies
>>> Substate Residency
>>> S0i2.0 0
>>> S0i2.1 13862128
>>>
>>> Thanks!
>>
>> I guess (given Rafael's response) that this is a positive test result,
>> i.e., you see the desired behavior with this patch?
>
> So yes.
LGTM then
Acked-by: Jon Derrick <jonathan.derrick@intel.com>
next prev parent reply other threads:[~2021-08-26 18:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 14:43 [PATCH v2] PCI: VMD: ACPI: Make ACPI companion lookup work for VMD bus Rafael J. Wysocki
2021-08-25 11:02 ` Wang, Wendy
2021-08-25 12:13 ` Rafael J. Wysocki
2021-08-25 15:00 ` Bjorn Helgaas
2021-08-25 15:26 ` Rafael J. Wysocki
2021-08-26 18:24 ` Jon Derrick [this message]
2021-09-02 15:57 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3bcd4fe-15f6-5033-8419-eb44a3306245@intel.com \
--to=jonathan.derrick@intel.com \
--cc=david.e.box@linux.intel.com \
--cc=helgaas@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=wendy.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox