From: Felix Fietkau <nbd@nbd.name>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Ryder Lee" <ryder.lee@mediatek.com>,
"Jianjun Wang" <jianjun.wang@mediatek.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: mediatek-gen3: change driver name to mtk-pcie-gen3
Date: Wed, 4 May 2022 19:16:40 +0200 [thread overview]
Message-ID: <c54c5692-56bd-c17c-24f5-741ec2a1a839@nbd.name> (raw)
In-Reply-To: <20220504170658.GA453994@bhelgaas>
On 04.05.22 19:06, Bjorn Helgaas wrote:
> On Wed, May 04, 2022 at 12:05:55PM +0200, Felix Fietkau wrote:
>> This allows it to coexist with the other mtk pcie driver in the same kernel
>
> I assume this is a v3 of [1]. Please:
Thanks, I wasn't aware of that patch.
> - Follow the subject line capitalization convention, i.e.,
> "PCI: mediatek-gen3: Change ..."
>
> - Expand the commit log to say why this is important. From a C
> language level, using the same "mtk-pcie" string in both drivers
> is no problem. So please mention where it *is* a problem, e.g.,
> if it's a problem with modprobe or similar, say that. Or if it's
> to make log messages in dmesg have different driver names, say
> that.The reason is the fact that driver_register will refuse to register a
driver if one with the same name has already been registered.
> - s/pcie/PCIe/ in commit log and other English text.
>
> - Add a period at the end of the commit log sentence.
>
> [1] https://lore.kernel.org/r/20220422070908.14043-1-jianjun.wang@mediatek.com
Will take care of this and send an updated version as v3.
- Felix
next prev parent reply other threads:[~2022-05-04 17:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 10:05 [PATCH] PCI: mediatek-gen3: change driver name to mtk-pcie-gen3 Felix Fietkau
2022-05-04 17:06 ` Bjorn Helgaas
2022-05-04 17:16 ` Felix Fietkau [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-10-08 16:42 Frank Wunderlich
2022-10-10 20:53 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c54c5692-56bd-c17c-24f5-741ec2a1a839@nbd.name \
--to=nbd@nbd.name \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jianjun.wang@mediatek.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).