From: "Michael S. Tsirkin" <mst@redhat.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Chris Metcalf <cmetcalf@tilera.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
Paul Mundt <lethal@linux-sh.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arch@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH-RFC 2/2] tile: switch to GENERIC_PCI_IOMAP
Date: Tue, 29 Nov 2011 20:54:22 +0200 [thread overview]
Message-ID: <c5893cb30ae99a7e3c48b3fd209c770cd55c87ef.1322592495.git.mst@redhat.com> (raw)
In-Reply-To: <cover.1322592494.git.mst@redhat.com>
tile now has working stubs for ioport_map and ioremap
such that the generic pci_iomap will DTRT: cast to
pointer on memory and return NULL and log message on IO map.
Switch it over to GENERIC_PCI_IOMAP.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
arch/tile/Kconfig | 1 +
arch/tile/include/asm/pci.h | 2 +-
arch/tile/kernel/pci.c | 21 ---------------------
3 files changed, 2 insertions(+), 22 deletions(-)
diff --git a/arch/tile/Kconfig b/arch/tile/Kconfig
index 70a0de4..11270ca 100644
--- a/arch/tile/Kconfig
+++ b/arch/tile/Kconfig
@@ -321,6 +321,7 @@ config PCI
bool "PCI support"
default y
select PCI_DOMAINS
+ select GENERIC_PCI_IOMAP
---help---
Enable PCI root complex support, so PCIe endpoint devices can
be attached to the Tile chip. Many, but not all, PCI devices
diff --git a/arch/tile/include/asm/pci.h b/arch/tile/include/asm/pci.h
index 7f03cef..1d25fea 100644
--- a/arch/tile/include/asm/pci.h
+++ b/arch/tile/include/asm/pci.h
@@ -16,6 +16,7 @@
#define _ASM_TILE_PCI_H
#include <linux/pci.h>
+#include <asm-generic/pci_iomap.h>
/*
* Structure of a PCI controller (host bridge)
@@ -49,7 +50,6 @@ struct pci_controller {
int __devinit tile_pci_init(void);
int __devinit pcibios_init(void);
-void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long max);
static inline void pci_iounmap(struct pci_dev *dev, void __iomem *addr) {}
void __devinit pcibios_fixup_bus(struct pci_bus *bus);
diff --git a/arch/tile/kernel/pci.c b/arch/tile/kernel/pci.c
index 2a8014c..1b6244e 100644
--- a/arch/tile/kernel/pci.c
+++ b/arch/tile/kernel/pci.c
@@ -465,27 +465,6 @@ int pcibios_enable_device(struct pci_dev *dev, int mask)
return 0;
}
-void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long max)
-{
- unsigned long start = pci_resource_start(dev, bar);
- unsigned long len = pci_resource_len(dev, bar);
- unsigned long flags = pci_resource_flags(dev, bar);
-
- if (!len)
- return NULL;
- if (max && len > max)
- len = max;
-
- if (!(flags & IORESOURCE_MEM)) {
- pr_info("PCI: Trying to map invalid resource %#lx\n", flags);
- start = 0;
- }
-
- return (void __iomem *)start;
-}
-EXPORT_SYMBOL(pci_iomap);
-
-
/****************************************************************
*
* Tile PCI config space read/write routines
--
1.7.5.53.gc233e
next prev parent reply other threads:[~2011-11-29 18:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 18:54 [PATCH-RFC 0/2] tile: switch to generic pci_iomap Michael S. Tsirkin
2011-11-29 18:54 ` [PATCH-RFC 1/2] tile: don't panic on iomap Michael S. Tsirkin
2011-11-29 21:04 ` Bjorn Helgaas
2011-11-30 7:04 ` Michael S. Tsirkin
2011-11-29 22:05 ` Arnd Bergmann
2011-11-30 7:13 ` Michael S. Tsirkin
2011-11-30 9:09 ` Arnd Bergmann
2011-11-30 11:59 ` Michael S. Tsirkin
2011-11-30 14:04 ` Arnd Bergmann
2011-11-30 14:31 ` Michael S. Tsirkin
2011-11-30 15:49 ` Arnd Bergmann
2011-11-30 15:59 ` Michael S. Tsirkin
2011-11-30 18:32 ` Arnd Bergmann
2011-12-01 17:59 ` [PATCH] lib/devres.c: allow specifying NO_IOPORT while using PCI Chris Metcalf
2011-12-01 18:44 ` Tejun Heo
2011-12-01 18:48 ` Chris Metcalf
2011-12-01 22:47 ` Arnd Bergmann
2011-12-02 18:48 ` Chris Metcalf
2011-12-05 15:14 ` Arnd Bergmann
2011-12-05 20:08 ` Chris Metcalf
2011-11-30 9:08 ` [PATCH-RFC 1/2 v2] tile: don't panic on iomap Michael S. Tsirkin
2011-11-29 18:54 ` Michael S. Tsirkin [this message]
2011-11-30 21:19 ` [PATCH-RFC 2/2] tile: switch to GENERIC_PCI_IOMAP Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5893cb30ae99a7e3c48b3fd209c770cd55c87ef.1322592495.git.mst@redhat.com \
--to=mst@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=jbarnes@virtuousgeek.org \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).