public inbox for linux-pci@vger.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: David Jeffery <djeffery@redhat.com>,
	linux-kernel@vger.kernel.org, driver-core@lists.linux.dev,
	linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>
Cc: "Tarun Sahu" <tarunsahu@google.com>,
	"Pasha Tatashin" <tatashin@google.com>,
	"Michał Cłapiński" <mclapinski@google.com>,
	"Jordan Richards" <jordanrichards@google.com>,
	"Ewan Milne" <emilne@redhat.com>,
	"John Meneghini" <jmeneghi@redhat.com>,
	"Lombardi, Maurizio" <mlombard@redhat.com>,
	"Stuart Hayes" <stuart.w.hayes@gmail.com>,
	"Laurence Oberman" <loberman@redhat.com>,
	"Bart Van Assche" <bvanassche@acm.org>,
	"Bjorn Helgaas" <helgaas@kernel.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 5/5] scsi: enable async shutdown support
Date: Tue, 7 Apr 2026 17:34:26 +0100	[thread overview]
Message-ID: <c5cb8cf0-9beb-4bc4-8ce6-83b4544beede@oracle.com> (raw)
In-Reply-To: <20260407153532.6395-6-djeffery@redhat.com>


>   }
> @@ -1396,6 +1397,7 @@ int scsi_sysfs_add_sdev(struct scsi_device *sdev)
>   	transport_configure_device(&starget->dev);
>   
>   	device_enable_async_suspend(&sdev->sdev_gendev);
> +	device_enable_async_shutdown(&sdev->sdev_gendev);

We call device_enable_async_shutdown(&sdev->sdev_gendev) here and 
scsi_sysfs_device_initialize() - any reason for that?

>   	scsi_autopm_get_target(starget);
>   	pm_runtime_set_active(&sdev->sdev_gendev);
>   	if (!sdev->rpm_autosuspend)
> @@ -1415,6 +1417,7 @@ int scsi_sysfs_add_sdev(struct scsi_device *sdev)
>   	}
>   
>   	device_enable_async_suspend(&sdev->sdev_dev);
> +	device_enable_async_shutdown(&sdev->sdev_dev);
>   	error = device_add(&sdev->sdev_dev);
>   	if (error) {
>   		sdev_printk(KERN_INFO, sdev,
> @@ -1670,6 +1673,7 @@ void scsi_sysfs_device_initialize(struct scsi_device *sdev)
>   	sdev->sdev_gendev.bus = &scsi_bus_type;
>   	sdev->sdev_gendev.type = &scsi_dev_type;
>   	scsi_enable_async_suspend(&sdev->sdev_gendev);
> +	device_enable_async_shutdown(&sdev->sdev_gendev);
>   	dev_set_name(&sdev->sdev_gendev, "%d:%d:%d:%llu",
>   		     sdev->host->host_no, sdev->channel, sdev->id, sdev->lun);
>   	sdev->sdev_gendev.groups = hostt->sdev_groups;


  reply	other threads:[~2026-04-07 16:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07 15:35 [PATCH v13 0/5] shut down devices asynchronously David Jeffery
2026-04-07 15:35 ` [PATCH 1/5] driver core: separate function to shutdown one device David Jeffery
2026-04-07 15:35 ` [PATCH 2/5] driver core: do not always lock parent in shutdown David Jeffery
2026-04-07 15:35 ` [PATCH 3/5] driver core: async device shutdown infrastructure David Jeffery
2026-04-07 15:35 ` [PATCH 4/5] PCI: Enable async shutdown support David Jeffery
2026-04-07 15:35 ` [PATCH 5/5] scsi: enable " David Jeffery
2026-04-07 16:34   ` John Garry [this message]
2026-04-08 14:16     ` David Jeffery
2026-04-08 15:53       ` John Garry
2026-04-08 19:35         ` David Jeffery
2026-04-09 12:17           ` John Garry
2026-04-09 20:36             ` David Jeffery
  -- strict thread matches above, loose matches on Subject: below --
2026-03-19 14:11 [PATCH v12 0/5] shut down devices asynchronously David Jeffery
2026-03-19 14:11 ` [PATCH 5/5] scsi: enable async shutdown support David Jeffery
2026-03-20  2:20   ` Martin K. Petersen
2026-03-11 17:12 [PATCH 1/5] driver core: do not always lock parent in shutdown David Jeffery
2026-03-11 17:12 ` [PATCH 5/5] scsi: enable async shutdown support David Jeffery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5cb8cf0-9beb-4bc4-8ce6-83b4544beede@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=bvanassche@acm.org \
    --cc=dakr@kernel.org \
    --cc=djeffery@redhat.com \
    --cc=driver-core@lists.linux.dev \
    --cc=emilne@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=helgaas@kernel.org \
    --cc=jmeneghi@redhat.com \
    --cc=jordanrichards@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=loberman@redhat.com \
    --cc=martin.petersen@oracle.com \
    --cc=mclapinski@google.com \
    --cc=mlombard@redhat.com \
    --cc=rafael@kernel.org \
    --cc=stuart.w.hayes@gmail.com \
    --cc=tarunsahu@google.com \
    --cc=tatashin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox