From: Heiner Kallweit <hkallweit1@gmail.com>
To: Damien Le Moal <dlemoal@kernel.org>, Niklas Cassel <cassel@kernel.org>
Cc: linux-ide@vger.kernel.org,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Philipp Stanner <pstanner@redhat.com>
Subject: [PATCH] ata: ahci: Don't call pci_intx() directly
Date: Fri, 1 Nov 2024 23:38:53 +0100 [thread overview]
Message-ID: <c604a8ac-8025-4078-ab90-834d95872e31@gmail.com> (raw)
pci_intx() should be called by PCI core and some virtualization code
only. In PCI device drivers use the appropriate pci_alloc_irq_vectors()
call.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/ata/ahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 2d3d3d67b..09090294c 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1985,7 +1985,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
if (ahci_init_msi(pdev, n_ports, hpriv) < 0) {
/* legacy intx interrupts */
- pci_intx(pdev, 1);
+ pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_INTX);
}
hpriv->irq = pci_irq_vector(pdev, 0);
--
2.47.0
next reply other threads:[~2024-11-01 22:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 22:38 Heiner Kallweit [this message]
2024-11-04 8:30 ` [PATCH] ata: ahci: Don't call pci_intx() directly Niklas Cassel
2024-11-04 13:23 ` Heiner Kallweit
2024-11-04 18:36 ` Niklas Cassel
2024-11-04 19:40 ` Heiner Kallweit
2024-11-05 15:22 ` Philipp Stanner
2024-11-05 15:51 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c604a8ac-8025-4078-ab90-834d95872e31@gmail.com \
--to=hkallweit1@gmail.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pstanner@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox