From: Heiner Kallweit <hkallweit1@gmail.com>
To: Frederick Lawler <fred@fredlawl.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Greg KH <gregkh@linuxfoundation.org>,
Rajat Jain <rajatja@google.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: [PATCH v5 0/4] PCI/ASPM: add sysfs attributes for controlling ASPM
Date: Sat, 31 Aug 2019 22:10:00 +0200 [thread overview]
Message-ID: <c63f507f-7f52-7164-dbc5-07fc18e433b8@gmail.com> (raw)
Background of this extension is a problem with the r8169 network driver.
Several combinations of board chipsets and network chip versions have
problems if ASPM is enabled, therefore we have to disable ASPM per
default. However especially on notebooks ASPM can provide significant
power-saving, therefore we want to give users the option to enable
ASPM. With the new sysfs attributes users can control which ASPM
link-states are disabled.
Note: Series depends on series "PCI: Make pcie_downstream_port()
available outside of access.c" from Mika Westerberg that is still
sitting in the PCI inbox.
Alternatively I could prepare a version w/o this dependency, but
then Mika's series would need to be changed.
v2:
- use a dedicated sysfs attribute per link state
- allow separate control of ASPM and PCI PM L1 sub-states
v3:
- patch 3: statically allocate the attribute group
- patch 3: replace snprintf with printf
- add patch 4
v4:
- patch 3: add call to sysfs_update_group because is_visible callback
returns false always at file creation time
- patch 3: simplify code a little
v5:
- rebased to latest pci/next
Heiner Kallweit (4):
PCI/ASPM: add L1 sub-state support to pci_disable_link_state
PCI/ASPM: allow to re-enable Clock PM
PCI/ASPM: add sysfs attributes for controlling ASPM link states
PCI/ASPM: remove Kconfig option PCIEASPM_DEBUG and related code
Documentation/ABI/testing/sysfs-bus-pci | 13 ++
drivers/pci/pci-sysfs.c | 10 +-
drivers/pci/pci.h | 12 +-
drivers/pci/pcie/Kconfig | 7 -
drivers/pci/pcie/aspm.c | 236 ++++++++++++++++--------
include/linux/pci.h | 10 +-
6 files changed, 195 insertions(+), 93 deletions(-)
--
2.23.0
next reply other threads:[~2019-08-31 20:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 20:10 Heiner Kallweit [this message]
2019-08-31 20:15 ` [PATCH v5 1/4] PCI/ASPM: add L1 sub-state support to pci_disable_link_state Heiner Kallweit
2019-08-31 20:16 ` [PATCH v5 2/4] PCI/ASPM: allow to re-enable Clock PM Heiner Kallweit
2019-08-31 20:18 ` [PATCH v5 4/4] PCI/ASPM: remove Kconfig option PCIEASPM_DEBUG and related code Heiner Kallweit
2019-09-07 20:34 ` Bjorn Helgaas
2019-08-31 20:20 ` [PATCH v5 3/4] PCI/ASPM: add sysfs attributes for controlling ASPM link states Heiner Kallweit
2019-09-07 20:32 ` Bjorn Helgaas
2019-09-29 17:15 ` Heiner Kallweit
2019-10-02 19:55 ` Bjorn Helgaas
2019-10-02 21:10 ` Heiner Kallweit
2019-10-02 22:10 ` Bjorn Helgaas
2019-10-02 22:23 ` Heiner Kallweit
2019-10-03 14:15 ` Heiner Kallweit
2019-10-03 16:27 ` Bjorn Helgaas
2019-09-07 16:58 ` [PATCH v5 0/4] PCI/ASPM: add sysfs attributes for controlling ASPM Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c63f507f-7f52-7164-dbc5-07fc18e433b8@gmail.com \
--to=hkallweit1@gmail.com \
--cc=bhelgaas@google.com \
--cc=fred@fredlawl.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-pci@vger.kernel.org \
--cc=rajatja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).