From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:56008 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750982AbeDINLm (ORCPT ); Mon, 9 Apr 2018 09:11:42 -0400 Subject: Re: [PATCH v2 7/9] PCI: dwc: Replace lower into upper case characters To: Joe Perches , "bhelgaas@google.com" , "lorenzo.pieralisi@arm.com" , "Joao.Pinto@synopsys.com" , "jingoohan1@gmail.com" , "kishon@ti.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" Cc: "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" References: <0dad6b43476c1a70944e3e7c245040243ddc2a04.camel@perches.com> From: Gustavo Pimentel Message-ID: Date: Mon, 9 Apr 2018 14:10:44 +0100 MIME-Version: 1.0 In-Reply-To: <0dad6b43476c1a70944e3e7c245040243ddc2a04.camel@perches.com> Content-Type: text/plain; charset=utf-8 Sender: linux-pci-owner@vger.kernel.org List-ID: Hi Joe, On 09/04/2018 11:25, Joe Perches wrote: > On Mon, 2018-04-09 at 10:41 +0100, Gustavo Pimentel wrote: >> Replaces lower into upper case characters in comments and debug printks. >> >> This is an attempt to keep the messages coherent within the designware >> driver. > > It'd be nice to make all the dwc drivers use the same > message wording. > > For instance: > > drivers/pci/dwc/pci-keystone.c: dev_err(dev, "phy link never came up\n"); > drivers/pci/dwc/pcie-designware.c: dev_err(pci->dev, "phy link never came up\n"); > drivers/pci/host/pcie-xilinx-nwl.c: dev_err(dev, "PHY link never came up\n"); I also agree, I added a task to my backlog to fix that. However, this task shouldn't be done in this patch series since it's a more broader task involving many drivers and different maintainers. Agree? > Regards, Gustavo