From: Sinan Kaya <okaya@codeaurora.org>
To: Bjorn Helgaas <helgaas@kernel.org>, wangyijing <wangyijing@huawei.com>
Cc: bhelgaas@google.com, rjw@rjwysocki.net,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: release pci_host_bridge resource after remove root bus
Date: Wed, 24 Aug 2016 17:48:48 -0400 [thread overview]
Message-ID: <c9129658-d500-ac4c-ccd7-090ebcbf731d@codeaurora.org> (raw)
In-Reply-To: <20160824213921.GH23914@localhost>
On 8/24/2016 5:39 PM, Bjorn Helgaas wrote:
>> Yes, may some pci drivers make a mistake, the refcount control the device object
>> > release is fine, but I think move the mem resource release out is better.
> If this is caused by driver bugs, I think we need to fix the driver
> bugs.
>
> So far all I see here is "it works when I do this." What we need is
> an argument for "it's correct to do this." It's certainly possible
> that you're already making that argument and I'm just not
> understanding it.
>
I also want to point out that the sysfs is not the only device removal
path. As Bjorn pointed out, you were moving resource free code into the sysfs
path and breaking other path (ACPI hotplug).
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2016-08-24 21:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 11:42 [PATCH] PCI: release pci_host_bridge resource after remove root bus Yijing Wang
2016-07-25 1:18 ` wangyijing
2016-08-22 17:28 ` Bjorn Helgaas
2016-08-23 2:22 ` wangyijing
2016-08-24 21:39 ` Bjorn Helgaas
2016-08-24 21:48 ` Sinan Kaya [this message]
2016-08-25 8:16 ` wangyijing
2016-08-25 8:01 ` wangyijing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9129658-d500-ac4c-ccd7-090ebcbf731d@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).