From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:17763 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752043AbcGAHER (ORCPT ); Fri, 1 Jul 2016 03:04:17 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u6173bfl125729 for ; Fri, 1 Jul 2016 03:04:16 -0400 Received: from e23smtp05.au.ibm.com (e23smtp05.au.ibm.com [202.81.31.147]) by mx0a-001b2d01.pphosted.com with ESMTP id 23wbbbdftw-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 01 Jul 2016 03:04:16 -0400 Received: from localhost by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 1 Jul 2016 17:04:13 +1000 Subject: Re: [PATCH v3 5/7] PCI: Do not use IORESOURCE_STARTALIGN to identify bridge resources To: Gavin Shan References: <1467283993-3185-1-git-send-email-xyjxie@linux.vnet.ibm.com> <1467283993-3185-6-git-send-email-xyjxie@linux.vnet.ibm.com> <20160701023423.GB6739@gwshan> Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-doc@vger.kernel.org, bhelgaas@google.com, alex.williamson@redhat.com, aik@ozlabs.ru, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, corbet@lwn.net, warrier@linux.vnet.ibm.com, zhong@linux.vnet.ibm.com, nikunj@linux.vnet.ibm.com From: Yongji Xie Date: Fri, 1 Jul 2016 15:04:10 +0800 MIME-Version: 1.0 In-Reply-To: <20160701023423.GB6739@gwshan> Content-Type: text/plain; charset=utf-8; format=flowed Message-Id: Sender: linux-pci-owner@vger.kernel.org List-ID: Hi Gavin, On 2016/7/1 10:34, Gavin Shan wrote: > On Thu, Jun 30, 2016 at 06:53:11PM +0800, Yongji Xie wrote: >> Now we use the IORESOURCE_STARTALIGN to identify bridge resources >> in __assign_resources_sorted(). That's quite fragile. We may also >> set flag IORESOURCE_STARTALIGN for SR-IOV resources in some cases, >> for example, using the option "noresize" of parameter >> "pci=resource_alignment". >> >> In this patch, we try to use a more robust way to identify >> bridge resources. >> >> Signed-off-by: Yongji Xie > Reviewed-by: Gavin Shan > > Yongji, I think this doesn't have to be part of this series, meaning > it can be sent or merged separately. > Seems like I give a wrong example in my changelog. The parameter "pci=resource_alignment" would not set flag IORESOURCE_STARTALIGN for SR-IOV resources as I replied to you in previous patch. So this patch has nothing to do with this series now, I will remove it as you suggested. Thanks, Yongji